react-spectrum
fix(#1478) Button with `display: none` breaks keyboard navigation in <FocusScope contain>
#1493
Merged
Overview
Commits
23
Changes
View On GitHub

fix(#1478) Button with `display: none` breaks keyboard navigation in <FocusScope contain> #1493

devongovett merged 23 commits into adobe:main from majornista:Issue-1478
majornista
majornista majornista requested a review from dannify dannify 4 years ago
majornista majornista requested a review from devongovett devongovett 4 years ago
majornista majornista requested a review from snowystinger snowystinger 4 years ago
majornista majornista force pushed from 1fc3f553 to cdc684bb 4 years ago
LFDanLu
LFDanLu commented on 2021-01-26
majornista
majornista
snowystinger
majornista
majornista commented on 2021-02-19
majornista majornista force pushed from 695c2536 to cce1045a 4 years ago
majornista
snowystinger
snowystinger commented on 2021-02-22
snowystinger
snowystinger commented on 2021-02-22
majornista
fix(#1478): Button with `display: none` breaks keyboard navigation in…
e7ee0d8d
fix(#1478): refactor to use getFocusableTreeWalker
07c5b75e
fix(#1478): refactor focusPrevious to use getFocusableTreeWalker
bf55bb4e
fix(#1478): remove unused focusManager instance
a00aec4f
fix(#1478): refactor useFocusContainment to use getFocusableTreeWalker
d35344c1
fix(#1478): make syntax more consistent
88414e51
fix(#1478): don't tree walk to manage focus when nodeToRestore === do…
89a58288
fix(#1478): Add unit tests for FocusScope edge cases
6cb63be0
fix(#1478): Refactor focusPrevious and tests to remove additional tre…
f7f7b92e
majornista majornista force pushed from b7ec333a to f7f7b92e 4 years ago
LFDanLu
LFDanLu dismissed these changes on 2021-02-26
fix(#1570): FocusScope causing unintended focus trap
b485952c
majornista majornista dismissed their stale review via b485952c 4 years ago
LFDanLu
LFDanLu commented on 2021-03-02
fix(#1570): refactor FocusScope causing unintended focus trap
7be94d36
majornista majornista added accessibility
Merge branch 'main' into Issue-1478
5c239031
snowystinger
snowystinger commented on 2021-03-15
fix(#1478): Add license notice for adapted code
ea922d85
snowystinger
snowystinger dismissed these changes on 2021-03-15
Merge branch 'main' into Issue-1478
b9e06919
devongovett
devongovett commented on 2021-03-18
fix(#1478): refactor to use userEvent.tab() in tests
44fcb24a
majornista majornista dismissed their stale review via 44fcb24a 4 years ago
fix(#1478): fix lint errors caused by missing semicolons
47960548
fix(#1478): fix lint errors caused by extra semicolons
f33e2c40
Merge branch 'main' into Issue-1478
13b5fb71
Merge remote-tracking branch 'adobe/main' into Issue-1478
aa3e2335
fix(#1478): FocusScope: refactor getScopeRoot
8571a808
tristandubbeld
majornista
majornista
majornista
Merge branch 'main' into Issue-1478
91f55231
tristandubbeld
majornista
tristandubbeld
majornista majornista requested a review from devongovett devongovett 4 years ago
majornista majornista requested a review from snowystinger snowystinger 4 years ago
majornista majornista requested a review from LFDanLu LFDanLu 4 years ago
fix(#1478): reduce the number of calls to isElementInScope
c63c2438
devongovett devongovett assigned devongovett devongovett 4 years ago
devongovett
devongovett commented on 2021-04-15
fix(#1478): updates per code review
5fce6a52
snowystinger
snowystinger approved these changes on 2021-04-15
devongovett
devongovett approved these changes on 2021-04-15
devongovett devongovett merged 1e2b7f28 into main 4 years ago
Andarist
Andarist commented on 2021-06-21
majornista majornista deleted the Issue-1478 branch 3 years ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
Labels
accessibility
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum