react-spectrum
(RSP-1338) V3 Menu Items and semantic element conversion
#171
Merged

(RSP-1338) V3 Menu Items and semantic element conversion #171

devongovett merged 34 commits into master from v3_menu_items_2
LFDanLu
LFDanLu Moving each Menu component into it's own file
ff819429
LFDanLu Adding useMenuItem aria hook
e33776d9
LFDanLu Initial conversion to use semantic elements and grid css
76c57cce
LFDanLu Getting rid of extra space
581100d0
LFDanLu LFDanLu requested a review from dannify dannify 5 years ago
LFDanLu LFDanLu requested a review from devongovett devongovett 5 years ago
LFDanLu LFDanLu requested a review from snowystinger snowystinger 5 years ago
adobe-bot
LFDanLu Adding react-types/menu
04d18285
adobe-bot
LFDanLu Updating multiselect menuitem to have checkboxes and supporting keybo…
43ad3999
adobe-bot
LFDanLu Cleaning up comments and updating stories
d6952e9d
LFDanLu WIP Menu Checkbox and Switch support
0b5c7f9b
LFDanLu Adding closeOnSelect and replacing setOpen call in MenuItems with onC…
db7a87aa
LFDanLu fixing lint and passing closeOnSelect down to menu item
b656e2f4
LFDanLu Updating story and css for description slot
3b4364e6
adobe-bot
LFDanLu Updating menutrigger test to use v3 menu
864a898c
adobe-bot
LFDanLu Removing checkbox multiselect and switch examples
1ad14bcd
LFDanLu Updating MenuTrigger tests to use v3 Menu
2c24a550
LFDanLu Adding some more menuTrigger tests
6ff2b536
LFDanLu fixing lint and removing some stragglers from checkbox/switch menu it…
8c90de9e
adobe-bot
LFDanLu More tests for Menu
eb9e232d
adobe-bot
LFDanLu Adding useMenuItem tests and updating other tests
98c99456
LFDanLu fixing lint
e5b1ca28
LFDanLu Cleaning up css
4a450f60
LFDanLu LFDanLu changed the title (WIP) (RSP-1338) V3 Menu Items and semantic element conversion (RSP-1338) V3 Menu Items and semantic element conversion 5 years ago
adobe-bot
adobe-bot
snowystinger
snowystinger commented on 2020-01-30
MidnightCoder06
MidnightCoder06 commented on 2020-01-31
LFDanLu Addressing review comments
16c92153
LFDanLu Merge branch 'master' of https://github.com/adobe-private/react-spect…
2a8255d4
adobe-bot
majornista
LFDanLu
LFDanLu Making menuitem selection via ENTER always close menu
cfffebe5
adobe-bot
devongovett
devongovett commented on 2020-02-01
LFDanLu Changing menu grid area to match keyboard and text element default slots
6a3db7d4
LFDanLu Merge branch 'master' of https://github.com/adobe-private/react-spect…
9a8304eb
adobe-bot
LFDanLu
LFDanLu Overwrite user agent styles for <p> to preserve menu text styling
a7af7c50
adobe-bot
LFDanLu Add more items to default menu story
868d9090
adobe-bot
MidnightCoder06
MidnightCoder06 dismissed these changes on 2020-02-07
majornista
majornista commented on 2020-02-10
LFDanLu Merge branch 'master' of https://github.com/adobe-private/react-spect…
9ccb85fd
LFDanLu
adobe-bot
majornista
majornista requested changes on 2020-02-11
LFDanLu
LFDanLu tweaking autofocus behavior
c015eb64
LFDanLu LFDanLu dismissed their stale review via c015eb64 5 years ago
adobe-bot
ktabors
ktabors commented on 2020-02-15
LFDanLu Merge branch 'master' of https://github.com/adobe-private/react-spect…
2d701719
LFDanLu addressing review comments
1cb0757e
devongovett
devongovett commented on 2020-02-15
adobe-bot
LFDanLu Merge branch 'master' of https://github.com/adobe-private/react-spect…
66d756ea
LFDanLu simplifying merge props in useMenuItem
ee754005
adobe-bot
LFDanLu Merge branch 'master' of https://github.com/adobe-private/react-spect…
4e35cc16
lgtm-com
adobe-bot
snowystinger
snowystinger commented on 2020-02-27
devongovett
devongovett approved these changes on 2020-02-28
devongovett devongovett merged 47983549 into master 5 years ago

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone