react-spectrum
Show all items when manually opening ComboBox menu
#1749
Merged

Show all items when manually opening ComboBox menu #1749

devongovett merged 27 commits into main from issue_1705
LFDanLu
LFDanLu initial progress w/ combobox menu show all
f05790a4
LFDanLu removing memo for original collection now that collection is not modi…
e1a1ae5b
LFDanLu making it so combobox w/ empty items list does not open even with new…
99167eaf
LFDanLu fixing bug where mobile combobox only showed filtered list upon two e…
20fdd5a9
LFDanLu apply review comments from meeting
2f804963
LFDanLu tweaking story and fixing lint
d7292af5
LFDanLu fixing tests
02449b1b
LFDanLu LFDanLu requested a review from dannify dannify 4 years ago
LFDanLu LFDanLu requested a review from devongovett devongovett 4 years ago
LFDanLu LFDanLu requested a review from snowystinger snowystinger 4 years ago
LFDanLu adding more tests
b7b0ef21
LFDanLu fixing lint and extra test
5f0319ce
adobe-bot
LFDanLu cleanup and adding useCombobox hooks for show all items
c00c7b17
LFDanLu fixing chain call
8c34e099
adobe-bot
LFDanLu
LFDanLu updating docs with example of show all when items are controlled
4bc15f04
LFDanLu fixing doc example
6d17fba1
adobe-bot
adobe-bot
LFDanLu
LFDanLu commented on 2021-03-31
LFDanLu
LFDanLu commented on 2021-03-31
LFDanLu
LFDanLu commented on 2021-03-31
LFDanLu more clean up
f9a805f2
LFDanLu LFDanLu changed the title (WIP) Show all items when manually opening ComboBox menu Show all items when manually opening ComboBox menu 4 years ago
LFDanLu Merge branch 'main' into issue_1705
e470fef8
adobe-bot
adobe-bot
devongovett devongovett added needs API review
LFDanLu Merge branch 'main' of github.com:adobe/react-spectrum into issue_1705
1ae50870
LFDanLu first stab at making combobox onopenchange return reason for menu open
5f5f0c37
LFDanLu updating useComboBox tests and docs
81bc207e
devongovett devongovett removed needs API review
devongovett devongovett assigned devongovett devongovett 4 years ago
LFDanLu fixing tests
e4fd93e4
adobe-bot
devongovett
devongovett commented on 2021-04-15
LFDanLu updating useComboBoxState open/toggle conditional
d3e8ab11
adobe-bot
LFDanLu addressing review comments
ad7c6957
LFDanLu Merge branch 'main' into issue_1705
fc5b8e55
adobe-bot
adobe-bot
LFDanLu removing docs changes
d775a391
LFDanLu Merge branch 'issue_1705' of github.com:adobe/react-spectrum into iss…
a8f94f14
adobe-bot
LFDanLu Merge branch 'main' into issue_1705
685863f6
adobe-bot
LFDanLu removing extraneous conditional from collection return statement
10dafe32
LFDanLu Merge branch 'issue_1705' of github.com:adobe/react-spectrum into iss…
2c714218
adobe-bot
devongovett
devongovett approved these changes on 2021-04-21
devongovett devongovett merged 8c55e676 into main 4 years ago
devongovett devongovett deleted the issue_1705 branch 4 years ago

Login to write a write a comment.

Login via GitHub

Assignees
Labels
Milestone