Cache react 17 install in CI #1797
Try to install 17 in such a way that we can cache it for tests and stβ¦
fix config error
fix issue where i hadn't actually pulled the code into 17
Build successful! π
react 17 install shouldn't depend on react 16's install step if possible
Build successful! π
Build successful! π
use yarn partial lock matches for caches
try to fix persist paths
debugging
possibly dist didn't exist, try manually adding it
rename test-17 to fit the rest of the names
not sure why we'd need to do this now, * should work, but it's not fiβ¦
a different pattern variation
follow docs suggestion to include tmp in root
may have pushed some bad cache names, be very explicit about them
Build successful! π
try again to skip building icons for comments job
Build successful! π
debug branch name of cache
Build successful! π
Add versioning to cache so I don't run into the issue i did earlier
Build successful! π
Build successful! π
used invalid config but wasn't getting that as a message
Build successful! π
| 16 | keys: | ||
| 17 | - rsp-yarn-{{ .Environment.CACHE_VERSION }}-{{ .Branch }}-{{ checksum "yarn.lock" }} | ||
| 18 | - rsp-yarn-{{ .Environment.CACHE_VERSION }}-{{ .Branch }}- | ||
| 19 | - rsp-yarn-{{ .Environment.CACHE_VERSION }}- |
devongovett4 years agoDoes this need to restore the react-spectrum- cache as well, which is saved below?
snowystinger4 years ago (edited 4 years ago)this will restore ~/.cache/yarn
react-spectrum- key will restore source code, which may be different than what was received from checkout
seemed safer to use the checkout code and rebuild what we need
this may be a further optimization down the line if builds start getting longer again, but we'd need to be careful with it
the only reason the key react-spectrum- exists is because it's the code checked out with postinstall run, so we can now run lint/tests/storybook etc, those steps no longer checkout the code, they rely on this cache. we could have persisted it to the workspace as well, but I didn't look into the performance differences there yet, future possible optimization
devongovett4 years agohmm so why to we write to the react-spectrum cache key then if we don't use it?
snowystinger4 years agoyou'll also note that there are both a react-spectrum- and react-spectrum17 cache key, so those downstream jobs can get the code all setup with the right react version
Merge branch 'main' into cached-react-17-install
Build successful! π
Login to write a write a comment.
Try to install 17 in such a way that we can cache it for tests and storybook
from ~15min down to ~9min!
cache behavior for yarn described in here https://circleci.com/docs/2.0/caching/#yarn-node
versioned caching here https://circleci.com/docs/2.0/caching/#clearing-cache
Closes
β Pull Request Checklist:
π Test Instructions:
π§’ Your Project: