react-spectrum
Implement help text for TextField, TextArea, SearchField, and Picker
#1846
Merged
Overview
Commits
55
Changes
View On GitHub

Implement help text for TextField, TextArea, SearchField, and Picker #1846

snowystinger merged 55 commits into adobe:main from dkario:help_text
dkario
snowystinger Update useControlledState for StrictMode
573b61ef
snowystinger remove out of date comment
703e2081
Add help text interfaces
a8c2ae6b
Basic setup for useField
d1715ac2
Add HelpText to Field when description or errorMessage exist
d25336a4
Start adding desc/err msg to TextField and Combobox
ef63a485
dkario
dkario commented on 2021-04-26
LFDanLu
LFDanLu commented on 2021-04-29
Fix render and aria-describedby logic
3fdfdb64
Merge branch 'main' into help_text
a9ddbc5e
Merge branch 'main' into help_text
8a0ad5be
More improvements to rendering logic
22e6d038
Only return props for desc/errMsg if they're passed in
a20fb766
Refactor TextFieldBase to use Field
29d75ab7
snowystinger
snowystinger commented on 2021-05-11
Merge branch 'main' into help_text
de439536
Preserve aria-describedby prop
5e90306f
dannify dannify assigned dannify dannify 4 years ago
dannify
dannify dismissed these changes on 2021-05-20
Merge branch 'main' into help_text
a3fe9e01
Remove useField.mdx placeholder doc
a550de77
Props syntax refactor
0d34e667
Linting and type fixes
ba401c40
Merge branch 'main' into help_text
7da9039a
Create HelpText stories and chromatic
8ae8d884
Add Textfield stories
fd026b2a
snowystinger
snowystinger commented on 2021-06-25
Merge remote-tracking branch 'upstream/main' into help_text
70085dbf
Add styles
1ead9e2a
snowystinger
snowystinger commented on 2021-08-08
Update styles with latest from spectrum-css and support showIcon
3ff8b624
Support fields with no visible label
a4d479ad
Make 'description and error message' story interactive
ced28a18
Pass temp Field props in SearchWithin to fix lint
e5c0e89e
Merge remote-tracking branch 'upstream/main' into help_text
891ba911
Fix field styles when labelPosition: side
8127dddb
Remove unused styleProps reference from TextFieldBase
ceccb8b3
Support labelAlign=end
0801b036
Add help text to Form stories and fix labelPosition=side styles
ed709538
Remove unused style
e53da34c
Remove 2nd margin between icon and help text when labelAlign=end
61a0ffdf
Add more chromatic stories
0fb62ead
Refactor labelAlign=side style
f535af1f
Merge remote-tracking branch 'upstream/main' into help_text
8a12467f
Add help text to MobileComboBox
1ef78a70
Add help text to Picker
167a89b4
Merge remote-tracking branch 'upstream/main' into help_text
799dab2c
WIP: Add help text to CheckboxGroup
1bc5a73c
Revert "WIP: Add help text to CheckboxGroup"
7b3beb3a
Merge remote-tracking branch 'upstream/main' into help_text
9defef82
Temporarily remove help text from Combobox
bcb9fc06
Make descriptionProps, errorMessageProps opt. on SpectrumFieldProps
6fe292b3
Add help text to SearchField and TextArea
aa7a7927
dkario dkario changed the title Help text WIP for Combobox Implement help text for TextField, TextArea, SearchField, and Picker 4 years ago
dkario dkario marked this pull request as ready for review 4 years ago
dkario dkario requested a review from devongovett devongovett 4 years ago
dkario dkario requested a review from majornista majornista 4 years ago
dkario dkario requested a review from LFDanLu LFDanLu 4 years ago
dkario dkario requested a review from snowystinger snowystinger 4 years ago
dkario dkario requested a review from dannify dannify 4 years ago
LFDanLu
LFDanLu dismissed these changes on 2021-08-23
PR comments: Add doc comment block & validationState=valid story
fc20b01c
PR comments: rename showIcon to showErrorIcon
7de4edba
Merge remote-tracking branch 'upstream/main' into help_text
b3b28229
Merge remote-tracking branch 'upstream/main' into help_text
a05aacc8
dannify dannify assigned devongovett devongovett 4 years ago
snowystinger
snowystinger commented on 2021-08-25
devongovett
devongovett commented on 2021-08-27
Skip failing NumberField test
982f9884
Don't let form fields accept showErrorIcon prop
29b95d91
Remove useField from monorepo for now
b8e9fba1
dkario dkario requested a review from devongovett devongovett 4 years ago
Merge remote-tracking branch 'upstream/main' into help_text
a1507697
dkario dkario requested a review from LFDanLu LFDanLu 4 years ago
Merge remote-tracking branch 'upstream/main' into help_text
e627a1c1
devongovett
devongovett approved these changes on 2021-08-31
snowystinger
snowystinger approved these changes on 2021-08-31
snowystinger snowystinger dismissed their stale review 4 years ago
done
snowystinger snowystinger dismissed their stale review 4 years ago
done
snowystinger snowystinger merged 07956172 into main 4 years ago
dkario dkario deleted the help_text branch 4 years ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
Labels
None yet
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum