PR #1922 TagGroup - SemanticDiff

TagGroup #1922

dannify merged 44 commits into main from taggroup

initial TagGroup commit

6e3130f1

jluyau requested a review from

dannify 4 years ago

jluyau requested a review from

devongovett 4 years ago

jluyau requested a review from

snowystinger 4 years ago

jluyau changed the title ~~initial TagGroup commit~~ [WIP] TagGroup 4 years ago

lint

dbbe675f

another lint

f450b3bf

temp skip tests

9280b39b

Merge branch 'main' of github.com:adobe/react-spectrum into taggroup

4e51f884

slotting tags

291e782a

tag group styling

45975073

snowystinger commented on 2021-09-15

Merge branch 'main' of github.com:adobe/react-spectrum into taggroup

0d61c4c1

update taggroup icon story

2ffa9b69

undo bad pull from main

c2202544

linting

377a136a

Merge branch 'main' of github.com:adobe/react-spectrum into taggroup

5586040f

add roles. update tests

bf97d2c7

pass custom props to indiv tag

b4918eef

update grid version

d3a79ab4

add missing param

b8883fc8

Merge branch 'main' into taggroup

69d9ddf1

snowystinger commented on 2021-10-28

use padding-inline-start for styling

8dce23b5

Merge branch 'main' of github.com:adobe/react-spectrum into taggroup

fa23d87f

snowystinger commented on 2021-11-03

LFDanLu commented on 2021-11-03

onRemove button styling, typing, add story

49c352a9

remove useTag tests, styling

356c1fb8

merge props together

6dba19f8

tag focus and keyboard nav

844d04ea

majornista requested changes on 2021-11-10

clear button role and css

cb23a228

tiffany-sy-lin requested a review from

majornista 3 years ago

move tag ref declarations out of useTag

dc2caa8a

linting

a35a6d8a

more linting

e163152e

add rowheader role to tags

7b31d69c

tiffany-sy-lin requested a review from

snowystinger 3 years ago

tiffany-sy-lin requested a review from

tiffany-sy-lin 3 years ago

tiffany-sy-lin requested a review from

LFDanLu 3 years ago

LFDanLu requested changes on 2021-12-03

LFDanLu commented on 2021-12-03

Merge branch 'main' of github.com:adobe/react-spectrum into taggroup

1da0b97c

majornista requested changes on 2021-12-15

typo

5337c3a2

remove cycleMode from GridKeyboardDelegate

eff5861d

consolidate tag roles

05be8092

Merge branch 'main' of github.com:adobe/react-spectrum into taggroup

8f00b1d1

wip keyboard nav

8f5219cf

fix refs and props spreading and keyboard nav

86fe9469

majornista commented on 2022-01-19

add A TON of tests

6e2e5329

prevent focus on remove button

9dac424c

skip disabled tags in keyboard nav

d32a5df2

remove unused packages

0cfd8c78

add translations

8c6370a0

LFDanLu dismissed these changes on 2022-01-27

majornista requested changes on 2022-01-31

remove extra aria label, unneeded intl files, and add labelId to props

b7ddd9f7

tiffany-sy-lin dismissed their stale review via b7ddd9f7 3 years ago

tiffany-sy-lin requested a review from

majornista 3 years ago

snowystinger commented on 2022-02-03

ktabors commented on 2022-02-03

majornista dismissed these changes on 2022-02-04

dannify changed the title ~~[WIP] TagGroup~~ TagGroup 3 years ago

snowystinger dismissed these changes on 2022-02-04

remove console.log

c0903760

tiffany-sy-lin dismissed their stale review via c0903760 3 years ago

Merge branch 'main' into taggroup

10b2058e

snowystinger approved these changes on 2022-02-10

dannify approved these changes on 2022-02-11

Merge branch 'main' into taggroup

fcddfc0c

dannify dismissed their stale review 3 years ago

Will be handled in a followup

dannify merged cc5deace into main 3 years ago

dannify deleted the taggroup branch 3 years ago

Reviewers

dannify

snowystinger

majornista

ktabors

reidbarber

LFDanLu

tiffany-sy-lin

dkario

devongovett

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

react-spectrum TagGroup #1922 Merged

TagGroup #1922

react-spectrum
TagGroup
#1922

Merged