react-spectrum
Moving default focus behavior from Menu into useSelectableCollection
#211
Merged

Moving default focus behavior from Menu into useSelectableCollection #211

devongovett merged 24 commits into master from RSP-1399
LFDanLu
LFDanLu LFDanLu requested a review from dannify dannify 5 years ago
LFDanLu LFDanLu requested a review from devongovett devongovett 5 years ago
LFDanLu LFDanLu requested a review from snowystinger snowystinger 5 years ago
LFDanLu LFDanLu changed the base branch from master to v3_menu_items_2 5 years ago
LFDanLu LFDanLu force pushed from 3b7bde8b to 2a02323b 5 years ago
adobe-bot
LFDanLu LFDanLu changed the title (WIP) Moving default focus behavior from Menu into useSelectableCollection Moving default focus behavior from Menu into useSelectableCollection 5 years ago
devongovett devongovett changed the base branch from v3_menu_items_2 to master 5 years ago
LFDanLu LFDanLu changed the base branch from master to v3_menu_items_2 5 years ago
LFDanLu Adding useMenuItem aria hook
8ce06ac5
LFDanLu Initial conversion to use semantic elements and grid css
0ed9c063
LFDanLu Updating multiselect menuitem to have checkboxes and supporting keybo…
aa2ecab3
LFDanLu Cleaning up comments and updating stories
d10671e6
LFDanLu WIP Menu Checkbox and Switch support
89a28c65
LFDanLu Adding closeOnSelect and replacing setOpen call in MenuItems with onC…
4f5e2227
LFDanLu fixing lint and passing closeOnSelect down to menu item
ba142a05
LFDanLu Updating menutrigger test to use v3 menu
84d7b647
LFDanLu Removing checkbox multiselect and switch examples
e8cfc369
LFDanLu Updating MenuTrigger tests to use v3 Menu
a70b6f28
LFDanLu Adding some more menuTrigger tests
b431b2c5
LFDanLu fixing lint and removing some stragglers from checkbox/switch menu it…
b10ea698
LFDanLu Making menuitem selection via ENTER always close menu
065c54e3
LFDanLu Changing menu grid area to match keyboard and text element default slots
973658e6
LFDanLu initial port of focus useEffect from Menu to useSelectableCollection
1a5f19bd
LFDanLu Adding wrapAround input param to useSelectableCollection
e62fbdca
LFDanLu changing autofocus default to false
eb642807
LFDanLu updates from design review meeting
0f13c763
LFDanLu skipping focus logic if autofocus is false
1d1e540d
LFDanLu Fixing menu tests
5d438a4e
LFDanLu Only set manager focus if autoFocus is true
280fba7a
LFDanLu fixing lint
3c689f27
LFDanLu messed a little bit of the rebase, fixing
6c6e87cd
LFDanLu LFDanLu force pushed from 7fd54d21 to 6c6e87cd 5 years ago
LFDanLu LFDanLu changed the base branch from v3_menu_items_2 to master 5 years ago
LFDanLu Merge branch 'master' of https://github.com/adobe-private/react-spect…
32e80d7f
devongovett
devongovett approved these changes on 2020-02-28
adobe-bot
adobe-bot
devongovett devongovett merged 0246daa8 into master 5 years ago
devongovett devongovett deleted the RSP-1399 branch 5 years ago

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone