CardView #2228
devongovett
merged
67 commits into
main
from
issue_2083_cardview
LFDanLu
commented
on 2021-08-26
LFDanLu
commented
on 2021-09-01
dannify
commented
on 2021-09-20
dannify
commented
on 2021-09-20
Base automatically changed from
starter-cards
to
main
4 years ago
plop setup
d12b8b80
saving progress
b5e9a41d
BaseLayout and GridLayout progress
9c72b852
more progress with converting v2 gridlayout
3e36036d
working grid layout barring some collection oddities
1c8c41c0
changing it so that I pass the list collection to the Virtualizer ins…
23ef0675
cleanup and some typescript fixes
98bc6455
fixing getVisibleLayoutInfos and adding centered wrapper
07ec5fe3
fixing loader/placeholder not showing up
cb38c143
using keyboard delegate from grid layout
923ca4c0
more cleanup and adding intl files
e33f157e
updating story format
e4aad7b9
fixing keyboard nav when layout is directly provided instead of const…
3d51fbe5
tentative change to make onSelectionChange return the card key
f2af0c16
renaming package name to cards to align with Robs work
5dfe12ee
clean up some remaining card -> cards from package rename
51111634
adding rough focus style for testing and attempting to unify card
833b8453
adding class name for card grid
49669f63
fixing refs passed into CardBase
eab59ae6
updating cardbase and cardview to use correct context and pass cardvi…
02311361
fixing loadingMore state and card content cutoff
5f2b4279
actuallying fixing loadingMore state
5253bb14
adding typeahead to gridlayout
4c9fa05e
updating stories to have different image sizes
13cb0b89
fixing image preview height, rounded corners, and updating card class
be94b4c7
cleanup and typescript stuff
7c90001a
fixing Card forwardRef collectionBuilder error
cf00e9bd
adding Gallery and waterfall layout wips
f4e82fa7
progress on gallery layout and removing cache stuff
8e1ab05c
fixing up/down/pgUp/pgDown for gallery and changing to layoutType ins…
6163ed98
Adding in progress waterfall layout and refactor to share things in b…
c217b6a3
adding button to remove cards in story
f3d11cab
updating card css for specific layout, saving gallery layout progress…
1587dd20
fixing missing stuff from rebase
e33acabb
fixing rtl nav in waterfall and adjusting closest layout info calcula…
64da48ae
refine closestRight/Left logic in waterfall layout some more
403a6963
fixing gallery layout card sizing and fixing focus ring/border for wa…
d57f2bf4
removing sizeToFit from cardview
1f5ff0ed
adding baseline chromatic stories and removing cardview mdx
9f63f997
removing drag and drop v2 code for now
f802dbfa
move common getKeyLeft/Right to baseLayout
47250ebf
remove logic for placeholder images and updateItemSize in gallery/grid
731aca02
tentative fix to make waterfall cards follow the min item size set
cdbc87e4
fixing partial lint
e8d366d1
refactor stories
b7bf34ff
adding selection stories
eb870e1c
removing allowsCellSelection for another approach
3c3c1d30
removing previous min height guard from waterfall layout
179db795
adding async stories and properly removing loading spinner when loadi…
6ee642ea
adding stories to check placeholder cleanup
a8b1c507
adding tests in progress
7770ef1c
adding keyboard nav for the rest of the card view layout tests
5f861434
updating waterfall layout logic for left/right key
b5b6c40e
adding basic selection and loading tests for CardView
38d71cc8
fixing lint and updating Layout type provided to CardView
e5ae121f
removing card size for now
a2f4fb76
fixing keyboard/mouse selection for CardView
be1ef47c
adding custom layout option stories
eef6cff3
make static stories more varied
4b74317a
adding a no thin images story to gallery layout
b182aa55
fixing dependency array
f2d26436
adding TODO for Card typing
2b4673f6
Updating dep versions
7e8bb102
fix range dep
9416b82e
Update packages/@react-spectrum/cards/src/index.ts
618c47fa
Apply suggestions from code review
329fb231
Fixup
54a1454f
devongovett
approved these changes
on 2021-09-20
snowystinger
approved these changes
on 2021-09-20
Login to write a write a comment.
Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone