react-spectrum
Fix SearchWithin aria-label and aria-labelledby
#2288
Merged
Overview
Commits
34
Changes
View On GitHub

Fix SearchWithin aria-label and aria-labelledby #2288

reidbarber merged 34 commits into main from Issue-2174-SearchWithin-AriaLabels
reidbarber
reidbarber fix aria-label and aria-labelledby in searchwithin
6a28363d
reidbarber update tests
b4dfbb53
reidbarber fix story
aaba4e68
reidbarber reidbarber added rsp:SearchWithin
reidbarber reidbarber requested a review from dannify dannify 4 years ago
reidbarber reidbarber requested a review from devongovett devongovett 4 years ago
reidbarber reidbarber requested a review from snowystinger snowystinger 4 years ago
adobe-bot
ktabors
ktabors commented on 2021-09-10
reidbarber Merge branch 'main' into Issue-2174-SearchWithin-AriaLabels
e0828425
adobe-bot
snowystinger Merge branch 'main' into Issue-2174-SearchWithin-AriaLabels
3e260e1c
adobe-bot
snowystinger Get translations started, block help text on sub components
f1a55abc
snowystinger
snowystinger commented on 2021-10-08
reidbarber Merge branch 'main' into Issue-2174-SearchWithin-AriaLabels
d43d47e1
reidbarber fix SearchWithin deps
29c37813
reidbarber merge main
473dd7fc
adobe-bot
adobe-bot
reidbarber fix labels for group and elements
f3d125da
reidbarber fix test cases for aria-label application
d114f666
reidbarber fix style regression when focuses
cd42b92b
reidbarber add story for when no label or aria-label provided
1c065b08
adobe-bot
ktabors
ktabors approved these changes on 2021-11-05
ktabors
ktabors dismissed these changes on 2021-11-05
snowystinger
snowystinger commented on 2021-11-05
reidbarber improve input query in tests
e90e8b90
reidbarber fix default label case
b92d67a2
reidbarber reidbarber dismissed their stale review via b92d67a2 4 years ago
adobe-bot
reidbarber Merge branch 'main' into Issue-2174-SearchWithin-AriaLabels
3d0bc992
adobe-bot
snowystinger
snowystinger dismissed these changes on 2021-11-09
LFDanLu
LFDanLu requested changes on 2021-11-09
LFDanLu
LFDanLu refactor for review
53343681
reidbarber fix tests verify labels
42febf55
reidbarber reidbarber dismissed their stale review via 42febf55 4 years ago
adobe-bot
snowystinger
snowystinger commented on 2021-11-09
reidbarber fix mising label warning
db0aec0d
adobe-bot
reidbarber remove useLabels
38add861
LFDanLu
LFDanLu commented on 2021-11-10
reidbarber use better labels in stories
fbdd4a98
adobe-bot
ktabors
ktabors commented on 2021-11-11
reidbarber fix test for searchfield label
36e31542
adobe-bot
reidbarber Merge branch 'main' into Issue-2174-SearchWithin-AriaLabels
103a4e67
adobe-bot
snowystinger Merge branch 'main' into Issue-2174-SearchWithin-AriaLabels
d24edb71
adobe-bot
reidbarber modify useSelect id to use id from triggerProps
4371f6b1
reidbarber update searchwithin label logic
7ac70858
reidbarber fix searchwithin label tests
b79d826f
reidbarber fix lint
6713f39a
adobe-bot
snowystinger
snowystinger commented on 2022-01-07
reidbarber add comment explaining useSelect id change
d2d65474
reidbarber simplify searchwithin label tests titles
7539a646
adobe-bot
snowystinger
snowystinger commented on 2022-01-07
reidbarber override user-provided aria-label for searchfield
84842e88
adobe-bot
snowystinger
snowystinger dismissed these changes on 2022-01-08
majornista
majornista dismissed these changes on 2022-01-10
reidbarber reidbarber requested a review from LFDanLu LFDanLu 3 years ago
LFDanLu
LFDanLu dismissed these changes on 2022-01-10
reidbarber add story for external label
48e86506
reidbarber reidbarber dismissed their stale review via 48e86506 3 years ago
reidbarber reidbarber dismissed their stale review via 48e86506 3 years ago
reidbarber reidbarber dismissed their stale review via 48e86506 3 years ago
adobe-bot
LFDanLu
LFDanLu approved these changes on 2022-01-11
snowystinger Merge branch 'main' into Issue-2174-SearchWithin-AriaLabels
2e6fe519
snowystinger
snowystinger approved these changes on 2022-01-11
adobe-bot
reidbarber Merge branch 'main' into Issue-2174-SearchWithin-AriaLabels
19c16c5a
adobe-bot
reidbarber reidbarber merged 1597756b into main 3 years ago
reidbarber reidbarber deleted the Issue-2174-SearchWithin-AriaLabels branch 3 years ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
rsp:SearchWithin
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum