Add close through a child function to dialogs #234
devongovett
merged
27 commits into
master
from
function-as-a-child-dialog-triggers
starting work on closable dialogs
c02b5fc1
Works, now for types and dismiss button
e5743577
Merge branch 'master' into function-as-a-child-dialog-triggers
4f0b9a23
update to yarn lock because apparently it didn't resolve correctly wh…
c2fb8ed0
update a bunch of stories and add a test
70fa9ba0
Merge branch 'master' into function-as-a-child-dialog-triggers
9af5066e
Hook up dismissable
36216d62
appease typescript
ccd69015
Fix other isDismissable instances
699faaa8
Merge branch 'master' into function-as-a-child-dialog-triggers
c0ea7984
kill me, i hate typescript
a0e593fa
finally fixed all the things
c6618ff7
Add a test for isDismissable behaviors
57297a88
write tests for alert dialog
a74def26
Merge branch 'master' into function-as-a-child-dialog-triggers
81818371
LFDanLu
commented
on 2020-03-03
Addressing review comments
215eed5f
Merge branch 'master' of https://github.com/adobe-private/react-spect…
c5ac3f5d
Merge branch 'master' of https://github.com/adobe-private/react-spect…
5e196aa0
fixing some of the types and missed merge stuff
b6ed84f5
Making dismissible modals (ONLY) closable by underlay click
99fac46f
adding tests for useOverlay closeOnInteractOutside
edb4f4dc
Merge branch 'master' of https://github.com/adobe-private/react-spect…
ce2801ea
fixing lint
5a934ce2
ktabors
commented
on 2020-03-07
updating test as per review
76773da6
snowystinger
commented
on 2020-03-09
Merge branch 'master' into function-as-a-child-dialog-triggers
fb927183
ktabors
dismissed these changes
on 2020-03-09
MidnightCoder06
dismissed these changes
on 2020-03-09
Addressing review comments
528bb836
Merge branch 'master' into function-as-a-child-dialog-triggers
e1559747
devongovett
approved these changes
on 2020-03-10
Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Login to write a write a comment.
Login via GitHub