react-spectrum
CardView grid layout UX fixes + horizontal card support
#2481
Merged

CardView grid layout UX fixes + horizontal card support #2481

LFDanLu merged 27 commits into main from issue_2285
LFDanLu
LFDanLu preventing clicks/taps on focusable elements from scrolling virtualiz…
b0e15314
LFDanLu adding transitions on card removal + load to CardView
f15a23ce
LFDanLu rough support for horizontal card orientation in grid layout
ab71c048
LFDanLu moving card view styles into spectrum-css and removing blue outline f…
f587adb1
LFDanLu updating story format to csf as per review
5024f326
LFDanLu modifying default size of horizontal cards + removing selection mode …
c74e1aca
LFDanLu adding scale to layouts and shifting default itemPadding values to la…
49e88c73
LFDanLu fixing grid layout isVisible check
5820f2d5
LFDanLu LFDanLu requested a review from dannify dannify 4 years ago
LFDanLu LFDanLu requested a review from devongovett devongovett 4 years ago
LFDanLu LFDanLu requested a review from snowystinger snowystinger 4 years ago
LFDanLu LFDanLu changed the title CardView grid layout UX fixes + horizontal card support (WIP) CardView grid layout UX fixes + horizontal card support 4 years ago
LFDanLu
LFDanLu commented on 2021-10-21
LFDanLu fixing scroll when clicking on action menu trigger in card view
fa45161e
LFDanLu fixing tests
64ad6825
LFDanLu LFDanLu changed the title (WIP) CardView grid layout UX fixes + horizontal card support CardView grid layout UX fixes + horizontal card support 4 years ago
adobe-bot
LFDanLu LFDanLu changed the title CardView grid layout UX fixes + horizontal card support (WIP) CardView grid layout UX fixes + horizontal card support 4 years ago
LFDanLu
LFDanLu cleanup
16d65331
LFDanLu
LFDanLu commented on 2021-10-22
LFDanLu adding test for horizontal cards in cardview
7fb0ce62
LFDanLu LFDanLu changed the title (WIP) CardView grid layout UX fixes + horizontal card support CardView grid layout UX fixes + horizontal card support 4 years ago
LFDanLu Merge branch 'main' into issue_2285
e071a63d
adobe-bot
adobe-bot
snowystinger
snowystinger commented on 2021-10-24
snowystinger
snowystinger commented on 2021-10-24
LFDanLu only calling isVisible in GridLayout if layoutInfo is available
d7064d96
adobe-bot
LFDanLu Merge branch 'main' into issue_2285
2232ccb4
adobe-bot
LFDanLu updating quiet vertical cards in grid cardview so that text content i…
cbffeedd
LFDanLu fixing horizontal card image aspect ratio resizing
183314f1
LFDanLu
LFDanLu commented on 2021-11-01
LFDanLu
LFDanLu commented on 2021-11-01
adobe-bot
snowystinger
snowystinger commented on 2021-11-03
LFDanLu removing !important styles for cardview and moving them to layoutInfo
573a2af4
adobe-bot
LFDanLu
LFDanLu commented on 2021-11-05
snowystinger snowystinger added needs API review
snowystinger
snowystinger commented on 2021-11-05
LFDanLu
LFDanLu fixing shift tab behavior
518463f1
adobe-bot
LFDanLu adding offset to scrollToView for cardview so that focus rings are no…
cd39c963
LFDanLu updating scrollToItem in CardView to use margin from layout
b3d813d7
LFDanLu
LFDanLu commented on 2021-11-06
adobe-bot
LFDanLu removing some design specific TODOs and moving into issues
fe668374
LFDanLu
LFDanLu commented on 2021-11-08
adobe-bot
snowystinger
snowystinger commented on 2021-11-08
LFDanLu removing another TODO
b981c800
adobe-bot
devongovett devongovett assigned devongovett devongovett 4 years ago
devongovett devongovett assigned dannify dannify 4 years ago
LFDanLu
LFDanLu commented on 2021-11-08
LFDanLu updating type description for gridlayout
d1460734
adobe-bot
snowystinger
snowystinger dismissed these changes on 2021-11-12
LFDanLu Merge branch 'main' into issue_2285
a5b5464b
adobe-bot
adobe-bot
devongovett
devongovett commented on 2021-11-16
LFDanLu addressing review comments
bcff0163
LFDanLu LFDanLu dismissed their stale review via bcff0163 4 years ago
adobe-bot
devongovett
devongovett approved these changes on 2021-11-17
dannify Merge branch 'main' into issue_2285
35678425
dannify
dannify approved these changes on 2021-11-18
adobe-bot
LFDanLu LFDanLu merged 5716435e into main 4 years ago
LFDanLu LFDanLu deleted the issue_2285 branch 4 years ago

Login to write a write a comment.

Login via GitHub

Assignees
Labels
Milestone