PR #2521 iOS VO selection improvements

iOS VO selection improvements #2521

dannify merged 42 commits into main from ios-selection-mode-improvements

iOS VO selection improvements

62f8935f

snowystinger requested a review from

dannify 3 years ago

snowystinger requested a review from

devongovett 3 years ago

remove dead code

fe75f530

remove more dead code

904e95a6

fix imports

d3e145e6

fix ts

9bc421c0

Only announce if NOT after keyboard navigation

17bf084b

Better comment

82b43c80

snowystinger changed the title ~~[WIP] - iOS VO selection improvements~~ iOS VO selection improvements 3 years ago

snowystinger commented on 2021-11-11

Merge branch 'main' into ios-selection-mode-improvements

5b2b3153

Add keyboard information, add some new strings

cc1858e8

don't break the tests

ba6b35ed

Merge branch 'main' into ios-selection-mode-improvements

1759886b

devongovett requested changes on 2021-11-29

review comments and tests

fc9dd5ee

ktabors commented on 2021-11-30

Merge branch 'main' into ios-selection-mode-improvements

0c471309

fixed tests

5d321038

Update from code review

9f319a31

Merge branch 'main' into ios-selection-mode-improvements

642b7185

fix lint and tests

80a8bea5

devongovett commented on 2021-12-01

Have our announcer handle everything

79ab915e

handle select all cases as well

d76d73d4

devongovett commented on 2021-12-01

devongovett requested a review from

majornista 3 years ago

cleanup and add a test that tries row based onAction

381c1804

get test working with no onAction to useTable

4128dd99

fix lint

09b01926

for real fix lint

f4a230b4

now fix ts

50c73eef

add an odd story that shows some difficulties with onAction

b6cd4545

uses onrow/cellaction on grid state

ebd8171e

remove dead comment

45380bd8

move long press announcement to useGrid and test

72a1ce58

move out to selection, simplify if expressions

283b5a8c

remove unused strings

5a46db35

cleanup

529a326b

push listbox example for consideration

92cc9383

fix lint

59010203

Backwards compat with onAction

991256be

cleanup and doc comments

f7252ada

add deprecated notices

f43d6f2d

majornista commented on 2021-12-03

Move new actions to weak map

85fadc83

snowystinger commented on 2021-12-04

Cleanup

4f361af4

dannify added needs API review

devongovett commented on 2021-12-09

devongovett changed the base branch from main to release 3 years ago

Merge branch 'release' into ios-selection-mode-improvements

9458f832

review followup, move description back to grid for now

d5a8ba13

LFDanLu commented on 2021-12-13

handle if a VO user hasn't interacted with the application

6d9593dc

devongovett dismissed these changes on 2021-12-14

devongovett changed the base branch from release to main 3 years ago

devongovett dismissed their stale review 3 years ago

The base branch was changed.

Merge branch 'main' into ios-selection-mode-improvements

c3c9002e

devongovett approved these changes on 2021-12-14

dannify approved these changes on 2021-12-14

dannify merged 5e55d7a3 into main 3 years ago

dannify deleted the ios-selection-mode-improvements branch 3 years ago

Reviewers

dannify

devongovett

LFDanLu

majornista

ktabors

Assignees

No one assigned

Labels

needs API review

Milestone

No milestone

react-spectrum iOS VO selection improvements #2521 Merged

iOS VO selection improvements #2521

react-spectrum
iOS VO selection improvements
#2521

Merged