ListView: Draggable Rows #2593
devongovett
merged
83 commits into
main
from
ListView-DnD
initial setup
80e88630
updating ListView types and improving defaults for drag state
fc598018
adding ListView drag story and supporting individual row drag disabling
27ad57f7
fixing ListViewItem outdated selection maanger
617145dc
fixing disabling individual rows in drag and drop
772ac53f
add drag handle UI
c08a0dc7
cleanup formatting
138247c6
fix list item padding
0da64d97
improve drag handle focus ring
bded88c8
initial render preview styles
a62be4d6
improve render preview styles
80a689a5
fix render preview border radius
8d7a067b
fix logic to show handle
92f7a956
add support for custom dragIcon
c584521e
fix lint
1c117feb
only drop draggable items if multiple selected
d1044cb5
fix drag handle styles
9d1e854b
add border radius to drag handle
76907f4a
add isDraggable to item type
008cfc30
skip failing draggable tests for now
a45f3400
Merge branch 'main' into ListView-DnD
2f630e1f
devongovett
commented
on 2021-11-29
prevent selection when clicking draggable row
d63382a1
updates from design review
fef5ffec
LFDanLu
commented
on 2021-12-02
Merge branch 'main' of github.com:adobe/react-spectrum into ListView-DnD
8ac5a97b
removing skips from useDraggableCollection tests
54ba449a
adding tests for dnd listview
6b69aad0
removing stray comment
02cc4c1f
adding test to check for drag preview
c156684c
LFDanLu
commented
on 2021-12-02
improve default render preview
40579288
Merge branch 'ListView-DnD' of github.com:adobe/react-spectrum into L…
72e1d9b0
fixing lint and tests
586538ea
fix render preview padding
7b45217e
Merge branch 'ListView-DnD' of github.com:adobe/react-spectrum into L…
ed652c2e
adding aria-label to render preview checkbox
8126c229
LFDanLu
commented
on 2021-12-03
Merge branch 'main' into ListView-DnD
5f3c7595
keep incoming onAction change
185e2724
Merge branch 'main' into ListView-DnD
973ca327
Merge branch 'ListView-DnD' of github.com:adobe/react-spectrum into L…
484246a7
tentative fix to stop row selection on drag start
7122c7bf
Merge branch 'main' of github.com:adobe/react-spectrum into ListView-DnD
59ec5a57
fixing lint and adding tests for checkbox/menu clicks
0abadce4
fixing usePress tests
a3b416ea
adding allowsDifferentPressOrigin to useSelectableItem
c3f3995b
fixing lint
7e282769
Merge branch 'main' into ListView-DnD
7e3abda5
Merge branch 'main' into ListView-DnD
6eaf9325
add useDragHooks
e4a21130
fix test setup
41e11308
reidbarber
commented
on 2022-02-03
reidbarber
commented
on 2022-02-03
Merge branch 'main' into ListView-DnD
905b0a33
Merge branch 'main' of github.com:adobe/react-spectrum into ListView-DnD
2e38865f
adding code comment and small cleanup
641384c9
fix warning for changes hooks provided
cb24f676
add default itemAllowsDragging
f96277d1
add default getItems
81efd9bb
remove extra checkbox hit area for drag handle
a7743284
fix lint
052515f8
LFDanLu
commented
on 2022-02-24
addressing some review comments
97dc2a8f
LFDanLu
commented
on 2022-02-24
updating tests and hiding drag handle via display: none
6ec8e774
making drag handle use visually hidden styles for screen readers
951fe6e8
LFDanLu
commented
on 2022-02-24
fixing weird safari drag handle positioning
7d16e8a9
removing fallback
822dd2a1
move defaults to useDraggableCollectionState
a9a9a22d
Merge branch 'main' of github.com:adobe/react-spectrum into ListView-DnD
a9ed0831
optimize drag handle svg
a69fb514
fix the changing hooks warning logic
1b23709a
change itemAllowsDragging to allowsDraggingItem
c36c3af2
add useDraggableItem to dragHooks
cecae006
make getItems required and remove default
e560660b
make getItems required on DragOptions
bcd0183c
fix getItems type required
ff9c6e7b
add @react-spectrum/dnd package with useDragHooks
9dcd7091
fix import for draghooks
18bce37a
remove old comments
2a914325
remove private: true from package.json
8da02437
fix circular dep
706debd3
fix react-aria/dnd dep in listview
4438f2b4
Revert "fix react-aria/dnd dep in listview"
e9c75960
devongovett
commented
on 2022-02-26
fix DragHooks type
59d2b11f
Merge branch 'main' into ListView-DnD
75967d23
Merge branch 'ListView-DnD' of github.com:adobe/react-spectrum into L…
de099f28
making aria/stately dnd packages dev deps for list
d36779c3
devongovett
commented
on 2022-02-28
devongovett
dismissed these changes
on 2022-02-28
make getItems required
ec9f91fa
fix type of dragHooks props
99a6ff07
snowystinger
approved these changes
on 2022-02-28
Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Login to write a write a comment.
Login via GitHub