react-spectrum
Move aria specific props to AriaComboBoxProps
#2651
Merged

Move aria specific props to AriaComboBoxProps #2651

frdclav
frdclav #2624: moves aria specific props to AriaComboBoxProps, extends in Spe…
41a57f0c
frdclav Merge branch 'main' into issue-2624-move-aria-combobox-props
00049c31
snowystinger
snowystinger commented on 2021-12-07
frdclav frdclav changed the title #2624: moves aria specific props to AriaComboBoxProps, extends in Spe… [WIP] #2624: moves aria specific props to AriaComboBoxProps, extends in Spe… 4 years ago
frdclav #2624: addresses comments and makes needed changes, moves AriaComboBo…
92c82fc7
snowystinger
snowystinger commented on 2021-12-07
frdclav #2624: moves ref props back to hook, leave menuTrigger in comboBoxProps
db25e9f2
frdclav Merge branch 'issue-2624-move-aria-combobox-props' of https://github.…
1cefb30a
frdclav #2624: add back ref props into aria hook
5d60d801
frdclav #2624: remove ref props from types, fix spacing
375fa00f
frdclav #2624: fix more spacing
a1bc234d
frdclav #2624: fix more spacing
a00a4428
frdclav
frdclav commented on 2021-12-08
frdclav frdclav changed the title [WIP] #2624: moves aria specific props to AriaComboBoxProps, extends in Spe… Move aria specific props to AriaComboBoxProps 4 years ago
frdclav frdclav marked this pull request as ready for review 4 years ago
frdclav frdclav requested a review from dannify dannify 4 years ago
frdclav frdclav requested a review from devongovett devongovett 4 years ago
LFDanLu
LFDanLu requested changes on 2021-12-09
frdclav update useComboBox.ts to use AriaComboBoxOptions instead of alias
ad63c155
frdclav remove DOMprops from ComboBoxProps
9d5a284c
devongovett
devongovett approved these changes on 2021-12-10
dannify
dannify approved these changes on 2021-12-10
devongovett devongovett merged 8d631f55 into main 4 years ago

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone