Landmarks #2750
devongovett
merged
75 commits into
main
from
landmarks
Get landmark navigation work started
98d5f292
Fix up everything to get a build
c7aa6317
remove landmark docs for now
f5375565
Merge branch 'main' into landmarks
632d68ef
snowystinger
commented
on 2022-01-18
snowystinger
commented
on 2022-01-18
snowystinger
commented
on 2022-01-18
add warning for reusing role with no labels
b5111a5e
add stories for reusing roles
996f590f
fix jsdoc for useLandmark
93a84887
fix label check
b8caca71
add test for duplicate roles
7f6fe023
reidbarber
commented
on 2022-01-20
snowystinger
commented
on 2022-01-21
optimize closestLandmark to be linear
b2978a86
move duplicate landmark check to hook
6c3ad797
refactor landmarks to be ordered list
30d4b5b8
snowystinger
commented
on 2022-01-28
update addLandmark signature
53e2069c
add functions to update landmark and check labels
81737ddb
add test for landmarks with same role and label
0443193e
handle F6 case of no landmarks
f341d9e4
reidbarber
commented
on 2022-01-28
restore skipped tests
08839faa
fix logic for focusing next element
08aafe63
add test for one landmark
4b2d8d72
fix tests
ace27d21
handle landmarks with no focusable children
6b7dc6cf
add tests for landmarks with no focusble chlidren
992aa683
add stories for landmarks w/ no focusable children
0fac0754
add labels to stories for easier testing
260bf177
add story for duplicate roles and same label
027be78d
Merge branch 'main' into landmarks
3ef760ba
update descriptions
de62bd1c
add AriaLandmarkRole type
a8c79daf
fix lint
1e0e203b
update description
61238d8e
reidbarber
commented
on 2022-01-31
reidbarber
commented
on 2022-01-31
majornista
requested changes
on 2022-01-31
fix search in story
a3024336
snowystinger
commented
on 2022-01-31
update dependencies in package.json
bdaf436d
fix updateLandmark to update by ref
708abd10
majornista
commented
on 2022-02-01
majornista
commented
on 2022-02-01
fix warning spies
7e271481
only update on focusIn if inside landmark
c1a06722
add test case for removing landmark
bc8257b5
add test for adding landmarks during navigation
9a9780cc
snowystinger
commented
on 2022-02-01
fix test for removing from document
eddfd23e
handle case of adding landmark around existing one
59c98036
snowystinger
commented
on 2022-02-02
optimize addLandmark
6532712d
fix addLandmark
8be1a3ca
add tests for adding nested landmarks
39494fef
snowystinger
commented
on 2022-02-02
update to focus landmarks elements first
c2d96473
update tests to handle focusing landmarks first
a7c51339
Merge branch 'main' into landmarks
bbba51c0
fix tests with rerenders
82304d8c
mock height and width for test with table
1f6b8e96
only return role and tabIndex, not all props
7d883cfb
fix lint
eeca214b
setup event listeners after initialization, once
dda6c0db
fix lint
0fb06e2a
fix lint
e940ae9c
Remove mock for raf because modern timers will do it if we run timers…
0acf8b40
snowystinger
commented
on 2022-02-08
Merge branch 'main' into landmarks
551f44d4
majornista
dismissed these changes
on 2022-02-18
focus main if alt key pressed
15f81687
add test for alt key
92a1a1d9
add aria-label to landmark story examples
e0b06242
move alt key check after no landmark check
0b72153f
add tabIndex: -1 on F6, remove on blur
ed914635
remove default tabIndex
810d1edc
add tests for tabIndex additions
648ed78b
Merge branch 'main' into landmarks
4c6b32d4
LFDanLu
commented
on 2022-02-22
additional tests for alt+F6 cases
7aefb6b7
Landmarks: custom event for focus (#2878)
47ef1555
Merge branch 'landmarks' of github.com:adobe/react-spectrum into land…
1caf2f2a
fix lint
c288035f
fix main check in alt key handler
8d2f470e
Merge branch 'main' into landmarks
5c506ba5
add test for losing tabIndex=-1 on blur
dedc05b4
Merge branch 'main' into landmarks
5ed0f571
LFDanLu
commented
on 2022-02-25
LFDanLu
dismissed these changes
on 2022-02-28
Merge branch 'main' into landmarks
8cdfff49
rename focus/blur methods
caf6d014
improve getLandmarkByRole
fd7bcf14
formatting
f77be592
fix blur method call
d3db633d
devongovett
approved these changes
on 2022-02-28
Login to write a write a comment.
Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone