react-spectrum
ListView UI bug fixes and updates
#2804
Merged
Go
Login via GitHub
Home
Pricing
FAQ
Install
Login
via GitHub
Overview
Commits
55
Changes
View On
GitHub
ListView UI bug fixes and updates
#2804
dannify
merged 55 commits into
main
from
issue_2611
making quiet listviews not have rounded corners and borders between rows
1d49a64e
matching active/hover state for ListView selected row with TableView
4420acc8
adding user-select: none to listview
8fdfef92
adding left border and background opacity to listview focused row
72b674bd
LFDanLu
requested a review
from
dannify
3 years ago
LFDanLu
requested a review
from
devongovett
3 years ago
LFDanLu
requested a review
from
snowystinger
3 years ago
updating tableview highlight selction selected row left and right bor…
7ee30d18
fixing top/bottom border for first and last row in highlight table
4512b884
moving left indicator to a :before of the ListView row div
cf41f67d
fixing lint
9a2d3f7a
removing extraneous border
d172d781
hiding bottom border of last row to avoid overlap with container border
06f93e68
making the focus ring indicator sticky for TableView and ListView
2011fae9
LFDanLu
commented on 2022-02-10
removing extraneous focus ring indicator
17670899
fixing borders to remove wiggles
5c6ea858
LFDanLu
commented on 2022-02-14
LFDanLu
commented on 2022-02-14
LFDanLu
commented on 2022-02-14
fix lint
24af3c65
LFDanLu
changed the title
(WIP) ListView UI bug fixes and updates
ListView UI bug fixes and updates
3 years ago
Merge branch 'main' into issue_2611
d5e4a94b
reidbarber
commented on 2022-02-15
Merge branch 'main' of github.com:adobe/react-spectrum into issue_2611
9b63316a
adding pointer-events none to :after box shadow
eebb2b52
LFDanLu
force pushed
from
bfd8c699
to
eebb2b52
3 years ago
reidbarber
commented on 2022-02-15
reidbarber
commented on 2022-02-15
reidbarber
commented on 2022-02-15
addressing review comments
2aab429e
reidbarber
dismissed these changes on 2022-02-16
Merge branch 'main' into issue_2611
70a4fc7c
Merge branch 'main' into issue_2611
c0725e8d
Merge branch 'main' of github.com:adobe/react-spectrum into issue_2611
cc7a8366
fix firefox and safari table checkbox positioning when row focus is v…
a344906c
replacing border-top for table highlight selection first row with box…
ac3c4cbd
LFDanLu
dismissed their stale review via
ac3c4cbd
3 years ago
removing extra space
db508279
LFDanLu
commented on 2022-03-01
Merge branch 'main' into issue_2611
cfdc2d42
LFDanLu
added
rsp:ListView
LFDanLu
added
rsp:TableView
reidbarber
dismissed these changes on 2022-03-01
Merge branch 'main' into issue_2611
594013a9
Merge branch 'main' into issue_2611
eb50f41b
making last row only have rounded corners if we are not loading more …
e42de7b1
LFDanLu
dismissed their stale review via
e42de7b1
3 years ago
ktabors
requested changes on 2022-03-11
fix sticky focus ring rtl
4bebdf25
removing transition from listview to match tableview
4252b28a
adding blue outline for selected tableview row and replacing bottom b…
509e0055
simplifying the box-shadow tableview css
fc1b79ca
update listview css to use box shadows instead of border
3e914dca
fixing vertical padding and horizontal padding for dnd
e73c49df
fixing z-index for left focus indicator
83505c1b
making tableview follow the same .5px box shadow like listview
5fba7631
Merge branch 'main' into issue_2611
d684ffcd
fixing listview first and last row styles
112276b6
Revert "making tableview follow the same .5px box shadow like listview"
6901cf72
removing todo comment
0c72b907
LFDanLu
commented on 2022-03-15
reidbarber
dismissed these changes on 2022-03-17
ktabors
dismissed these changes on 2022-03-21
Merge branch 'main' of github.com:adobe/react-spectrum into issue_2611
17737474
LFDanLu
dismissed their stale review via
17737474
3 years ago
LFDanLu
dismissed their stale review via
17737474
3 years ago
reidbarber
commented on 2022-04-01
applying tableview style updates to deprecated tableview too
3144468b
Merge branch 'main' into issue_2611
2eaa09c1
Merge branch 'main' into issue_2611
079512a5
reidbarber
dismissed these changes on 2022-04-05
Merge branch 'main' into issue_2611
d2940ec9
Merge branch 'main' into issue_2611
ee97f27f
making rounded corners only happen if table/list content is greater o…
69997814
LFDanLu
dismissed their stale review via
69997814
3 years ago
LFDanLu
commented on 2022-04-08
ktabors
dismissed these changes on 2022-04-08
fixing border radius for first/last row TableView
b776da44
going back to -1px bottom border strategy instead of .5px for ListView
5ed63b59
removing lastRow bottom border for listview if content is equal or gr…
276c2821
LFDanLu
dismissed their stale review via
276c2821
3 years ago
LFDanLu
commented on 2022-04-08
LFDanLu
commented on 2022-04-08
snowystinger
commented on 2022-04-12
Merge branch 'main' into issue_2611
718ba65a
Merge branch 'main' of github.com:adobe/react-spectrum into issue_2611
458ecf6f
removing contain: paint since overflow styles should handle that for us
2c0e8b14
LFDanLu
commented on 2022-04-18
snowystinger
approved these changes on 2022-04-18
devongovett
approved these changes on 2022-04-22
Merge branch 'main' into issue_2611
11770b66
LFDanLu
added
needs testing
Merge branch 'main' into issue_2611
f9c60818
dannify
merged
35d3d637
into main
3 years ago
dannify
deleted the issue_2611 branch
3 years ago
dannify
removed
needs testing
dannify
added
release
dannify
removed
release
Login to write a write a comment.
Login via GitHub
Reviewers
devongovett
snowystinger
ktabors
reidbarber
dannify
Assignees
No one assigned
Labels
rsp:TableView
rsp:ListView
Milestone
No milestone
Login to write a write a comment.
Login via GitHub