react-spectrum
ListView UI bug fixes and updates
#2804
Merged

ListView UI bug fixes and updates #2804

dannify merged 55 commits into main from issue_2611
LFDanLu
LFDanLu making quiet listviews not have rounded corners and borders between rows
1d49a64e
LFDanLu matching active/hover state for ListView selected row with TableView
4420acc8
LFDanLu adding user-select: none to listview
8fdfef92
LFDanLu adding left border and background opacity to listview focused row
72b674bd
LFDanLu LFDanLu requested a review from dannify dannify 3 years ago
LFDanLu LFDanLu requested a review from devongovett devongovett 3 years ago
LFDanLu LFDanLu requested a review from snowystinger snowystinger 3 years ago
adobe-bot
LFDanLu updating tableview highlight selction selected row left and right bor…
7ee30d18
adobe-bot
LFDanLu
LFDanLu fixing top/bottom border for first and last row in highlight table
4512b884
adobe-bot
LFDanLu moving left indicator to a :before of the ListView row div
cf41f67d
LFDanLu fixing lint
9a2d3f7a
adobe-bot
LFDanLu removing extraneous border
d172d781
adobe-bot
LFDanLu hiding bottom border of last row to avoid overlap with container border
06f93e68
adobe-bot
LFDanLu making the focus ring indicator sticky for TableView and ListView
2011fae9
adobe-bot
LFDanLu
LFDanLu commented on 2022-02-10
LFDanLu removing extraneous focus ring indicator
17670899
adobe-bot
LFDanLu fixing borders to remove wiggles
5c6ea858
LFDanLu
LFDanLu commented on 2022-02-14
LFDanLu
LFDanLu commented on 2022-02-14
LFDanLu
LFDanLu commented on 2022-02-14
LFDanLu fix lint
24af3c65
adobe-bot
LFDanLu LFDanLu changed the title (WIP) ListView UI bug fixes and updates ListView UI bug fixes and updates 3 years ago
LFDanLu Merge branch 'main' into issue_2611
d5e4a94b
LFDanLu
adobe-bot
reidbarber
reidbarber commented on 2022-02-15
LFDanLu
LFDanLu Merge branch 'main' of github.com:adobe/react-spectrum into issue_2611
9b63316a
LFDanLu adding pointer-events none to :after box shadow
eebb2b52
LFDanLu LFDanLu force pushed from bfd8c699 to eebb2b52 3 years ago
adobe-bot
reidbarber
reidbarber commented on 2022-02-15
reidbarber
reidbarber commented on 2022-02-15
reidbarber
reidbarber commented on 2022-02-15
LFDanLu addressing review comments
2aab429e
adobe-bot
reidbarber
reidbarber dismissed these changes on 2022-02-16
LFDanLu Merge branch 'main' into issue_2611
70a4fc7c
adobe-bot
LFDanLu Merge branch 'main' into issue_2611
c0725e8d
adobe-bot
devongovett
LFDanLu
LFDanLu Merge branch 'main' of github.com:adobe/react-spectrum into issue_2611
cc7a8366
LFDanLu fix firefox and safari table checkbox positioning when row focus is v…
a344906c
LFDanLu replacing border-top for table highlight selection first row with box…
ac3c4cbd
LFDanLu LFDanLu dismissed their stale review via ac3c4cbd 3 years ago
LFDanLu removing extra space
db508279
LFDanLu
LFDanLu commented on 2022-03-01
adobe-bot
adobe-bot
LFDanLu Merge branch 'main' into issue_2611
cfdc2d42
adobe-bot
LFDanLu LFDanLu added rsp:ListView
LFDanLu LFDanLu added rsp:TableView
reidbarber
reidbarber dismissed these changes on 2022-03-01
LFDanLu Merge branch 'main' into issue_2611
594013a9
adobe-bot
LFDanLu Merge branch 'main' into issue_2611
eb50f41b
adobe-bot
LFDanLu making last row only have rounded corners if we are not loading more …
e42de7b1
LFDanLu LFDanLu dismissed their stale review via e42de7b1 3 years ago
adobe-bot
ktabors
ktabors requested changes on 2022-03-11
LFDanLu fix sticky focus ring rtl
4bebdf25
LFDanLu
adobe-bot
devongovett
reidbarber
LFDanLu removing transition from listview to match tableview
4252b28a
LFDanLu
LFDanLu adding blue outline for selected tableview row and replacing bottom b…
509e0055
LFDanLu simplifying the box-shadow tableview css
fc1b79ca
LFDanLu update listview css to use box shadows instead of border
3e914dca
LFDanLu fixing vertical padding and horizontal padding for dnd
e73c49df
LFDanLu fixing z-index for left focus indicator
83505c1b
LFDanLu making tableview follow the same .5px box shadow like listview
5fba7631
adobe-bot
LFDanLu Merge branch 'main' into issue_2611
d684ffcd
adobe-bot
LFDanLu fixing listview first and last row styles
112276b6
LFDanLu Revert "making tableview follow the same .5px box shadow like listview"
6901cf72
adobe-bot
LFDanLu removing todo comment
0c72b907
adobe-bot
LFDanLu
LFDanLu commented on 2022-03-15
reidbarber
reidbarber dismissed these changes on 2022-03-17
ktabors
ktabors dismissed these changes on 2022-03-21
LFDanLu Merge branch 'main' of github.com:adobe/react-spectrum into issue_2611
17737474
LFDanLu LFDanLu dismissed their stale review via 17737474 3 years ago
LFDanLu LFDanLu dismissed their stale review via 17737474 3 years ago
adobe-bot
reidbarber
reidbarber commented on 2022-04-01
LFDanLu
LFDanLu applying tableview style updates to deprecated tableview too
3144468b
LFDanLu Merge branch 'main' into issue_2611
2eaa09c1
adobe-bot
adobe-bot
LFDanLu Merge branch 'main' into issue_2611
079512a5
adobe-bot
reidbarber
reidbarber dismissed these changes on 2022-04-05
LFDanLu Merge branch 'main' into issue_2611
d2940ec9
adobe-bot
LFDanLu Merge branch 'main' into issue_2611
ee97f27f
adobe-bot
LFDanLu making rounded corners only happen if table/list content is greater o…
69997814
LFDanLu LFDanLu dismissed their stale review via 69997814 3 years ago
adobe-bot
LFDanLu
LFDanLu commented on 2022-04-08
ktabors
ktabors dismissed these changes on 2022-04-08
snowystinger
LFDanLu fixing border radius for first/last row TableView
b776da44
LFDanLu going back to -1px bottom border strategy instead of .5px for ListView
5ed63b59
LFDanLu removing lastRow bottom border for listview if content is equal or gr…
276c2821
LFDanLu LFDanLu dismissed their stale review via 276c2821 3 years ago
LFDanLu
LFDanLu commented on 2022-04-08
adobe-bot
LFDanLu
LFDanLu commented on 2022-04-08
LFDanLu
snowystinger
snowystinger
snowystinger commented on 2022-04-12
LFDanLu Merge branch 'main' into issue_2611
718ba65a
LFDanLu
adobe-bot
LFDanLu
LFDanLu
LFDanLu
LFDanLu Merge branch 'main' of github.com:adobe/react-spectrum into issue_2611
458ecf6f
LFDanLu removing contain: paint since overflow styles should handle that for us
2c0e8b14
LFDanLu
LFDanLu commented on 2022-04-18
adobe-bot
snowystinger
snowystinger approved these changes on 2022-04-18
devongovett
devongovett approved these changes on 2022-04-22
LFDanLu Merge branch 'main' into issue_2611
11770b66
LFDanLu LFDanLu added needs testing
adobe-bot
dannify Merge branch 'main' into issue_2611
f9c60818
adobe-bot
dannify dannify merged 35d3d637 into main 3 years ago
dannify dannify deleted the issue_2611 branch 3 years ago
dannify dannify removed needs testing
dannify dannify added release
dannify dannify removed release

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone