react-spectrum
Updating selected Tab tabIndex when selection is changed programatically and the collection isn't focused
#2829
Merged

Updating selected Tab tabIndex when selection is changed programatically and the collection isn't focused #2829

LFDanLu merged 17 commits into main from issue_2807
LFDanLu
LFDanLu fixing updating focused key for Tabs if selected tab is programatical…
c3600afb
LFDanLu fixing tests
fdc8a84b
LFDanLu adding tests and story for programatic tabs selection changing
937b5120
LFDanLu
LFDanLu commented on 2022-02-10
snowystinger
snowystinger commented on 2022-02-10
LFDanLu addressing review comments
9e7f1194
adobe-bot
snowystinger
snowystinger commented on 2022-02-10
snowystinger
snowystinger commented on 2022-02-10
LFDanLu addressing more review comments
7a11a2ff
adobe-bot
snowystinger
snowystinger dismissed these changes on 2022-02-10
LFDanLu LFDanLu marked this pull request as ready for review 4 years ago
LFDanLu LFDanLu requested a review from dannify dannify 4 years ago
LFDanLu LFDanLu requested a review from devongovett devongovett 4 years ago
LFDanLu Merge branch 'main' into issue_2807
d25035bb
adobe-bot
devongovett
devongovett commented on 2022-02-11
LFDanLu removing useEffect and fixing setState in render warning
41d8878d
LFDanLu LFDanLu dismissed their stale review via 41d8878d 4 years ago
LFDanLu fixing lint
319bb243
adobe-bot
LFDanLu moving focused key update logic to useMultipleSelectionState
89c030b2
LFDanLu
LFDanLu commented on 2022-02-18
LFDanLu
LFDanLu commented on 2022-02-18
LFDanLu
LFDanLu commented on 2022-02-18
LFDanLu
LFDanLu commented on 2022-02-18
LFDanLu fixing lint and removing sidenav test change
10a1a4f8
adobe-bot
snowystinger
snowystinger commented on 2022-02-22
LFDanLu addressing review comments
225fa583
LFDanLu fixing lint
b37f995c
adobe-bot
snowystinger
snowystinger dismissed these changes on 2022-02-23
LFDanLu LFDanLu assigned devongovett devongovett 4 years ago
LFDanLu making only tablist update focused key when selected key changes
f5371010
LFDanLu LFDanLu dismissed their stale review via f5371010 4 years ago
adobe-bot
LFDanLu simplifying logic by getting rid of the useEffect
d5d9b87c
LFDanLu fixing lint
93c2dcf9
adobe-bot
LFDanLu
LFDanLu commented on 2022-02-25
LFDanLu Merge branch 'main' into issue_2807
c1bf3027
adobe-bot
snowystinger
snowystinger approved these changes on 2022-02-25
devongovett
devongovett approved these changes on 2022-02-28
snowystinger Merge branch 'main' into issue_2807
6ca87fb8
adobe-bot
LFDanLu LFDanLu merged 1aa9e9a3 into main 4 years ago
LFDanLu LFDanLu deleted the issue_2807 branch 4 years ago
LFDanLu LFDanLu added needs testing
dannify dannify added release
dannify dannify removed needs testing
dannify dannify removed release

Login to write a write a comment.

Login via GitHub

Assignees
Labels
Milestone