react-spectrum
Fix TableView rendering of rows with ids of 0
#2840
Merged
Overview
Commits
12
Changes
View On GitHub

Fix TableView rendering of rows with ids of 0 #2840

LFDanLu merged 12 commits into main from fix_table_keyboard_null_check
LFDanLu
LFDanLu fixing key checks so they are proper null checks
af00ada0
LFDanLu adding story to test falsy row keys
a7df362c
LFDanLu LFDanLu requested a review from snowystinger snowystinger 4 years ago
LFDanLu LFDanLu requested a review from dannify dannify 4 years ago
LFDanLu LFDanLu requested a review from devongovett devongovett 4 years ago
LFDanLu
LFDanLu commented on 2022-02-11
adobe-bot
snowystinger
snowystinger commented on 2022-02-11
snowystinger
snowystinger dismissed these changes on 2022-02-11
dannify Merge branch 'main' into fix_table_keyboard_null_check
d8dea55c
adobe-bot
LFDanLu adding falsy key stories for other components
78d37946
LFDanLu LFDanLu dismissed their stale review via 78d37946 4 years ago
adobe-bot
LFDanLu adding todo and removing empty string key from stories
1b37642d
LFDanLu LFDanLu changed the title Fix TableKeyboardDelegate `key` null checks and rendering of rows with falsy ids (WIP) Fix TableKeyboardDelegate `key` null checks and rendering of rows with falsy ids 4 years ago
adobe-bot
dannify Merge branch 'main' into fix_table_keyboard_null_check
a7be115a
adobe-bot
LFDanLu LFDanLu changed the title (WIP) Fix TableKeyboardDelegate `key` null checks and rendering of rows with falsy ids (WIP) Fix TableView rendering of rows with ids of 0 4 years ago
LFDanLu adding tableview and listbox test
49c207a2
adobe-bot
LFDanLu adding falsy id stories for CardView and ListView test
cdde17fa
adobe-bot
LFDanLu adding cardview test for falsy ids
a47ed9b9
LFDanLu LFDanLu changed the title (WIP) Fix TableView rendering of rows with ids of 0 Fix TableView rendering of rows with ids of 0 4 years ago
LFDanLu
LFDanLu commented on 2022-02-16
LFDanLu
LFDanLu commented on 2022-02-16
LFDanLu Merge branch 'main' into fix_table_keyboard_null_check
31b8fd9c
adobe-bot
adobe-bot
LFDanLu Merge branch 'main' into fix_table_keyboard_null_check
19642c99
adobe-bot
snowystinger
snowystinger approved these changes on 2022-02-22
reidbarber
reidbarber approved these changes on 2022-02-23
LFDanLu Merge branch 'main' into fix_table_keyboard_null_check
8a8b866c
adobe-bot
LFDanLu LFDanLu merged cae83ff9 into main 4 years ago
LFDanLu LFDanLu deleted the fix_table_keyboard_null_check branch 4 years ago
LFDanLu LFDanLu added needs testing
dannify dannify removed needs testing
dannify dannify added release
dannify dannify removed release

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum