react-spectrum
Repositioning the popover and arrow position when the trigger is at the window edge
#2842
Merged
Overview
Commits
22
Changes
View On GitHub

Repositioning the popover and arrow position when the trigger is at the window edge #2842

ktabors merged 22 commits into main from popover_edge_position
ktabors
ktabors repositioning the popover and arrow position when at edge
5ea90b8d
ktabors adding some top and bottom margins for improved testing
fa45aa66
ktabors skipping some tests to get a build people can test
5675d8c4
ktabors skipping some tests to get a build people can test
a123e69d
adobe-bot
ktabors bug fix for tests
e7ee384f
adobe-bot
ktabors when positionned at the edge moving the positioning to the 6px from 50px
da6c9975
adobe-bot
ktabors adding tests specific to new positioning code dealing with edges
a82d7224
ktabors ktabors marked this pull request as ready for review 3 years ago
adobe-bot
majornista
reidbarber Merge branch 'main' into popover_edge_position
0bd45c4d
adobe-bot
majornista
majornista commented on 2022-04-05
ktabors Merge branch 'main' into popover_edge_position
bf5983b5
adobe-bot
snowystinger
snowystinger commented on 2022-04-14
ktabors
snowystinger
ktabors moving the popover arrow repositioning from calculate position to pop…
d1fa181c
ktabors Merge branch 'popover_edge_position' of github.com:adobe/react-spectr…
fb7c5152
adobe-bot
LFDanLu Merge branch 'main' into popover_edge_position
d9f9c3be
adobe-bot
LFDanLu
LFDanLu commented on 2022-06-25
LFDanLu
LFDanLu commented on 2022-06-25
ktabors setting a overlay padding const
0d2f14a3
ktabors Merge branch 'main' into popover_edge_position
ed71e74f
ktabors Merge branch 'popover_edge_position' of github.com:adobe/react-spectr…
4f894317
adobe-bot
adobe-bot
ktabors moving the popover closer to the trigger when there is no arrow
8d12a473
adobe-bot
snowystinger Merge branch 'main' into popover_edge_position
043ae34b
adobe-bot
LFDanLu Merge branch 'main' into popover_edge_position
1e150e9f
adobe-bot
LFDanLu
LFDanLu dismissed these changes on 2022-07-12
reidbarber
reidbarber dismissed these changes on 2022-07-29
ktabors Merge branch 'main' into popover_edge_position
c3ad4f68
ktabors fixing an import error
00beade2
ktabors ktabors dismissed their stale review via 00beade2 3 years ago
ktabors ktabors dismissed their stale review via 00beade2 3 years ago
adobe-bot
reidbarber
reidbarber approved these changes on 2022-08-02
LFDanLu Merge branch 'main' into popover_edge_position
30aaecab
LFDanLu
LFDanLu approved these changes on 2022-08-03
adobe-bot
sanyabas
sanyabas commented on 2022-08-03
ktabors Merge branch 'main' into popover_edge_position
4214a1e8
adobe-bot
ktabors ktabors merged b88d3670 into main 3 years ago
ktabors ktabors deleted the popover_edge_position branch 3 years ago
ktabors ktabors added needs testing
devongovett devongovett removed needs testing

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum