TableView Column resizing #2883
snowystinger
merged
137 commits into
adobe:main
from
marshallpete:columnResizing
initial work
a762c262
really hacky column resizing to prove flow
1d4e93d8
add resize algo
3a4645a6
resize any column, not just first
e8dda059
merging main
3851565a
column resize working
b5fcedc3
support allowsResizing prop
5c562b97
Fixed issue where mouse was not correctly tracking column sizing
28cd3ba3
use defaultWidth for uncontrolled resizeable columns
6146c8c4
clean up unused props and only calculate widths of affected columns
1499f75c
move the min/max check to TableLayout so that it will correctly suppo…
5ae06bd7
Add uncontrolled storybook stories
2237b916
Merge branch 'adobe:main' into columnResizing
de81e6da
WIP refactor flow proof
d9c5052b
begin adding the resize algo
8edb4491
get rid of race condition error on initialization. onResize still doe…
fa85efaf
calculate columns on resize
790c5d2b
fix typing
5d9a4766
Re-introduce sticky column indices (still part of layout but outside …
8b5b06da
add defaultWidth prop to useTableState
ff763275
fix column width getter for virtualizer
c8508eb9
remove unused code
bc380510
get virtualizer width in useTableState
ea8d7fcc
no need for useCallback
eb747365
useEffect to recalc columnWidths when columns changes
fff9177e
cleanup code
a5e071d8
check for null in case rendering when previous render hasn't finished…
6decb428
Set rounding to 2 decimal places, fix tests
ff58f692
Add new tests for edge cases (these tests would have failed before ou…
4521e09b
add onColumnResize prop
b713fff1
Throw error in certain prop conditions
2f2ec3dd
resizer styling
f0101271
add onColumnResizeEnd prop
0c501f4d
add types and fix resize bug
8fc42d13
fix resize bug with static columns to the right of the resize column
b1532992
Merge branch 'main' into columnResizing
133baf18
remove unnecessary console log
eef5cb0c
dnorth
commented
on 2022-02-23
dnorth
commented
on 2022-02-23
dnorth
commented
on 2022-02-23
dnorth
commented
on 2022-02-23
dnorth
commented
on 2022-02-23
cleanup unused TableLayout code
8a2408d9
remove unused code that was moved to useTableState
8f261996
Merge branch 'columnResizing' of https://github.com/marshallpete/reac…
ddff4091
dnorth
commented
on 2022-02-24
clean up most prettier changes and code comments
85a885a9
Merge branch 'columnResizing' of github.com:marshallpete/react-spectr…
f083e677
fix TableView prettier unintended changes
f45fcb7a
initial resize bug work
bfe6c4ce
merging
5b9fd90e
merging
a5854cec
fix TableView prettier unintended changes
b036393b
have a default width if no defaultWidth function is provided. That wa…
5735265f
fix horizontal scroll resize bug
4d8ae161
merging
8bcf5289
1fr if no getDefaultWidthProvided
f03035b2
fix TS
59aa98c7
make widths more robust and add console warn for wrong format
c8ac9c0e
fix linting problems
85f859b3
Merge branch 'main' into columnResizing
d14e8868
only add resize column if one of the columns is resizable
19d3aed2
Merge branch 'columnResizing' of https://github.com/marshallpete/reac…
d6438aba
remove console.log
92945098
Remove error when both width and defaultWidth are provided - (width w…
34b6e3aa
Round to whole pixel widths via floor. This will avoid strange half-p…
2c2d3a87
dnorth
commented
on 2022-03-01
useLayoutEffect for width changes. Initialize widths in-line
4ea86eb8
move useColumnResizeState static functions to utils file. Reorganize …
8240301e
add all dependencies, memoize callbacks
378e97a8
rename to useTableColumnResizeState for consistency with the react-ar…
9d220616
Merge branch 'main' into columnResizing
32f00dda
initial a11y work
d0f1f940
add prop to get focussing working
5813ef6a
Merge branch 'columnResizing' into columnResizing-a11y
2908a532
allowsResizing prop determines which code path to go down - old or ne…
8126f9af
escape to focus table header
7c516650
Merge branch 'columnResizing' into columnResizing-a11y
ca6e38c4
Fix feature-flagged tests and add jsdoc comment to exported component
bf24fd73
dnorth
commented
on 2022-03-07
dnorth
commented
on 2022-03-07
Add descriptions to TableStateProps
3e739747
somehow this fixes the doc build :cowboy:
74c6b1fb
Merge branch 'main' into columnResizing
ff53d5c4
increase resizer hitbox size
cc0bfcb6
highlight header text on hover if resizable column
d308046b
disable usePress if resizable
381e50fb
add menu for resize and sort accessibility
16f6f0b6
add sortable async resize example
40198c4b
add optional prop to specify which direction to sort
f7fd8ee5
partial fix for no layoutInfo bug on async tables
518a0e6c
merging columnResizing
376c9422
remove unneeded spaces
88f3c226
Add hiding columns allowsResize story, also make the public table lay…
9115326a
add aria attributes
79b1ccd2
Merge branch 'columnResizing' into columnResizing-a11y
b0596b14
add aria label
188b5362
change signature of useTableColumnResizeState because it's larger tha…
c26ebd8e
add minwidth to match style guide
20b851a1
Merge pull request #1 from marshallpete/columnResizing-a11y
25c89ac5
update useTableState to remove all column resizing properties into us…
0e9c12e5
use ref for columns to solve issue with columns being hidden/shown an…
3bf43570
Merge branch 'columnResizing' of https://github.com/marshallpete/reac…
5ca0f8f8
fix bug where resizing wouldn't work if width is not provided on the …
12250ebb
remove console.log
26f5364c
dnorth
commented
on 2022-03-10
memoize getColumnWidth and regenerate the function whenever columnWid…
9221f114
PR feedback to change old code to be more understandable.
87a973be
use a ref to save the state of the affected column resize changes, re…
f9549f96
snowystinger
commented
on 2022-03-10
update isStatic function to be more clear and add types to getContent…
d2c322b8
Simplify comparison expressions and return boundedWidth from resizeCo…
3c0be58b
make getResolvedColumnWidth more clear as to its purpose
04253c9b
columnProps rename for clarity
4f5d3606
PR feedback - move setColumnWidthsForRef closer to ref/useState
272dc712
rename util width functions to match PDF
0abad4e2
remove unused import
fb75d7d5
fix bad regex whoopsies
7ad117ff
add aria-values to resizer and add getters to set those
1999421f
merging changes
b3f2941f
add useCallback to getters
12124512
adding aria-labeledby
c2571b55
add comments to explain why we need a spooky column
77c0b564
Change AffectedColumnWidhts type to integrate the array
4ffa912e
conditionally add button props
38ef25f1
Merge branch 'columnResizing' of https://github.com/marshallpete/reac…
8e22ad13
remove unneeded interface
21d6ea29
snowystinger
commented
on 2022-03-11
Update packages/@react-stately/virtualizer/src/Virtualizer.ts
e1b33143
remove unneeded array copy
8329218e
devongovett
commented
on 2022-03-14
switch to pure function that doesn't mutate inputs
e7d7973d
rename variables for clarity
7259f567
dannify
commented
on 2022-03-14
removing the react-aria dependency in react-stately.
1e2ee481
Revert "removing the react-aria dependency in react-stately."
ca2f0a8f
add rfc
ca48557b
Merge branch 'columnResizing' of https://github.com/marshallpete/reac…
6ad30c1a
Add first round of tests for useTableColumnResizeState
0c73f6bb
Merge branch 'main' into columnResizing
25eb15f0
get layoutinfo if undefined
d7b6e743
add divider story and undefined table width/height story
a7fc5cda
support rtl
dd013db3
Merge branch 'columnResizing' of https://github.com/marshallpete/reac…
50ebf805
make Enter and Space do the same thing as Esc when resizing columns
c68881da
remove rtl class and use logical properties instead
d4ef1a83
revert to return if layoutinfo undefined
5741bd3b
fix col-resize cursor flicker issue
588f0fd2
clarify comment
452d2848
fixed virtualizer bug root cause and removed aria dependency in stately
7e9f9bd8
snowystinger
dismissed these changes
on 2022-03-18
Update packages/@react-aria/table/src/useTableColumnResize.ts
b34aa302
LFDanLu
approved these changes
on 2022-03-18
snowystinger
approved these changes
on 2022-03-18
Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Login to write a write a comment.
Login via GitHub