react-spectrum
Fix useNumberField to propagate name/placeholder props
#2884
Merged
Overview
Commits
9
Changes
View On GitHub

Fix useNumberField to propagate name/placeholder props #2884

LFDanLu merged 9 commits into adobe:main from MeowIng44:issue-2745
MeowIng44
MeowIng44 Fixed bug where useNumberField was swallowing the name and placeholde…
4b5a53f0
MeowIng44 Added jest tests for added functionality in useNumberField
5055ea42
MeowIng44 Merge branch 'adobe:main' into issue-2745
00cfba12
MeowIng44 Added back newline/spacing in call to useFormattedTextField
e1970d37
MeowIng44 MeowIng44 changed the title fix(#2745): useNumberField ignores name prop Fix useNumberField to propagate name/placeholder props 3 years ago
Alphy11
Alphy11 commented on 2022-02-24
MeowIng44 MeowIng44 marked this pull request as ready for review 3 years ago
MeowIng44 MeowIng44 requested a review from snowystinger snowystinger 3 years ago
MeowIng44 MeowIng44 requested a review from dannify dannify 3 years ago
MeowIng44 MeowIng44 requested a review from devongovett devongovett 3 years ago
snowystinger
snowystinger commented on 2022-02-24
MeowIng44
snowystinger
MeowIng44
snowystinger
MeowIng44 Addressing PR comments - moved input DOM events into a separate inter…
b17f0733
MeowIng44
snowystinger Merge branch 'main' into issue-2745
3744bd54
snowystinger
snowystinger commented on 2022-03-08
MeowIng44 Addressing PR comments - updated useNumberField.test to include test …
1c18d857
snowystinger
snowystinger approved these changes on 2022-03-09
snowystinger snowystinger added small review
MeowIng44 Merge branch 'main' into issue-2745
ab6834eb
MeowIng44
LFDanLu
LFDanLu
LFDanLu commented on 2022-03-16
LFDanLu Merge branch 'main' into issue-2745
649e8a57
LFDanLu
LFDanLu approved these changes on 2022-03-21
LFDanLu LFDanLu merged ad0fb49b into main 3 years ago
MeowIng44
MeowIng44 MeowIng44 deleted the issue-2745 branch 3 years ago
dannify dannify added needs testing
dannify dannify removed small review
dannify dannify removed needs testing
dannify dannify added release
dannify dannify removed release

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum