PR #3000 Refactor listview to always focus the row

Refactor listview to always focus the row #3000

LFDanLu merged 32 commits into main from refactor_listview_row_focus_2

initial work to focus the row instead of the cell

35809599

cleanup

e51bd3f3

tentative approach to always skip focusing the cell

928549a8

retaining focus on Listview focusable child when it is clicked

2216e982

making ListView specific keyboard delegate

dac22a85

fixing pageUp/Down operations when within the ListView row

b540f23d

adding tests

2ebabe1c

fixing tests after rebase

2a92a704

refactor to have outer div behave as both gridcell and grid row

312aaed6

fixing Home/End

dd9dac51

fixing test and getting rid of erroneous data id

17a11bdb

cleanup

d9eb366f

LFDanLu commented on 2022-04-01

lint

303304cc

LFDanLu commented on 2022-04-04

removing todo

0fe13e61

LFDanLu changed the title ~~(Approach 2) Refactor listview to always focus the row~~ Refactor listview to always focus the row 4 years ago

LFDanLu commented on 2022-04-04

updating lint so we check that a dep is actually needed before throwing

b4a4f40d

removing private

11302a30

LFDanLu commented on 2022-04-04

LFDanLu commented on 2022-04-04

snowystinger commented on 2022-04-04

pulling triggerPress outside the act

c9ba9237

Merge branch 'main' into refactor_listview_row_focus_2

db7fbe79

Merge branch 'main' into refactor_listview_row_focus_2

471139ad

snowystinger dismissed these changes on 2022-04-13

devongovett commented on 2022-04-14

LFDanLu added ListView

tentative approach to use ListLayout instead of making a ListGrid key…

f2ef4ef8

LFDanLu dismissed their stale review via f2ef4ef8 4 years ago

fixing build

0476f4fc

LFDanLu changed the title ~~Refactor listview to always focus the row~~ (WIP) Refactor listview to always focus the row 4 years ago

removing useGridRow to ensure the focused key will always be a row

2ea0c5a2

Merge branch 'main' of github.com:adobe/react-spectrum into refactor_…

b30d6047

LFDanLu commented on 2022-04-26

cleanup

53e8c7ab

LFDanLu changed the title ~~(WIP) Refactor listview to always focus the row~~ Refactor listview to always focus the row 4 years ago

Merge branch 'main' of github.com:adobe/react-spectrum into refactor_…

e659966e

adding listview story decorator for before and after focusable elements

3f7f3d8b

Merge branch 'main' of github.com:adobe/react-spectrum into refactor_…

7cf09be8

making the story input fields only appear at certain screen widths

6c02faf1

Merge branch 'main' into refactor_listview_row_focus_2

9eda1f94

snowystinger commented on 2022-05-03

devongovett dismissed these changes on 2022-05-04

addressing review comments

e4086bf8

LFDanLu dismissed their stale review via e4086bf8 4 years ago

Merge branch 'main' into refactor_listview_row_focus_2

5ed6df60

devongovett approved these changes on 2022-05-04

snowystinger approved these changes on 2022-05-04

Merge branch 'main' into refactor_listview_row_focus_2

71809a1d

LFDanLu merged 5917acf0 into main 4 years ago

LFDanLu deleted the refactor_listview_row_focus_2 branch 4 years ago

LFDanLu added needs testing

devongovett removed needs testing

Reviewers

snowystinger

devongovett

Assignees

No one assigned

Labels

ListView

Milestone

No milestone

react-spectrum Refactor listview to always focus the row #3000 Merged

Refactor listview to always focus the row #3000

react-spectrum
Refactor listview to always focus the row
#3000

Merged