react-spectrum
ListView hook refactor
#3086
Merged
Go
Login via GitHub
Home
Pricing
FAQ
Install
Login
via GitHub
Overview
Commits
54
Changes
View On
GitHub
ListView hook refactor
#3086
LFDanLu
merged 54 commits into
main
from
listview_hooks
initial work to focus the row instead of the cell
35809599
cleanup
e51bd3f3
tentative approach to always skip focusing the cell
928549a8
retaining focus on Listview focusable child when it is clicked
2216e982
making ListView specific keyboard delegate
dac22a85
fixing pageUp/Down operations when within the ListView row
b540f23d
adding tests
2ebabe1c
fixing tests after rebase
2a92a704
refactor to have outer div behave as both gridcell and grid row
312aaed6
fixing Home/End
dd9dac51
fixing test and getting rid of erroneous data id
17a11bdb
cleanup
d9eb366f
lint
303304cc
removing todo
0fe13e61
updating lint so we check that a dep is actually needed before throwing
b4a4f40d
removing private
11302a30
pulling triggerPress outside the act
c9ba9237
Merge branch 'main' into refactor_listview_row_focus_2
db7fbe79
Merge branch 'main' into refactor_listview_row_focus_2
471139ad
tentative approach to use ListLayout instead of making a ListGrid key…
f2ef4ef8
fixing build
0476f4fc
removing useGridRow to ensure the focused key will always be a row
2ea0c5a2
Merge branch 'main' of github.com:adobe/react-spectrum into refactor_…
b30d6047
cleanup
53e8c7ab
Merge branch 'main' of github.com:adobe/react-spectrum into refactor_…
e659966e
adding listview story decorator for before and after focusable elements
3f7f3d8b
adding tests for refactor
a5aa6e37
creating list aria and types packages
46147e7f
adding useListSelectionCheckbox and exporting types
005c557f
adding tests for rowindex and colindex
d35af328
replacing grid hooks with list hooks
2e6181d5
replace useSelectableCollection call with useSelectableList
6945972e
fixing docs build?
161298f5
LFDanLu
commented on 2022-04-29
LFDanLu
commented on 2022-04-29
LFDanLu
commented on 2022-04-29
LFDanLu
commented on 2022-04-29
LFDanLu
commented on 2022-04-29
LFDanLu
commented on 2022-04-29
LFDanLu
commented on 2022-04-29
LFDanLu
commented on 2022-04-29
LFDanLu
commented on 2022-04-29
LFDanLu
commented on 2022-04-29
LFDanLu
commented on 2022-04-29
cleanup and fixing docs build again
5f17b371
LFDanLu
changed the title
(WIP) ListView hook refactor
ListView hook refactor
3 years ago
Merge branch 'main' of github.com:adobe/react-spectrum into refactor_…
7cf09be8
making the story input fields only appear at certain screen widths
6c02faf1
Merge branch 'refactor_listview_row_focus_2' of github.com:adobe/reac…
a5de7e5f
Merge branch 'main' into refactor_listview_row_focus_2
9eda1f94
addressing review comments
e4086bf8
Merge branch 'main' into refactor_listview_row_focus_2
5ed6df60
Merge branch 'refactor_listview_row_focus_2' of github.com:adobe/reac…
95243816
fixing dep version
e750bf8b
Base automatically changed from
refactor_listview_row_focus_2
to
main
3 years ago
Merge branch 'main' of github.com:adobe/react-spectrum into listview_…
f7a049d1
Merge branch 'main' of github.com:adobe/react-spectrum into listview_…
4b84006c
snowystinger
commented on 2022-05-06
snowystinger
dismissed these changes on 2022-05-09
Merge branch 'main' of github.com:adobe/react-spectrum into listview_…
7197f3eb
fixing test failures
b0043030
LFDanLu
dismissed their stale review via
b0043030
3 years ago
snowystinger
dismissed these changes on 2022-05-10
Merge branch 'main' of github.com:adobe/react-spectrum into listview_…
aeaf84b3
LFDanLu
dismissed their stale review via
aeaf84b3
3 years ago
Merge branch 'main' of github.com:adobe/react-spectrum into listview_…
7e409454
snowystinger
dismissed these changes on 2022-05-10
solimant
dismissed these changes on 2022-05-11
reidbarber
dismissed these changes on 2022-05-11
Merge branch 'main' of github.com:adobe/react-spectrum into listview_…
0f73c40a
LFDanLu
dismissed their stale review via
0f73c40a
3 years ago
LFDanLu
dismissed their stale review via
0f73c40a
3 years ago
LFDanLu
dismissed their stale review via
0f73c40a
3 years ago
Merge branch 'main' of github.com:adobe/react-spectrum into listview_…
7b964917
devongovett
commented on 2022-05-11
Merge branch 'main' of github.com:adobe/react-spectrum into listview_…
ef6afc0d
devongovett
dismissed these changes on 2022-05-11
ignoring type for collection node for now
c675212f
LFDanLu
dismissed their stale review via
c675212f
3 years ago
LFDanLu
commented on 2022-05-11
small story fix
515b2265
Merge branch 'main' into listview_hooks
6871af74
snowystinger
approved these changes on 2022-05-12
devongovett
approved these changes on 2022-05-12
LFDanLu
merged
4dc28ea3
into main
3 years ago
LFDanLu
deleted the listview_hooks branch
3 years ago
Login to write a write a comment.
Login via GitHub
Reviewers
devongovett
snowystinger
reidbarber
solimant
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Login to write a write a comment.
Login via GitHub