react-spectrum
Adding FocusRing to ListView (Virtualizer persistedKeys)
#3168
Merged

Adding FocusRing to ListView (Virtualizer persistedKeys) #3168

ktabors merged 32 commits into main from listview_focusring
ktabors
ktabors Adding FocusRing to ListView
85052074
ktabors Merge branch 'main' into listview_focusring
e1cfe511
adobe-bot
snowystinger
ktabors a pass at ListView no focus and scroll modaility
c8d240f8
ktabors Merge branch 'listview_focusring' of github.com:adobe/react-spectrum …
67fab0bf
adobe-bot
ktabors
ktabors commented on 2022-05-28
ktabors ktabors marked this pull request as draft 4 years ago
ktabors
ktabors
ktabors Merge branch 'main' into listview_focusring
141c37ef
ktabors reverting change prior to virtualizer improvement
de3fe276
ktabors fixing a merge conflict mistake
356f1619
ktabors adding persisted keys to virtualizer for ListView FocusRing
3448fb26
ktabors ktabors marked this pull request as ready for review 4 years ago
ktabors ktabors marked this pull request as draft 4 years ago
snowystinger
snowystinger commented on 2022-06-14
snowystinger
snowystinger commented on 2022-06-14
ktabors handling table keys better
3886aae7
ktabors Update packages/@react-aria/virtualizer/src/Virtualizer.tsx
e9e9f5c6
ktabors Update packages/@react-stately/virtualizer/src/Virtualizer.ts
dd081b4e
ktabors missing semicolon
dbe04ace
snowystinger
snowystinger commented on 2022-06-15
snowystinger
snowystinger commented on 2022-06-15
ktabors Update packages/@react-aria/virtualizer/src/Virtualizer.tsx
16a66d07
ktabors fixingn lint errors (space and unneeded return statement
f12f25f2
adobe-bot
ktabors update to tests based on Virtualizer improvement
06914f12
adobe-bot
snowystinger
snowystinger commented on 2022-06-15
ktabors replacing recursion with while loop
6b4a6a1d
ktabors syntax fix
4af7c84c
adobe-bot
ktabors adding listview scrolling and focus tests
d76102b2
ktabors ktabors marked this pull request as ready for review 4 years ago
ktabors messed up the arrow movement prior to last commit
8cd847d2
adobe-bot
devongovett
devongovett commented on 2022-06-20
devongovett
devongovett commented on 2022-06-20
ktabors calling updateSubViews and layoutInfos keeping order matching collection
1dcd5347
ktabors fixing tests (updateSubviews still needs work)
4b3528f5
adobe-bot
snowystinger
snowystinger commented on 2022-07-01
ktabors ktabors changed the title Adding FocusRing to ListView (WIP) Adding FocusRing to ListView 4 years ago
ktabors cleaning up logic issues found by failing picker tests
88fe033f
ktabors storing some work in progress before taking a new path
33cdd074
ktabors persisted keys refactor for listview and picker (tableview needs work…
4adbd60e
ktabors Merge branch 'main' into listview_focusring
a95258db
ktabors adding persistedKey checking to TableLayout
db7f142e
ktabors tests pass and added some comments
7f2bbd78
adobe-bot
ktabors making persisted keys work with table cells
f47ae3b5
adobe-bot
ktabors ktabors changed the title (WIP) Adding FocusRing to ListView Adding FocusRing to ListView (Virtualizer persistedKeys) 4 years ago
LFDanLu Merge branch 'main' into listview_focusring
f7524e1b
adobe-bot
LFDanLu
LFDanLu commented on 2022-08-03
ktabors Merge branch 'main' into listview_focusring
237c4956
adobe-bot
ktabors preventing different loops from looking at the same item
d8e22c27
adobe-bot
LFDanLu
LFDanLu approved these changes on 2022-08-04
reidbarber
reidbarber approved these changes on 2022-08-05
ktabors Merge branch 'main' into listview_focusring
a25ca971
adobe-bot
ktabors ktabors merged c9c838b0 into main 4 years ago
ktabors ktabors deleted the listview_focusring branch 4 years ago
ktabors ktabors added needs testing
devongovett devongovett removed needs testing

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone