react-spectrum
Focus first element in scope if nodeToRestore does not exist
#3385
Merged

Focus first element in scope if nodeToRestore does not exist #3385

devongovett merged 46 commits into main from focusscope-restore
devongovett
snowystinger FocusScope tree
ee606b6f
snowystinger simplify logic
e73e0126
snowystinger Add test and handle cleanup and restoring
5619398b
snowystinger add some comments
5d00fd7c
snowystinger reorder for more readability
b09322a5
snowystinger Merge branch 'main' into focusscope-tree
1d46fd39
snowystinger fix types
579882fe
snowystinger Fix menu opens dialog
7c672dcb
snowystinger Rename variable so it's easier to read
df4b2eda
snowystinger fix lint
2766d071
Merge branch 'main' into focusscope-tree
33c79adc
snowystinger human linting
31690085
snowystinger fix restore but not contain
10f8dda3
snowystinger fix lint
93699f90
snowystinger fix 17 tests
7abd547f
snowystinger Merge branch 'main' into focusscope-tree
215c8af6
snowystinger Review updates
b64696a6
snowystinger Merge branch 'main' into focusscope-tree
d539c1d4
snowystinger Merge branch 'main' into focusscope-tree
ea8b0fdf
snowystinger fix logic for nodeToRestore
c8168706
snowystinger fix test and lint
cc4c47a9
snowystinger Merge branch 'main' into focusscope-tree
6f8f7002
devongovett Focus first element in scope if nodeToRestore does not exist
d1004e6d
devongovett Focus first item in collection when focused item is removed
7bc1c1db
devongovett Contain focus when a nested scope is active
8328f20e
devongovett Merge branch 'focusscope-tree' into focusscope2
e0f2c358
devongovett Revert focusing the first item for now
bb7aa460
devongovett Add focus scopes around some collection components
4c37cf6a
devongovett Ensure activeScope is in the tree
d4546948
adobe-bot
devongovett Track active scope even when contain and restoreFocus are false
b41fe1f7
adobe-bot
majornista majornista requested a review from majornista majornista 3 years ago
majornista
Base automatically changed from focusscope-tree to main 3 years ago
devongovett Merge branch 'main' of github.com:adobe/react-spectrum into focusscop…
daceb1a4
devongovett
adobe-bot
Merge branch 'main' into focusscope-restore
e9e2d247
adobe-bot
majornista
majornista
majornista dismissed these changes on 2022-08-09
matthewdeutsch matthewdeutsch assigned devongovett devongovett 3 years ago
matthewdeutsch matthewdeutsch assigned snowystinger snowystinger 3 years ago
snowystinger Merge branch 'main' into focusscope-restore
dd6ee095
snowystinger snowystinger dismissed their stale review via dd6ee095 3 years ago
adobe-bot
snowystinger Add test for deleting active row
53455a6c
snowystinger add more tests
c2621be4
snowystinger Merge branch 'main' into focusscope-restore
224b48f3
snowystinger fix 17 tests
9240835d
adobe-bot
snowystinger Add focus scopes around collection type components
e46122a3
snowystinger use a less fragile test
14e1501e
adobe-bot
snowystinger snowystinger marked this pull request as ready for review 3 years ago
devongovett
devongovett commented on 2022-09-07
Merge branch 'main' into focusscope-restore
7d02ff4f
adobe-bot
LFDanLu
LFDanLu commented on 2022-09-07
devongovett revert useSelectableCollection changes
aec583d7
adobe-bot
LFDanLu Merge branch 'main' of github.com:adobe/react-spectrum into focusscop…
fdb9acfb
adobe-bot
LFDanLu removing extraneous FocusScopes
54831bed
LFDanLu Merge branch 'main' into focusscope-restore
e299e10b
adobe-bot
adobe-bot
LFDanLu
LFDanLu dismissed these changes on 2022-09-08
dannify
dannify dismissed these changes on 2022-09-08
devongovett Merge branch 'main' into focusscope-restore
504b9335
devongovett devongovett dismissed their stale review via 504b9335 3 years ago
devongovett devongovett dismissed their stale review via 504b9335 3 years ago
dannify
dannify dismissed these changes on 2022-09-08
devongovett fix merge
a25fe6e5
devongovett devongovett dismissed their stale review via a25fe6e5 3 years ago
adobe-bot
devongovett devongovett merged 49026315 into main 3 years ago
devongovett devongovett deleted the focusscope-restore branch 3 years ago

Login to write a write a comment.

Login via GitHub

Labels
Milestone