react-spectrum
Focus first element in scope if nodeToRestore does not exist
#3385
Merged
Go
Login via GitHub
Home
Pricing
FAQ
Install
Login
via GitHub
Overview
Commits
46
Changes
View On
GitHub
Focus first element in scope if nodeToRestore does not exist
#3385
devongovett
merged 46 commits into
main
from
focusscope-restore
FocusScope tree
ee606b6f
simplify logic
e73e0126
Add test and handle cleanup and restoring
5619398b
add some comments
5d00fd7c
reorder for more readability
b09322a5
Merge branch 'main' into focusscope-tree
1d46fd39
fix types
579882fe
Fix menu opens dialog
7c672dcb
Rename variable so it's easier to read
df4b2eda
fix lint
2766d071
Merge branch 'main' into focusscope-tree
33c79adc
human linting
31690085
fix restore but not contain
10f8dda3
fix lint
93699f90
fix 17 tests
7abd547f
Merge branch 'main' into focusscope-tree
215c8af6
Review updates
b64696a6
Merge branch 'main' into focusscope-tree
d539c1d4
Merge branch 'main' into focusscope-tree
ea8b0fdf
fix logic for nodeToRestore
c8168706
fix test and lint
cc4c47a9
Merge branch 'main' into focusscope-tree
6f8f7002
Focus first element in scope if nodeToRestore does not exist
d1004e6d
Focus first item in collection when focused item is removed
7bc1c1db
Contain focus when a nested scope is active
8328f20e
Merge branch 'focusscope-tree' into focusscope2
e0f2c358
Revert focusing the first item for now
bb7aa460
Add focus scopes around some collection components
4c37cf6a
Ensure activeScope is in the tree
d4546948
Track active scope even when contain and restoreFocus are false
b41fe1f7
majornista
requested a review
from
majornista
3 years ago
Base automatically changed from
focusscope-tree
to
main
3 years ago
Merge branch 'main' of github.com:adobe/react-spectrum into focusscop…
daceb1a4
Merge branch 'main' into focusscope-restore
e9e2d247
majornista
dismissed these changes on 2022-08-09
matthewdeutsch
assigned
devongovett
3 years ago
matthewdeutsch
assigned
snowystinger
3 years ago
Merge branch 'main' into focusscope-restore
dd6ee095
snowystinger
dismissed their stale review via
dd6ee095
3 years ago
Add test for deleting active row
53455a6c
add more tests
c2621be4
Merge branch 'main' into focusscope-restore
224b48f3
fix 17 tests
9240835d
Add focus scopes around collection type components
e46122a3
use a less fragile test
14e1501e
snowystinger
marked this pull request as ready for review
3 years ago
devongovett
commented on 2022-09-07
Merge branch 'main' into focusscope-restore
7d02ff4f
LFDanLu
commented on 2022-09-07
revert useSelectableCollection changes
aec583d7
Merge branch 'main' of github.com:adobe/react-spectrum into focusscop…
fdb9acfb
removing extraneous FocusScopes
54831bed
Merge branch 'main' into focusscope-restore
e299e10b
LFDanLu
dismissed these changes on 2022-09-08
dannify
dismissed these changes on 2022-09-08
Merge branch 'main' into focusscope-restore
504b9335
devongovett
dismissed their stale review via
504b9335
3 years ago
devongovett
dismissed their stale review via
504b9335
3 years ago
dannify
dismissed these changes on 2022-09-08
fix merge
a25fe6e5
devongovett
dismissed their stale review via
a25fe6e5
3 years ago
devongovett
merged
49026315
into main
3 years ago
devongovett
deleted the focusscope-restore branch
3 years ago
Login to write a write a comment.
Login via GitHub
Reviewers
snowystinger
dannify
LFDanLu
majornista
Assignees
devongovett
snowystinger
Labels
None yet
Milestone
No milestone
Login to write a write a comment.
Login via GitHub