react-spectrum
Ensure checkboxes without explicit values render no `value` attribute in the DOM
#3554

Merged

Ensure checkboxes without explicit values render no `value` attribute in the DOM #3554

LFDanLu merged 5 commits into adobe:main from brandonpittman:fix/default-checkbox-values

brandonpittman closed this 3 years ago

brandonpittman reopened this 3 years ago

Fix undefined value being passed to checkbox

0dd59c0d

brandonpittman force pushed from a770519e to 9332e7c1 3 years ago

Add tests for default checkbox values

a64c26b8

brandonpittman force pushed from 9332e7c1 to a64c26b8 3 years ago

add test to switch as well

6f7a88c6

snowystinger dismissed these changes on 2022-09-26

LFDanLu commented on 2022-09-26

brandonpittman dismissed their stale review via 6645bf48 3 years ago

Update packages/@react-aria/toggle/src/useToggle.ts

6645bf48

snowystinger approved these changes on 2022-09-27

Merge branch 'main' into fix/default-checkbox-values

8acdf44c

LFDanLu approved these changes on 2022-09-28

LFDanLu merged 4def693b into main 3 years ago

Reviewers

LFDanLu

snowystinger

Assignees

No one assigned

Labels

None yet

Milestone

No milestone