react-spectrum
TableView and ListView skip focusing when empty, but have a focusable child
#3581
Merged

TableView and ListView skip focusing when empty, but have a focusable child #3581

ktabors merged 15 commits into main from table_empty_link
ktabors
ktabors TableView doesn't get focus when empty, but there is a link
7c1c4a41
ktabors Refactor plus getting to work with ListView and Virtualizer components
a220756a
ktabors some small improvments and lint type fixes
d3a64c58
ktabors making lint and test pass for a WIP build
0de0637d
snowystinger
snowystinger commented on 2022-09-30
ktabors reverting skipped tests
ea17461d
ktabors refactored useTabbableChildre to not use a MutationObserver
9a7a18f7
ktabors Factoring in empty collection to new Virtualizer tabIndex logic
83db9d0a
ktabors improving fragile test and making sure a hook is always called
7f1c71f8
ktabors moving hook to fix circular dependancy and adding listview test
bd45fa28
ktabors refactored new hook to use hooks useState and useEffect
21d8d272
adobe-bot
ktabors ktabors changed the title WIP TableView and ListView skip focusing when empty, but have a focusable child TableView and ListView skip focusing when empty, but have a focusable child 3 years ago
ktabors Merge branch 'main' into table_empty_link
46d104ba
adobe-bot
snowystinger
snowystinger commented on 2022-10-10
ktabors refactoring hook to return boolean for tabbable child existence inste…
bd31bfbd
adobe-bot
snowystinger
snowystinger dismissed these changes on 2022-10-12
ktabors removing code that didn't fix a test
32db5d30
ktabors ktabors dismissed their stale review via 32db5d30 3 years ago
ktabors
ktabors commented on 2022-10-12
adobe-bot
matthewdeutsch matthewdeutsch assigned ktabors ktabors 3 years ago
snowystinger
snowystinger commented on 2022-10-12
ktabors fixing lint warning useEffect dependencies
ad9f3817
adobe-bot
snowystinger
snowystinger approved these changes on 2022-10-13
reidbarber
reidbarber approved these changes on 2022-10-14
snowystinger Merge branch 'main' into table_empty_link
0896c7eb
adobe-bot
ktabors ktabors merged a32c05e3 into main 3 years ago
ktabors ktabors deleted the table_empty_link branch 3 years ago
dannify dannify added release
ktabors ktabors added needs testing
ktabors ktabors removed needs testing
dannify dannify removed release

Login to write a write a comment.

Login via GitHub

Assignees
Labels
Milestone