react-spectrum
Refactor column resizing for controlled state resizing
#3672
Merged
Overview
Commits
52
Changes
View On GitHub

Refactor column resizing for controlled state resizing #3672

snowystinger merged 52 commits into main from refactor-column-resizing
snowystinger
snowystinger Refactor column resizing to make a single source of truth
6adffe86
snowystinger Merge branch 'main' into refactor-column-resizing
dd8512f7
snowystinger fix merge
f3709348
adobe-bot
snowystinger fix remove column math
7fd45f9a
adobe-bot
snowystinger remove unused dep
fdb68a3a
adobe-bot
adobe adobe deleted a comment from adobe-bot on 2022-10-20
adobe adobe deleted a comment from adobe-bot on 2022-10-20
adobe adobe deleted a comment from adobe-bot on 2022-11-22
snowystinger Merge branch 'main' into refactor-column-resizing
9fe9238c
snowystinger Merge branch 'main' into refactor-column-resizing
9c39b1a9
snowystinger Move aria implementation to stately hook instead of layout
3fb46770
adobe-bot
snowystinger fix keyboard resizing and default widths
69f481d8
snowystinger use aria tests for spectrum as well
a99ca8e2
snowystinger rename some props, refactor resizer so it sets on top of everything
83c2bd1b
snowystinger restore logic to fix tests
36804cb1
snowystinger fix min/max calculations
0bed81d2
snowystinger fix all types and lint
f39e26b9
snowystinger Merge branch 'main' into refactor-column-resizing
01ada31f
snowystinger fix import
a8ab1221
snowystinger Merge branch 'refactor-column-resizing' of github.com:adobe/react-spe…
bae3c9e7
adobe-bot
snowystinger snowystinger marked this pull request as ready for review 3 years ago
snowystinger snowystinger closed this 3 years ago
snowystinger snowystinger deleted the refactor-column-resizing branch 3 years ago
snowystinger snowystinger restored the head branch 3 years ago
snowystinger snowystinger reopened this 3 years ago
snowystinger onResizeEnd called once with sizes
af599ac3
snowystinger fix aria story missing resize handles
d0c5f73e
adobe-bot
snowystinger Add story descriptions
16873d99
adobe-bot
snowystinger Fix resizer gets stuck visible
a50b0ec9
adobe-bot
snowystinger Merge branch 'main' into refactor-column-resizing
9586a1d3
adobe-bot
snowystinger simplify column header focus mode
2137c2ff
adobe-bot
snowystinger clean up and code sharing
ceca13ee
snowystinger fix lint
e9c21b72
snowystinger add test from other PR
1f57a19f
snowystinger add max width as well
acbc4c7d
snowystinger Makes types clearer
35bc3a0b
snowystinger clarify min/max width types
eb36ff61
snowystinger fix exports
a04a7a2f
adobe-bot
snowystinger fix css specificity
d0acbf77
adobe-bot
snowystinger address resizers getting stuck in hovered state
0be24891
adobe-bot
majornista
majornista requested changes on 2022-12-05
snowystinger
snowystinger commented on 2022-11-29
snowystinger Make sure input "value" updates
c68d962c
snowystinger fix lint
ca8f4230
adobe-bot
snowystinger snowystinger changed the title Refactor column resizing to make a single source of truth Refactor column resizing for controlled state resizing 3 years ago
majornista majornista requested a review from majornista majornista 3 years ago
majornista
majornista commented on 2022-12-06
majornista majornista requested a review from majornista majornista 3 years ago
majornista
majornista dismissed these changes on 2022-12-06
majornista majornista requested a review from majornista majornista 3 years ago
majornista majornista dismissed their stale review 3 years ago
Additional comment
devongovett
devongovett commented on 2022-12-06
snowystinger remove unused api
cf36abc2
adobe-bot
LFDanLu
LFDanLu commented on 2022-12-06
ktabors
ktabors commented on 2022-12-06
LFDanLu
LFDanLu commented on 2022-12-06
snowystinger Code reviews
6ff2ac29
adobe-bot
devongovett
devongovett commented on 2022-12-06
snowystinger code reviews
f5a26b42
snowystinger Merge branch 'main' into refactor-column-resizing
cd7281ab
adobe-bot
adobe-bot
adobe-bot
devongovett
devongovett commented on 2022-12-07
snowystinger more reviews
918ddd9f
snowystinger Merge branch 'main' into refactor-column-resizing
ad4dadb0
snowystinger add missed type
e7d87832
snowystinger fix types and remove read/write render ref
62dfe3d0
devongovett
devongovett commented on 2022-12-13
devongovett
devongovett commented on 2022-12-13
snowystinger re-type getDefaultWidth and add strict nulls
c1b2a75c
snowystinger remove some memos, use existing value for resizer
67560cbf
snowystinger Merge branch 'main' into refactor-column-resizing
6f9b0d47
snowystinger rename confusing variable
2cc7c682
snowystinger move column layout to table stately
afb1591b
snowystinger add resizing hide header story
a7372f82
LFDanLu
LFDanLu commented on 2022-12-13
devongovett
devongovett commented on 2022-12-13
snowystinger move types
dff4b4d6
snowystinger Fix onResizeEnd call
9b94c176
snowystinger Merge branch 'main' into refactor-column-resizing
f3302459
snowystinger move types
e905d3d4
devongovett
devongovett approved these changes on 2022-12-13
LFDanLu
LFDanLu approved these changes on 2022-12-13
snowystinger snowystinger merged 3e5f99b5 into main 3 years ago
snowystinger snowystinger deleted the refactor-column-resizing branch 3 years ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum