react-spectrum
Fix FocusScope StrictMode issues
#3878
Merged

Fix FocusScope StrictMode issues #3878

LFDanLu merged 16 commits into main from focusscope_strict_mode_fix
LFDanLu
LFDanLu LFDanLu force pushed from d9a63bfc to ff373a74 3 years ago
LFDanLu LFDanLu changed the title (WIP) Fix FocusScope StrictMode issues Fix FocusScope StrictMode issues 3 years ago
snowystinger
snowystinger commented on 2023-01-03
snowystinger
snowystinger dismissed these changes on 2023-01-05
Base automatically changed from strict-mode-fixes to main 3 years ago
LFDanLu LFDanLu dismissed their stale review via a68b999a 3 years ago
LFDanLu tentative change to fix FocusScope strict mode
63dab086
LFDanLu cleanup
ca5c2f9a
LFDanLu step back some optimization until we fix all issues
d6d99b28
LFDanLu properly assign new top level scope parent
ff22268d
LFDanLu fix table crud case
0b321afd
LFDanLu add optimizations to fit assumptions
8da00f3a
LFDanLu fix ButtonGroup strictmode test
a4cc4ee7
LFDanLu fixing focuscope test for strict mode
e7da44e3
LFDanLu making DialogTrigger tests not fail due to strict mode
2ca2c1e0
LFDanLu ensure activeScope is accurate
c819d300
LFDanLu fixing tabs tests
dfd0138a
LFDanLu removing extraneous parentScope calculation
9908d179
LFDanLu more cleanup
982c9668
LFDanLu updating test for strict mode and non strict mode consistency
0c72b098
LFDanLu LFDanLu force pushed from a68b999a to 0c72b098 3 years ago
devongovett
devongovett commented on 2023-01-09
devongovett
devongovett Create FocusScope nodes top down and add them bottom up (#3898)
cb5eab26
devongovett
devongovett approved these changes on 2023-01-11
LFDanLu Merge branch 'main' into focusscope_strict_mode_fix
38eff599
snowystinger
snowystinger approved these changes on 2023-01-11
LFDanLu LFDanLu merged 9e2d10bd into main 3 years ago
LFDanLu LFDanLu deleted the focusscope_strict_mode_fix branch 3 years ago

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone