react-spectrum
fix(#3884): useGrid: gracefully handle focus when a focused row is removed from the collection
#3885

Merged

fix(#3884): useGrid: gracefully handle focus when a focused row is removed from the collection #3885

LFDanLu merged 41 commits into main from tableview-restore-focus-on-remove-row

useTable: restore focus after current row is removed

01ccfcb1

fix CRUDExample by waiting 3 frames before removing the row

69f979d9

majornista requested a review from

devongovett 3 years ago

majornista requested a review from

LFDanLu 3 years ago

majornista requested a review from

snowystinger 3 years ago

majornista added enhancement

majornista added accessibility

majornista requested a review from

reidbarber 3 years ago

majornista requested a review from

dannify 3 years ago

majornista requested a review from

ktabors 3 years ago

fix(#3884): refactor behavior from useTable to useGrid

008c535b

majornista changed the title ~~fix(#3884): useTable: gracefully handle focus when a focused row is removed from the collection~~ fix(#3884): useGrid: gracefully handle focus when a focused row is removed from the collection 3 years ago

Merge branch 'main' into tableview-restore-focus-on-remove-row

f492e5a3

snowystinger commented on 2023-01-05

fix(#3884): add renderEmptyState examples that allow item removal

7aa62eac

Merge branch 'tableview-restore-focus-on-remove-row' of github.com:ad…

280e7b1f

fix(#3884): fix unit test to account for renderEmptyState

c5201c1d

devongovett commented on 2023-01-06

fix(#3884): fix getKeyAbove on row removal

e1bd0197

fix(#3884): useGrid: refactor to use the last focused row index

54abc1f0

fix(#3884): add support for useGridList

f677a441

majornista requested a review from

devongovett 3 years ago

majornista requested a review from

snowystinger 3 years ago

devongovett commented on 2023-01-11

fix(#3884): refactor into useGridState and useListState

35c030ab

majornista requested a review from

devongovett 3 years ago

Merge branch 'main' into tableview-restore-focus-on-remove-row

a618f4e0

adobe deleted a comment from rspbot on 2023-01-12

fix(#3885): remove redundancy

f9f4f2d5

fix(#3885): remove redundancy

b05ec8e5

fix(#3884): refine while loop to find non-disabled items

aa1f8479

fix(#3884): add unit test for disabled item in ListView

74cd8367

fix(#3884): useListState fix itemNode filter

a8a832d6

fix(#3884): add ListBox story

d44ed7d5

Merge branch 'main' into tableview-restore-focus-on-remove-row

27f9d51e

Merge branch 'main' into tableview-restore-focus-on-remove-row

5f4457d8

LFDanLu requested changes on 2023-01-17

majornista commented on 2023-01-18

fix(#3884): updates per code review

35edb9db

fix(#3884): add ListBox unit test

690e6c08

majornista requested a review from

LFDanLu 3 years ago

LFDanLu commented on 2023-01-19

fix(#3884): ListView stories add disabledBehavior attribute

52e8037c

majornista requested a review from

LFDanLu 3 years ago

LFDanLu commented on 2023-01-19

fix(#3884): Remove unnecessary ListView story

7b34ac23

fix(#3884): add unit test for row and column removal at same time

b91431e7

majornista requested a review from

LFDanLu 3 years ago

Merge branch 'main' into tableview-restore-focus-on-remove-row

1aa55baa

fix(#3884): better handle when multiple rows are removed at once

e0710b7b

Merge branch 'tableview-restore-focus-on-remove-row' of github.com:ad…

51b18c73

Merge branch 'main' into tableview-restore-focus-on-remove-row

71c6ed79

LFDanLu dismissed these changes on 2023-01-24

Merge branch 'main' into tableview-restore-focus-on-remove-row

6fe96e6c

Merge branch 'main' into tableview-restore-focus-on-remove-row

e5775a27

Merge branch 'main' into tableview-restore-focus-on-remove-row

70ab069a

Merge branch 'main' into tableview-restore-focus-on-remove-row

44af4b1c

Merge branch 'main' into tableview-restore-focus-on-remove-row

4d352f98

Merge branch 'main' into tableview-restore-focus-on-remove-row

b6df9610

Merge branch 'main' into tableview-restore-focus-on-remove-row

b101df94

majornista dismissed their stale review via b101df94 3 years ago

fix(#3884): Table.stories fix merge conflict

f30ca5c2

majornista requested a review from

LFDanLu 3 years ago

Merge branch 'main' into tableview-restore-focus-on-remove-row

cda282ac

devongovett commented on 2023-02-02

devongovett approved these changes on 2023-02-02

LFDanLu approved these changes on 2023-02-03

Merge branch 'main' into tableview-restore-focus-on-remove-row

1651282e

Merge branch 'main' into tableview-restore-focus-on-remove-row

2063d0e8

Merge branch 'main' into tableview-restore-focus-on-remove-row

eb51c4d0

LFDanLu merged 27f8fa1f into main 3 years ago

LFDanLu deleted the tableview-restore-focus-on-remove-row branch 3 years ago

Reviewers

LFDanLu

devongovett

snowystinger

reidbarber

dannify

ktabors

Assignees

No one assigned

Labels

enhancement accessibility

Milestone

No milestone

react-spectrum fix(#3884): useGrid: gracefully handle focus when a focused row is removed from the collection #3885 Merged

fix(#3884): useGrid: gracefully handle focus when a focused row is removed from the collection #3885

react-spectrum
fix(#3884): useGrid: gracefully handle focus when a focused row is removed from the collection
#3885

Merged