react-spectrum
TagGroup: Custom action
#3893
Merged
Go
Login via GitHub
Home
Pricing
FAQ
Install
Login
via GitHub
Overview
Commits
79
Changes
View On
GitHub
TagGroup: Custom action
#3893
reidbarber
merged 79 commits into
main
from
taggroup-custom-actions
add defaultVisibleRows and initial functionality
1a39b79d
cleanup
aba67e9b
rename to maxRows
31eeeb17
switch to use quiet ActionButton
2937e02f
include collapse button on last row
c93a1456
revert cleanup
5b1d0739
Merge branch 'main' into tagroup-show-all
146e8c9b
update logic
888562d1
update to use generator
3a978574
Merge branch 'main' into tagroup-show-all
ae21d323
include show all button on last row
4b2ecbe1
update story to fill width for resizing
49b75a34
add test
bba7bacf
cleanup
4639f4d4
add FocusScope
af7d23eb
improve performance
9e7bd1c6
add function for making room for collapse button
58ffb284
fix indention
dfc95aac
move into one function
ca308a3d
update test
62392e71
address review comments
5505e2f6
fix logic for showing button
4d713513
fix test
692654fc
condense getBoundingClientRect calls
7941553c
update test
fdbfc14a
Merge branch 'main' into tagroup-show-all
7062bd29
don't hide tags if all tags shown
f61d815f
update mock values
a2404316
Merge branch 'main' into tagroup-show-all
1d941e10
Merge branch 'main' into tagroup-show-all
f6204de4
update to CSF3
6a1f7465
add test for not showing button
d527fd1f
Merge branch 'main' into tagroup-show-all
740a6b0c
handle case of container width smaller than tag
32479a12
Merge branch 'main' into tagroup-show-all
d21265c0
update deps
bf793f5b
use custom keyboardDelegate when collapsed
4e7ca75e
lint
fcafa649
allow tabbing to collapse button
df2409f1
lint
81f1877e
fix button losing focus if focusedKey collapsed
a1c5d7a5
add support for actions
54238db8
add story for onRemove + maxRows
aa360a67
Merge branch 'tagroup-show-all' into taggroup-custom-actions
0af1ae2e
improve stories
7f25e422
add tests
21490bac
reidbarber
changed the title
WIP: TagGroup: Custom actions
TagGroup: Custom actions
3 years ago
snowystinger
commented on 2023-01-09
move button outside of grid
bbbd110d
lint
d3a0f99d
Merge branch 'tagroup-show-all' into taggroup-custom-actions
03ab66ae
update action API
caa3dd1f
lint
97e3c146
lint
2fe0a4a8
Merge branch 'main' into tagroup-show-all
0bb236e6
devongovett
dismissed these changes on 2023-01-11
snowystinger
commented on 2023-01-11
Merge branch 'main' into tagroup-show-all
c05009b8
snowystinger
dismissed these changes on 2023-01-12
fix refs for overflow detection
3096d2cb
add translation string
f248c6e7
remove extraneous style
df30f447
fix actionbutton style
1c14b1be
Merge branch 'main' into tagroup-show-all
58742961
recalculate after fonts load
e8829a8d
Merge branch 'main' into tagroup-show-all
a4c3f5e2
reidbarber
changed the title
TagGroup: Custom actions
TagGroup: Custom action
3 years ago
Merge branch 'main' into tagroup-show-all
2bcfc579
Merge branch 'tagroup-show-all' into taggroup-custom-actions
1d8b0858
add container for actions
88317f9d
Base automatically changed from
tagroup-show-all
to
main
3 years ago
reidbarber
dismissed their stale review via
88317f9d
3 years ago
reidbarber
dismissed their stale review via
88317f9d
3 years ago
Merge branch 'main' into taggroup-custom-actions
66672a8b
fix merge conflicts
d1e4d3a8
fix merge conflict
fad7f326
fix merge conflict
d6e2013b
snowystinger
commented on 2023-01-13
ensure onAction doesn't make it to useGridList
fe38be3d
add test
3923f24e
improve css specificity
b3faa1fc
snowystinger
dismissed these changes on 2023-01-13
ktabors
commented on 2023-01-14
Merge branch 'main' into taggroup-custom-actions
70fe11c5
ktabors
dismissed these changes on 2023-01-17
Merge branch 'main' into taggroup-custom-actions
3b6e296d
fix style
fa47c5bd
reidbarber
dismissed their stale review via
fa47c5bd
3 years ago
reidbarber
dismissed their stale review via
fa47c5bd
3 years ago
snowystinger
dismissed these changes on 2023-01-17
devongovett
commented on 2023-01-17
move actiongroup labelling to components
eff2ac5d
update translations
62e6afe7
add test
521b266b
reidbarber
dismissed their stale review via
521b266b
3 years ago
ktabors
approved these changes on 2023-01-18
snowystinger
approved these changes on 2023-01-18
Merge branch 'main' into taggroup-custom-actions
bdf95b19
Merge branch 'main' into taggroup-custom-actions
b35f3b58
reidbarber
merged
ff3e690f
into main
3 years ago
reidbarber
deleted the taggroup-custom-actions branch
3 years ago
reidbarber
added
needs testing
reidbarber
removed
needs testing
Login to write a write a comment.
Login via GitHub
Reviewers
snowystinger
ktabors
devongovett
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Login to write a write a comment.
Login via GitHub