react-spectrum
Fully scroll collection elements into view when keyboard navigating
#3899
Merged
Merged
Fully scroll collection elements into view when keyboard navigating #3899
LFDanLu
merged
41 commits into
main
from
scroll_into_view_alt_approach
temporarily making storybook scrolling
5b426926
initial progress with alternative scrollIntoView util
0a680b7c
moving scroll into view logic into Virtualizer
e114b053
scroll table into view if focusable child is out of view
dc78e03e
make standalone calendar scroll into view if cell is out of view
3c273704
fixing tabs tests
ecd2e9c3
devongovett
commented
on 2023-01-10
devongovett
commented
on 2023-01-10
account for scroll container borders
664b87f3
cleanup rafs
9a238ffd
Merge branch 'main' of github.com:adobe/react-spectrum into scroll_in…
0d9265a5
adding scrolling decorator
91fcef14
LFDanLu
changed the title
Merge branch 'main' into scroll_into_view_alt_approach
3039b89b
remove extra line
9ae6f24e
LFDanLu
commented
on 2023-01-13
LFDanLu
commented
on 2023-01-13
LFDanLu
commented
on 2023-01-13
Merge branch 'scroll_into_view_alt_approach' of github.com:adobe/reac…
a331a889
Merge branch 'main' into scroll_into_view_alt_approach
8e64421f
snowystinger
dismissed these changes
on 2023-01-18
majornista
dismissed these changes
on 2023-01-18
addressing review comments
b8d42d36
make scrollIntoView and scrollIntoViewport args consistent
6dbac3d1
Merge branch 'main' into scroll_into_view_alt_approach
4f13424a
fixing tests
639fe424
LFDanLu
commented
on 2023-01-18
Merge branch 'main' into scroll_into_view_alt_approach
f59e7878
snowystinger
dismissed these changes
on 2023-01-18
removing overrides
371eede4
Fixing function descriptions
b66776e6
add overrides back in
66e8b1ed
Merge branch 'main' of github.com:adobe/react-spectrum into scroll_in…
ba8600f5
delay scrollIntoViewport calls if popover hasnt positioned itself
55acd50d
fix virtualizer raf cleanup
63c413d1
forgot to clear scroll callbacks
859504a3
(DNM) Use scrollview scrollend to determine when it is safe to scroll…
18368fc8
more cleanup
ba2094b8
Merge branch 'main' into scroll_into_view_alt_approach
805dec42
LFDanLu
commented
on 2023-01-23
fix rendered too many hooks error
bf406c37
Merge branch 'scroll_into_view_alt_approach' of github.com:adobe/reac…
39079ed3
snowystinger
commented
on 2023-01-24
reset setDelayScrolling on popover unmount
7a588032
Merge branch 'main' of github.com:adobe/react-spectrum into scroll_in…
6a28bd2a
devongovett
commented
on 2023-01-24
get rid of global in favor of checking for overflow: hidden on document
9fecc977
apply overlay position on first render
65f3a871
update column header position early if need be
bfde0a11
Merge branch 'main' into scroll_into_view_alt_approach
0d06149c
revert signature change of scrollIntoView
6eb0d2bc
always sync column header scroll position
b648cdd6
ktabors
commented
on 2023-01-28
snowystinger
approved these changes
on 2023-01-30
Merge branch 'main' into scroll_into_view_alt_approach
5b060d28
devongovett
approved these changes
on 2023-02-01
Merge branch 'main' into scroll_into_view_alt_approach
f98b5cad
Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Login to write a write a comment.
Login via GitHub