TableView: Drag and drop support #4008
devongovett
merged
87 commits into
main
from
tableview-dnd
initial setup for TableView DnD
a951a220
improve styles
cd2c7b60
majornista
commented
on 2023-02-03
majornista
commented
on 2023-02-03
place drag button in it's own cell
678c7601
add aria-colspan to root drop indicator
35618c2c
add custom getDropTargetFromPoint
57698769
fix drop indicators and add reordering story
f9bb9c0b
address review comments
4ee2fe07
add focus ring to drag button header cell
4ffdaa87
Handle drag previews for wide columns
3e7a59d0
add visually hidden label to drag header cell
46b86865
update drag preview to show row header columns
1fb79623
add non-util dnd stories
9cbe7bc5
add remaining stories
671ed247
fix position of insertion indicator
0abac1e2
lint
14cbc10b
fix drag preview for multiple rows
a0aa5b63
fix drop position logic
8c068572
fix drop on row styles
a3898007
fix root drop styles
9752cbd8
reidbarber
changed the title
Merge branch 'main' into tableview-dnd
d475b2ad
lint
095b0cb6
add focus ring to drag preview
454e3514
focus row after dropping instead of cell
609c2efd
move RootDropIndicator inside TableRowGroup
50ab192c
remove aria-selected=false from InsertionIndicator
bc8bcfe5
remove exports to avoid duplicate stories
c6b11100
remove row tabIndex while virtual dragging
6609e1d5
remove tabIndex from table/body while virtual drag
7770181f
add descriptions to utils stories
b6693dbc
cleanup util stories
66de1a9b
fix incorrect textValues
1f2aa794
handle dropping error in complex example
d51343e4
add disabledKeys to examples
efaa9c23
Merge branch 'main' into tableview-dnd
c2af37b5
don't show drag button for disabled row
ac3ca402
improve data and add horizontal scrolling
3971c1c1
support sticky checkbox and drag cell
279de884
update TableLayout
11469318
remove extra checkbox padding
bb181bcd
Merge branch 'main' into tableview-dnd
a444182f
initial tests setup
e8b9cb4f
devongovett
commented
on 2023-03-09
fix tests
ca96e5aa
place root drop indicator inside row and gridcell
2149ccde
handle null key before
d49876be
fix more tests
d163e2ec
lint
017dfebb
fix table tests
00c86a21
reidbarber
commented
on 2023-03-10
LFDanLu
commented
on 2023-03-11
Merge branch 'main' into tableview-dnd
e06fee98
update row focus ring to not affect sticky cells
901a4fad
allow custom getKeyBefore/After for drop indicator
4fc52826
use custom getKeyBefore in InsertionIndicator
90346c67
fix test
60a0d3d0
review comments
4efe25f1
more review comments
d286612c
improve types
eb224a68
more review comments
61c2b324
lint
d47da969
lint
09335f49
remove showDragButtons prop
40d1b295
address review comments
9f97d451
Merge branch 'main' into tableview-dnd
1fa518af
snowystinger
commented
on 2023-03-14
add isTableDraggable dep
994e04b4
devongovett
commented
on 2023-03-15
remove new getKeyBefore/After API
731ac0fb
snowystinger
commented
on 2023-03-16
remove showDragButtons from state hook api
1f4357d9
persist drag column header cell
ae5ca741
lint
8b9d742c
fix whcm
45d71ac7
lint
2f2746c7
reidbarber
commented
on 2023-03-17
fix focus behavior when dragging between lists
a490b951
remove alignment from drag preview cells
5f8e1801
use textValue instead of row headers, if provided
a5beb697
Revert "use textValue instead of row headers, if provided"
015bb631
set grid tabIndex to null when virtual dragging
52f0c6b8
LFDanLu
commented
on 2023-03-22
Merge branch 'main' into tableview-dnd
5d3466dc
add `@version alpha` to prop
67e8b853
remove skipped tests for now
01d02ec5
Merge branch 'main' into tableview-dnd
3a1aac41
improve types
ac528529
add back props.showDragButtons
7e0c4406
fix index for selection checkbox cell
3b477a67
Merge branch 'main' into tableview-dnd
d2466d7f
lint
365b5243
devongovett
commented
on 2023-03-23
move SpectrumTableProps to '@react-spectrum/table'
85806c15
devongovett
commented
on 2023-03-23
Merge branch 'main' into tableview-dnd
2ae1d3b1
add back cursors
cc236380
Update packages/@react-types/table/package.json
27ddfa52
Merge branch 'main' into tableview-dnd
e65e94dd
snowystinger
approved these changes
on 2023-03-23
devongovett
approved these changes
on 2023-03-23
reidbarber
changed the title Reviewers
Assignees
Labels
None yet
Milestone
No milestone
Login to write a write a comment.
Login via GitHub