react-spectrum
Menu unavailable item
#4192
Merged

Menu unavailable item #4192

snowystinger merged 31 commits into main from menu-subdialog
snowystinger
snowystinger Menu unavailable item
c5da3b0a
snowystinger Add keyboard/touch support, remove onAction
70eafb38
snowystinger possibly a solution to restore focus for hovered items in collections
10183857
snowystinger fix menutrigger test
38f0d4b6
snowystinger Merge branch 'main' into menu-subdialog
33c95081
snowystinger fix lint
300a043a
snowystinger remove unused code
abcab4a5
snowystinger Merge branch 'main' into menu-subdialog
5dfc8d8f
snowystinger fix lint
d3c6baaa
rspbot
snowystinger snowystinger marked this pull request as ready for review 2 years ago
devongovett
devongovett commented on 2023-04-11
devongovett
snowystinger Review comments
3e41dffe
snowystinger use modal on mobile
c4de43b9
snowystinger fix lint
583eb2c2
snowystinger fix rest of lint
2880744b
rspbot
devongovett
devongovett commented on 2023-04-12
devongovett
devongovett commented on 2023-04-12
devongovett
devongovett commented on 2023-04-12
devongovett
devongovett commented on 2023-04-12
devongovett
devongovett commented on 2023-04-12
snowystinger review changes
e2f87b1a
snowystinger persist hovered style when open
12f3791b
rspbot
rspbot
snowystinger
snowystinger commented on 2023-04-12
snowystinger Fix focus behavior
d01c113d
rspbot
snowystinger expose aria-haspopup on useMenuItem
bcde85a8
snowystinger make aria hooks less spectrum specific
7f203bd8
rspbot
snowystinger Merge branch 'main' into menu-subdialog
922766a4
snowystinger remove unused pkg
c423997a
snowystinger remove unnecessary wrapper function
b34eb696
rspbot
rspbot
rspbot
snowystinger move to useEffectEvent and add test against multiple open
85c1d31b
snowystinger fix lint
e0b2c54e
rspbot
reidbarber
reidbarber commented on 2023-04-13
snowystinger Focus scope contain find next focusable even in portal-ed child scope
f4bc1069
rspbot
snowystinger Support RTL
3b2cf1fc
snowystinger Merge branch 'main' into menu-subdialog
b810c96d
rspbot
rspbot
LFDanLu
LFDanLu commented on 2023-04-14
snowystinger restoreNode and nextElement should focus there not before
339e4534
rspbot
snowystinger Merge branch 'main' into menu-subdialog
e0559640
rspbot
reidbarber
reidbarber dismissed these changes on 2023-04-26
LFDanLu
LFDanLu dismissed these changes on 2023-04-27
snowystinger Merge branch 'main' into menu-subdialog
d174b314
snowystinger snowystinger dismissed their stale review via d174b314 2 years ago
snowystinger snowystinger dismissed their stale review via d174b314 2 years ago
rspbot
snowystinger
LFDanLu
LFDanLu approved these changes on 2023-04-27
reidbarber
reidbarber approved these changes on 2023-04-27
snowystinger Merge branch 'main' into menu-subdialog
2c7bcce0
snowystinger Merge branch 'main' into menu-subdialog
41caf3cd
rspbot
rspbot
rspbot
snowystinger
snowystinger snowystinger merged 424432c8 into main 2 years ago
snowystinger snowystinger deleted the menu-subdialog branch 2 years ago

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone