react-spectrum
Fix combobox visible focus styling when opening the menu via keyboard
#4299

Merged

Fix combobox visible focus styling when opening the menu via keyboard #4299

LFDanLu merged 6 commits into main from fix_combobox_focusvisible

Make sure selection manager isFocused returns true when menu is opened

f52046e2

LFDanLu commented on 2023-03-30

adding to one other area for correctness

319bc5e6

LFDanLu changed the title ~~(WIP) Fix combobox visible focus styling when opening the menu via keyboard~~ Fix combobox visible focus styling when opening the menu via keyboard 2 years ago

LFDanLu marked this pull request as ready for review 2 years ago

LFDanLu added release

LFDanLu added ready for review

reidbarber commented on 2023-03-30

simplify logic

58d85a61

forgot to remove old code

1ebd3e96

Merge branch 'main' into fix_combobox_focusvisible

e2a9183b

LFDanLu added small review

snowystinger approved these changes on 2023-03-30

devongovett approved these changes on 2023-03-31

Merge branch 'main' into fix_combobox_focusvisible

cf015ead

LFDanLu merged c463c882 into main 2 years ago

LFDanLu deleted the fix_combobox_focusvisible branch 2 years ago

snowystinger removed release

Reviewers

devongovett

snowystinger

reidbarber

Assignees

No one assigned

Labels

small review ready for review

Milestone

No milestone

react-spectrum Fix combobox visible focus styling when opening the menu via keyboard #4299 Merged

Fix combobox visible focus styling when opening the menu via keyboard #4299

react-spectrum
Fix combobox visible focus styling when opening the menu via keyboard
#4299

Merged