v3 Menu trigger #43
LFDanLu
merged
30 commits into
master
from
menu_trigger
initial setup and progress
5b7131d0
debugging
922c230a
Adding placeholder menu and stuff
71f18f1c
adding aria hook and replacing onToggle
b6337311
Replacing cloneElement with context
46c1e95f
Changing useOverlayPosition so it works with RTL
3aa662b2
clean up
712bc2eb
Removing state package and adding types
5f36a4ae
Fixing dependencies and adding dummy tests
75f33f2c
making dummy tests actually work?
49afdc49
Merge branch 'master' into menu_trigger
80273ed1
LFDanLu
commented
on 2019-11-04
LFDanLu
commented
on 2019-11-04
LFDanLu
commented
on 2019-11-04
cleanup
18d483e5
Merge branch 'menu_trigger' of https://github.com/adobe/react-spectru…
971210f2
LFDanLu
commented
on 2019-11-04
removing arrowProps since there isn't an arrow
319aba21
LFDanLu
commented
on 2019-11-04
whoops acessibility needs type and role button
9ede7618
snowystinger
commented
on 2019-11-04
addressing review comments
d471e6bc
Removing onClose from popover props
7178419d
adding MenuTrigger tests
76cc8ea5
Removing onSelect and putting onClose into MenuContext
4f8c5272
Adding useMenuTrigger tests
922df1ad
Merge branch 'master' into menu_trigger
1acf699e
LFDanLu
commented
on 2019-11-06
adding missing deps to action menu package json
b37e13a7
Merge branch 'master' into menu_trigger
5e318a4b
Addressing review comments
828da152
ktabors
dismissed these changes
on 2019-11-11
Addressing review comments
380a5536
Merge branch 'master' into menu_trigger
dd56256a
Fixing test
d021b015
Removing onClose from popover
fca17794
Removing multi menu support for now and moving type=button to useButton
683f403a
Merge branch 'master' of https://github.com/adobe/react-spectrum-v3 i…
1177e024
ktabors
approved these changes
on 2019-11-12
Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Login to write a write a comment.
Login via GitHub