react-spectrum
RSP-1124 : TooltipV3 - Click Trigger Initial Implementation [includes arrow placements & variants]
#44
Merged

RSP-1124 : TooltipV3 - Click Trigger Initial Implementation [includes arrow placements & variants] #44

MidnightCoder06 merged 29 commits into master from clickTrigger
MidnightCoder06
first attempt at tooltip trigger
9526eb81
first attempt at useHover hook
63f24312
resolved import issues
0d15b76e
saving progress
b5f11219
proper variant appears in storyboard
7da77ea3
clicking causes tooltip to appear
df9b1c9a
the arrow appears in the proper place
aa38bbc4
saving progress
0f47552b
deferring useTooltip issues
7f2dd8f7
moving on to hover
75114444
saving progress on hover
b4d057cd
discovered the hover issue is in the action button not using the hove…
60ff9a75
the trigger works
a2910f7c
clean up
9697753a
improved open
73af1177
comments in scope addressed aside from destructuring
a68955f2
destructuring comments addressed
dc863967
quick add
c73c9a62
removed hover code
e438b2d8
MidnightCoder06 MidnightCoder06 requested a review from dannify dannify 6 years ago
MidnightCoder06 MidnightCoder06 requested a review from devongovett devongovett 6 years ago
MidnightCoder06 MidnightCoder06 requested a review from snowystinger snowystinger 6 years ago
github-actions
LFDanLu
LFDanLu commented on 2019-11-05
LFDanLu
LFDanLu requested changes on 2019-11-05
saving progress
5f46d919
github-actions
MidnightCoder06
LFDanLu
appropriate arrow style applied
e5f33a15
second approach to correct position
10454b5c
saving progress
06561d4f
added stories for proof of styling
ae4d426f
github-actions
LFDanLu
LFDanLu dismissed these changes on 2019-11-08
ktabors
ktabors commented on 2019-11-11
devongovett
devongovett commented on 2019-11-12
absorbed click trigger function
510ac3fe
props passing issue
ccc1291a
absorbed container method & got more stuff from overlayPosition
85ecb8c3
make the linter happy
40486063
MidnightCoder06 MidnightCoder06 dismissed their stale review via 40486063 6 years ago
github-actions
devongovett
devongovett approved these changes on 2019-11-12
MidnightCoder06 Merge branch 'master' into clickTrigger
0137e2f0
github-actions
MidnightCoder06 MidnightCoder06 merged 0c8d8beb into master 6 years ago
github-actions
MidnightCoder06 MidnightCoder06 deleted the clickTrigger branch 6 years ago

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone