Expandable rows TableView #4641
LFDanLu
merged
65 commits into
main
from
expandable_rows_collection_update
poking around to make Rows process nested rows
3bc6f78c
cleanup
0bf43fd0
progress
4609379e
got nested rows rendering
22dde544
fixing naming and adding way to track rows that have nested rows
9fb0a5f3
fixing expandable row detection and debugging weird TableLayout issue
d57f877e
Merge branch 'main' of github.com:adobe/react-spectrum into expandabl…
529125ea
renaming from treeble to TreeGrid
7c266250
fix cell values and weird crash with dynamic treeble with subset of k…
4db5b4cd
update left/right keyboard navigation logic
092b43c8
updating up/down keyboard navigation logic
c630325d
fixing typeahead and using this.getChildNodes whereever possible
29cd7601
cleanup and fix getText
2af16aa8
fixing index and column assignment to node
c44b1947
debugging persisted keys
b4a9cf17
adding basic story to check controlled expanded keys
c8aa238f
musings when trying to fix persisted key case
c9ca5077
enforcing user places cells before nested rows
b5c62d89
making GridNode index track position with respect to parent and addin…
a6f090eb
fixing persisted keys by adding index for headerrows and columns
56d31cbf
create Table wrapper element to conditionally render Table or TreeGri…
6671f88b
get rid of extra story
1a005262
update keyboard delegate to use node.indexOfType
fdcf68b6
adding tree grid aria
5ccc4008
fix crash on collapse
e423431a
fixes from screen reader testing
6ef96de4
setting up tests, debugging why they dont run
bb30a78c
add feature flag getter for tests for now
7d5a3a6e
fixing row border styling and adding more tests
73ec2462
Merge branch 'main' of github.com:adobe/react-spectrum into expandabl…
c0f5ca86
TableView expandable rows: rendering + interactions (#4663)
6535a2cb
Merge branch 'main' of github.com:adobe/react-spectrum into expandabl…
8c6aafe8
fix shared context for base tableview and treegrid tableview
cddc4376
fixing lint for build
4ee99c56
adding more stories
191f96af
adding more row selection test
e73aca35
make NVDA/Talkback not announce the chevron label when the cell is fo…
98f34ebd
add chevron rotation transition and increase hit target
c3cf0aed
add chromatic stories
ca0ed130
adding tests for loading state, onAction, and highlight selection
465c4714
adding persisted key and remaining keyboard nav tests
b509f400
add expand/collapse tests
4b84adb1
(WIP) Simplify TreeGridCollection by building the keymap inside state…
bf8adffc
Refactoring TableView wrapper strategy
dfcdea15
renaming tableview files
8c20b77f
getting rid of extraneous shouldShowCheckbox
1ec0debb
LFDanLu
commented
on 2023-06-30
Merge branch 'main' of github.com:adobe/react-spectrum into expandabl…
3d1eecc7
fixing tests for react-17
0f981373
LFDanLu
commented
on 2023-07-01
LFDanLu
commented
on 2023-07-11
cleaning up todos
6ab1d168
LFDanLu
commented
on 2023-07-11
LFDanLu
commented
on 2023-07-11
LFDanLu
commented
on 2023-07-11
LFDanLu
changed the title
Merge branch 'main' into expandable_rows_collection_update
9537eabe
adding alpha to types
b38acc39
LFDanLu
commented
on 2023-07-11
Add message for feature flag pointing to docs
bb2bae2a
Remove zoom transition effect from TableView (#4771)
ced41ebf
LFDanLu
commented
on 2023-07-18
LFDanLu
commented
on 2023-07-18
Adding UNSTABLE to expandable rows state hook and prop
7fc7fef2
addressing review comments
dfae99bd
moving expand/collapse chevron label to intl files
d2324b80
Merge branch 'main' of github.com:adobe/react-spectrum into expandabl…
db3348f4
ktabors
dismissed these changes
on 2023-07-18
addressing review comments (prop rename and stuff)
c517cec4
hide expandable table props from spectrum docs
777de01c
removing column node assigment to treegrid node cell
c9e9d767
expanding type and fixing tests to get rid of .onlys
de56a4ff
fix tests in 17
02515a96
Merge branch 'main' into expandable_rows_collection_update
5cfc0804
devongovett
dismissed these changes
on 2023-07-21
Fix click focus and transform overlap for expandable row chevron (#4808)
274ed6c9
ktabors
approved these changes
on 2023-07-21
dannify
approved these changes
on 2023-07-21
Merge branch 'main' into expandable_rows_collection_update
d0cf2616
Reviewers
Assignees
No one assigned
Labels
needs testing
ready for review
Milestone
No milestone
Login to write a write a comment.
Login via GitHub