to handle false a11y positives
#4759

Merged

#3578 Add the ability to add a data attribute to <HiddenSelect /> to handle false a11y positives #4759

LFDanLu merged 22 commits into adobe:main from aloysb:3578-add-data-attr-to-hidden-select

Add option to add data attribute to hidden select

cd888f12

Add the ability to add a data-attr to handle a11y false positive

5ea07def

aloysb closed this 2 years ago

aloysb reopened this 2 years ago

Improve grammar, fix typos

b8b76801

Merge branch 'main' into 3578-add-data-attr-to-hidden-select

4f001973

reidbarber requested changes on 2023-07-12

reidbarber commented on 2023-07-12

Merge branch 'adobe:main' into 3578-add-data-attr-to-hidden-select

48c88264

Make the aria-rs-a11y-ignore attribute always available

9c5035ad

Fix docs building issue

c75fe762

reidbarber requested changes on 2023-07-14

Update packages/@react-aria/select/docs/useSelect.mdx

be4c0d6d

reidbarber commented on 2023-07-14

Update packages/@react-aria/select/src/HiddenSelect.tsx

cd41037a

LFDanLu commented on 2023-07-14

reidbarber dismissed these changes on 2023-07-14

reidbarber commented on 2023-07-14

Update packages/@react-aria/select/src/HiddenSelect.tsx

efc869ad

reidbarber dismissed their stale review via efc869ad 2 years ago

reidbarber dismissed these changes on 2023-07-14

reidbarber commented on 2023-07-14

reidbarber dismissed their stale review via 818f2c1b 2 years ago

Update packages/@react-aria/select/test/HiddenSelect.test.tsx

818f2c1b

Move data attribute to container and add ignore rule to storybook axe

0e169abe

Merge branch 'main' into 3578-add-data-attr-to-hidden-select

a1c77d7e

LFDanLu dismissed these changes on 2023-07-15

majornista commented on 2023-07-17

majornista dismissed these changes on 2023-07-17

LFDanLu dismissed their stale review via 15725dfc 2 years ago

Update storybook selector

15725dfc

LFDanLu commented on 2023-07-17

reidbarber dismissed these changes on 2023-07-17

LFDanLu dismissed these changes on 2023-07-17

Merge branch 'main' into 3578-add-data-attr-to-hidden-select

86972ce7

LFDanLu requested a review from

majornista 2 years ago

yihuiliao dismissed these changes on 2023-07-19

Merge branch 'main' into 3578-add-data-attr-to-hidden-select

d34b10bd

Merge branch 'main' into 3578-add-data-attr-to-hidden-select

0b6cc5f0

devongovett commented on 2023-07-19

updating aria-attribute

d9ed7303

LFDanLu dismissed their stale review via d9ed7303 2 years ago

fix tests

84d5acd1

Merge branch 'main' into 3578-add-data-attr-to-hidden-select

da4b452c

reidbarber approved these changes on 2023-07-31

Merge branch 'main' into 3578-add-data-attr-to-hidden-select

493554f3

ktabors commented on 2023-08-01

devongovett approved these changes on 2023-08-01

Merge branch 'main' into 3578-add-data-attr-to-hidden-select

55348d8e

LFDanLu dismissed their stale review 2 years ago

addressed

LFDanLu merged 3aa6dbe3 into main 2 years ago

Reviewers

devongovett

reidbarber

LFDanLu

ktabors

yihuiliao

majornista

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

react-spectrum #3578 Add the ability to add a data attribute to <HiddenSelect /> to handle false a11y positives #4759 Merged

#3578 Add the ability to add a data attribute to <HiddenSelect /> to handle false a11y positives #4759

react-spectrum
#3578 Add the ability to add a data attribute to <HiddenSelect /> to handle false a11y positives
#4759

Merged