react-spectrum
Add `isPending` prop to `Button` component which triggers a spinner.
#4900
Merged
Overview
Commits
53
Changes
View On GitHub

Add `isPending` prop to `Button` component which triggers a spinner. #4900

reidbarber merged 53 commits into main from iamwillpowell-pending-button
iamwillpowell
iamwillpowell Add `isPending` prop to `Button` component which triggers a spinner.
2fa8da74
iamwillpowell Merge branch 'main' into iamwillpowell-pending-button
683bc0d9
iamwillpowell Fix lint errors
e0289806
rspbot
devongovett
devongovett commented on 2023-08-15
iamwillpowell Added test
e4f86a86
iamwillpowell Only import the necessary package from react-aria
0ba3bab1
rspbot
iamwillpowell Remove unnecessary timeout ref.
a1085836
rspbot
iamwillpowell Merge branch 'main' of https://github.com/adobe/react-spectrum into i…
dfffebb2
iamwillpowell Merge remote-tracking branch 'origin' into iamwillpowell-pending-button
27223a50
iamwillpowell Remove pointer events override
4d883365
iamwillpowell Update test
5292b76d
iamwillpowell Add hook to filter out interactions during pending
4a47b741
iamwillpowell Added cases to story
48bd7bd0
iamwillpowell Merge branch 'main' of https://github.com/adobe/react-spectrum into i…
dc1fb8ab
rspbot
iamwillpowell update pending story
ed50d25c
iamwillpowell whitespace fix
02b743a5
iamwillpowell update pending story
0f91faa3
iamwillpowell update pending story
5f9cf52b
rspbot
rspbot
iamwillpowell Merge branch 'main' into iamwillpowell-pending-button
8fa373e5
rspbot
iamwillpowell remove spacing override on loader icon
625b4ab6
iamwillpowell make anchor button-like things disabled when pending
a2a13162
iamwillpowell update button docs
992193ee
iamwillpowell Simplify button story
ceaa0a13
rspbot
iamwillpowell Update isPending tests
511234c3
rspbot
iamwillpowell Merge branch 'main' into iamwillpowell-pending-button
25f4408d
iamwillpowell iamwillpowell marked this pull request as ready for review 2 years ago
rspbot
snowystinger
snowystinger requested changes on 2023-08-23
majornista
majornista commented on 2023-08-23
iamwillpowell Merge branch 'main' into iamwillpowell-pending-button
4a475ca3
rspbot
iamwillpowell Apply progressCircle overBackground to static color buttons
2361ad38
iamwillpowell Style display with visibility instead of opacity
effc291d
iamwillpowell Improve vertical centering of spinner
4799d9ff
iamwillpowell Remove extra dependency
086386c8
iamwillpowell Added more disabled props while pending
2f7cef67
iamwillpowell Update Pending docs
10714f6f
iamwillpowell Rename function so it doesn't sound like a hook
3c869302
iamwillpowell Defense
316fc92d
iamwillpowell Use proper naming convention
22faaed9
iamwillpowell Simplify story naming
8c168841
iamwillpowell Update test
bc9f1dc0
iamwillpowell Add aria-live to pending button when pending
d960ef4b
iamwillpowell Merge branch 'main' of https://github.com/adobe/react-spectrum into i…
600fb52a
rspbot
snowystinger
snowystinger commented on 2023-08-28
iamwillpowell Add check that spinner isn't in document
35c86859
iamwillpowell Remove cruft
b912dadd
iamwillpowell Move progressCircle props to component
4846a6c8
iamwillpowell Fix typos
baeaa134
rspbot
reidbarber
reidbarber requested changes on 2023-08-28
iamwillpowell change story action
2fc1b109
iamwillpowell fix typo
b479bb86
iamwillpowell Add additional info to isPending type comment
ac9689aa
iamwillpowell Merge branch 'iamwillpowell-pending-button' of https://github.com/ado…
c6ba42a8
iamwillpowell Merge branch 'main' into iamwillpowell-pending-button
8bf81c79
iamwillpowell Fix lint problem
6266e7f2
rspbot
iamwillpowell Remove focus and blur from blocked events
2b66f702
iamwillpowell prefix isPending with UNSTABLE
fb36ce33
iamwillpowell Merge branch 'main' of https://github.com/adobe/react-spectrum into i…
fc157cf3
iamwillpowell remove doc changes for now
1cfadfeb
rspbot
snowystinger
snowystinger commented on 2023-08-29
iamwillpowell Revert unintended change
cabf0069
snowystinger
snowystinger approved these changes on 2023-08-29
rspbot
rspbot
reidbarber
reidbarber approved these changes on 2023-08-29
reidbarber reidbarber merged 53ddbb66 into main 2 years ago
reidbarber reidbarber deleted the iamwillpowell-pending-button branch 2 years ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum