Submenu support #4976
LFDanLu
merged
168 commits into
main
from
submenu_alt_api
adding stories and chevron
73121aa0
planning
c19f4630
fix sections in items
e70ac623
scuffed experimentation with getting sub menu to render
0e96be3b
notes from api review
adecad67
reset state of some files and add tentative SubMenuTrigger implementa…
23c61f05
Merge branch 'main' of github.com:adobe/react-spectrum into submenu_a…
f19a292b
update static story and dynamic story for testing
5484732d
fix dynamic story
3df94278
update sub menu interactions
96002186
fix onOpen undef and test onBlurWithin
5740696a
use useMenuTrigger to get proper submenutrigger id and aria-labelledb…
f5d847bb
add onAction inheritence between submenus and test aria-controls
2e15eb4f
fix crash
1ff49307
explored alt dynamic render function, update rest of the existing sto…
3dacd00b
Merge branch 'main' of github.com:adobe/react-spectrum into submenu_a…
9b3ef1f2
making all menus close on menu action trigger
74cee9e6
making sub menu item ArrowLeft not close all menus
20afdf17
fix user provided onClose not firing and ContextualHelpTrigger isUnav…
af387f6a
add complex and align/placement stories
d09e2f53
fix lint and circular dependency
51b07dec
add onSubMenuClose instead of having a isSubMenu bool and passing the…
79d1defb
add first batch of tests
03afdfd1
prevent SubMenuTrigger items from being selected
ec39ea1c
make Escape close all menus without triggering user provided onClose
6d5256e8
Add stories + tests for user provided handlers and make onCloseAllMen…
9ed35811
Adding selection and onOpenChange tests
25f88a6b
fixng tests and lint
7a23255b
fix last failing tests
a516600d
fix mutated submenu trigger keys
e02fc8c8
fix tests
b6328e5b
use menuProps from useMenuTrigger for submenu props and restore new u…
1cb918ae
tentative workaround to close all menus when clicking outside
64b92f2e
fix tests
b2fdf562
add onAction to stories and test for aria-controls
73dc2fd6
Removing several MenuTrigger props from SubMenu as per discussion
396b8b8c
make submenu trigger use menuitem role and adding additional tests
e0438770
finally fix sub menu width
e8a0d155
fix infinite repositioning loop
ccfe054b
rough refactor progress
e81234eb
fix ArrowRight closing too many menus and preventing close when focus…
ba8c0c36
fix aria attribute propagation to submenu trigger
508d38cc
save state
0352e42b
move stuff into hooks
2cee0029
stopgap lint and test fixes
99dbe453
attempting to close submenu whenever focus moves out of its active scope
e08fc0ae
fixing submenu close behavior when moving focus from trigger or into …
f1b482d1
Merge branch 'main' of github.com:adobe/react-spectrum into submenu_a…
983590ad
adding/fixing tests for new submenu hover behavior
73ca8eb9
Update ContextualHelpTrigger to work with useSubMenuTrigger
285d7915
fix tabbing in ContextualHelpTrigger refactor
a40d334d
Merge branch 'main' of github.com:adobe/react-spectrum into submenu_a…
895a8d4d
fixing tabbing behavior between submenu/trigger and retaining menu it…
d34d2d27
updating tests for userEvent library upgrade
92fbb324
clearing expandedKeyStack when user clicks underlay and comment cleanup
59049fee
adding test for tab/shift tabbing
e3951164
Merge branch 'main' of github.com:adobe/react-spectrum into submenu_a…
afe74290
LFDanLu
commented
on 2023-09-12
updating menu tree state expanded keys on submenu open/close
8b4cd1e7
fix test
614ed5fa
inital progress with Tray submenu
97f95d7a
adding rough styling and removing popover specific logic from tray
f8687ab8
Merge branch 'main' of github.com:adobe/react-spectrum into submenu_a…
0bedc616
fix lint
7b82c90c
update context name and fix ContextualHelpTrigger behavior when focus…
0b77e0ea
Merge branch 'main' of github.com:adobe/react-spectrum into submenu_a…
7f54902f
adding tray tests and fixing submenu overflow
5013ddd0
Fix tray autofocus behavior with touch and add remaining tests
5d58d7bd
replacing submenu aria-labelledby with aria-label due to parent menu …
2c05ae74
move submenu styles to css files
d7045fcc
fixing submenu cross offset
147aa9dd
fix tests
f9bf3af5
fix ContextualHelpTrigger dialog offset and hover behavior when enter…
59f0c5d5
update labeling so it uses hook
66ce9694
fix tests
2c6921a8
Merge branch 'main' of github.com:adobe/react-spectrum into submenu_a…
122c0d78
partial cleanup and fix build
ed943643
Revert "update labeling so it uses hook"
a580ebd4
Revert "fix tests"
800681d7
converting hooks to UNSTABLE and other cleanup
a30ba3e6
LFDanLu
commented
on 2023-09-21
LFDanLu
commented
on 2023-09-21
LFDanLu
commented
on 2023-09-21
LFDanLu
commented
on 2023-09-21
LFDanLu
commented
on 2023-09-21
LFDanLu
commented
on 2023-09-21
LFDanLu
commented
on 2023-09-21
LFDanLu
commented
on 2023-09-21
LFDanLu
commented
on 2023-09-21
LFDanLu
commented
on 2023-09-21
LFDanLu
commented
on 2023-09-21
LFDanLu
commented
on 2023-09-21
LFDanLu
commented
on 2023-09-21
LFDanLu
commented
on 2023-09-21
LFDanLu
commented
on 2023-09-21
LFDanLu
commented
on 2023-09-21
LFDanLu
commented
on 2023-09-21
LFDanLu
commented
on 2023-09-21
LFDanLu
commented
on 2023-09-21
adding sample chromatic test with interactions
b99d9fcc
add tray tests
5f479d2a
fix chromatic tray interactions
82c23dbc
LFDanLu
commented
on 2023-09-25
LFDanLu
commented
on 2023-09-25
LFDanLu
commented
on 2023-09-25
reidbarber
commented
on 2023-09-25
LFDanLu
commented
on 2023-09-25
LFDanLu
commented
on 2023-09-25
Making ContextualHelpTrigger tray modal a tray instead
6fb865e8
Make SubMenu Tray a dialog with heading
49440eba
partial fix for stacking drop shadow issue
7796ed3e
Adding useKeyboard to useMenu and updating tests
3e515d68
Expanding useMenuItem types and fixing Esc and keyup behavior
c4f134c1
merge useMenuState into useMenuTriggerState
17688192
Stop updating tree state expanded keys in favor of returning level fr…
cad5ee21
Making it so a menu trigger that is set as the selectedKey doesnt act…
4e85079d
forgot to remove the state combination
9f300432
Merge branch 'main' of github.com:adobe/react-spectrum into submenu_a…
c10e88ec
fix styles for ContextualHelpTrigger tray experience
805f4794
Merge branch 'main' of github.com:adobe/react-spectrum into submenu_a…
bedebfca
reaname SubMenu -> Submenu
828f1286
Merge remote-tracking branch 'origin/main' into submenu_alt_api
a53f5568
fix git casing
b764b7d0
Merge branch 'main' into submenu_alt_api
bfef23e3
Submenus: prevent pointer events on menu if moving towards submenu (#…
677930c4
Merge remote-tracking branch 'origin/main' into submenu_alt_api
f395ae82
Merge remote-tracking branch 'origin/main' into submenu_alt_api
0df6b0c9
rename subMenu -> submenu
d042f115
fix types
4f27ebc0
update useSafelyMouseToSubmenu to set menu style
b6560921
Merge remote-tracking branch 'origin/main' into submenu_alt_api
51c6359e
Merge remote-tracking branch 'origin/main' into submenu_alt_api
43386687
Merge remote-tracking branch 'origin/main' into submenu_alt_api
2b39e7bb
remove dup style
b5c31554
fix tests
b78f1c20
lint
becdd654
fix ts
5da908c1
code review
5d075da8
fixing submenu tray header positioning and getting rid of non-issue t…
2d9b5811
improve submenu safe area experience
197a4760
add story with many items
0704752d
fix dup key
d67974ef
partial progress on getting rid of onExit
0f3b4675
sharing TrayHeaderWrapper with SubMenu and ContextualHelpTrigger
4555f90b
don't measure for safe area when outside of menu
0743c1f5
typo
5df0aae0
removing contains on ContextualHelpDialog
04879ae5
clean up more todos
d23af09a
Merge branch 'main' of github.com:adobe/react-spectrum into submenu_a…
84f5178f
fix menu overflow behavior and rendering for an available ContextualH…
2ffe274b
LFDanLu
commented
on 2023-10-31
initial docs
f2b543d1
Merge branch 'submenu_alt_api' of https://github.com/adobe/react-spec…
13b1c1f9
add dynamic example to docs
da265f55
adding prop table for SubmenuTrigger and additional copy
96e01bb8
Merge branch 'submenu_alt_api' of github.com:adobe/react-spectrum int…
5f4dbc50
fix mobile w/ keyboard focus behavior when closing submenu
da373613
fixing tray experience on desktop with small screens
3debcf46
review comments
98869934
Merge branch 'main' of github.com:adobe/react-spectrum into submenu_a…
27a26138
addressing review comments
1ed78855
getting rid of weird double border
57b4d48d
Fix SubMenu tray scrolling if there are many items
b1d27d49
Merge branch 'main' into submenu_alt_api
60d7e4cc
get rid of erroneous border and background color and fix tray height
4aaaf7d2
Merge branch 'main' into submenu_alt_api
a73b5685
Merge branch 'main' into submenu_alt_api
0a8f8209
Merge branch 'main' into submenu_alt_api
e9a68ac2
restore drop shadow
1d8df9ac
make contextual help dialog full width
ad58498c
fixing tests
15931e75
fix scrollbars appearing when closing all submenus
d1221412
forgot to save
b5b08346
fix tests
8330b5ff
fix focus being lost to body when using hidden dismiss button in Safari
edc2575f
Merge branch 'main' into submenu_alt_api
d808ed89
LFDanLu
commented
on 2023-11-16
remove transition from submenu and rename onDismiss for clarity
7f988e32
fix keyboard scrolling for long menus and tabindex
3b8d3ca9
merge overlay and popover props
5bd7cb74
unwrap ref in ContextualHelpTrigger
36b82d3e
fix event propagation when in contextual help or on submenutrigger
3f8e6e0e
forgot to remove comment
3c629ad2
Merge branch 'submenu_alt_api' of github.com:adobe/react-spectrum int…
18b95a82
fixes from test session
7bcefb39
Merge branch 'main' of github.com:adobe/react-spectrum into submenu_a…
7a505018
remove extraneous flush sync now that we completely leave the menu on…
01400265
omit selectableitem props from submenutrigger items
90d3007f
update submenu unmount animation
818ce9a1
fix case where submenus dont properly open/close when rapidly opening…
6f8bb412
Merge branch 'main' into submenu_alt_api
a16362d9
fix tests
e12c61e2
fix alignment
3f4e313a
clearing timeout and adding comment for offset
af97396b
snowystinger
commented
on 2023-11-28
clear autoclose timeout if user moves mouse before it fires
54f568fe
snowystinger
approved these changes
on 2023-11-28
devongovett
approved these changes
on 2023-11-30
Merge branch 'main' into submenu_alt_api
0513f533
Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Login to write a write a comment.
Login via GitHub