react-spectrum
Submenus: prevent pointer events on menu if moving towards submenu
#5082
Merged
Overview
Commits
54
Changes
View On GitHub

Submenus: prevent pointer events on menu if moving towards submenu #5082

reidbarber merged 54 commits into submenu_alt_api from submenu+safe
reidbarber
reidbarber initial conversion
eb500565
reidbarber initialize safe area submenu hook
13717a4d
reidbarber lint
2eece1ab
reidbarber lint peerDeps
3333fca7
reidbarber Merge remote-tracking branch 'origin/submenu_alt_api' into submenu+safe
ae3a0cd6
rspbot
LFDanLu
LFDanLu commented on 2023-09-15
LFDanLu
LFDanLu commented on 2023-09-15
adobe adobe deleted a comment from rspbot on 2023-09-15
reidbarber disable if submenu isn't open
ce534223
reidbarber add comment for angle calculation
15d35bfd
reidbarber cleanup direction check
1c9b05cd
reidbarber remove menuRef
126ca26c
reidbarber update lastProcessedTime
cc29b08e
rspbot
adobe adobe deleted a comment from rspbot on 2023-09-15
snowystinger
snowystinger commented on 2023-09-18
reidbarber fix style props merge
e2aec869
reidbarber
rspbot
LFDanLu Merge branch 'submenu_alt_api' of github.com:adobe/react-spectrum int…
c9287828
rspbot
adobe adobe deleted a comment from rspbot on 2023-09-18
reidbarber merge style props
39098f1d
LFDanLu
LFDanLu commented on 2023-09-19
reidbarber Merge remote-tracking branch 'origin/submenu_alt_api' into submenu+safe
4867f072
reidbarber early return for touch and pen pointerType
5b9bd35f
reidbarber add timeout
3b2d5995
reidbarber fire pointerenter
36522626
reidbarber add padding to top/bottom angles
27cd2c6c
reidbarber allow 2 invalid movements
2fbae1c1
reidbarber add padding as const
661373c3
reidbarber use pointerover to trigger underlying item
05edd4e1
reidbarber up the timeout to 1s
bfc0f102
reidbarber cleanup from merge
44c30689
reidbarber store direction as ref and rename
53d89966
reidbarber type
0f5fd939
reidbarber bail early when pointer reaches submenu
d6816d1c
reidbarber clear timeout if bailing early
82c2e6c8
reidbarber move up cleartimeout
fb4b61a3
reidbarber fix test
be9ad103
reidbarber add skip
a81eaea1
reidbarber Merge remote-tracking branch 'origin/submenu_alt_api' into submenu+safe
2f1dc8a2
reidbarber Merge remote-tracking branch 'origin/submenu_alt_api' into submenu+safe
e26d8701
reidbarber Merge remote-tracking branch 'origin/submenu_alt_api' into submenu+safe
52d6500d
reidbarber fix ts strict
b5a9e92d
reidbarber Merge remote-tracking branch 'origin/submenu_alt_api' into submenu+safe
f3329f59
reidbarber add interaction modality check
4a0d987e
reidbarber Merge remote-tracking branch 'origin/submenu_alt_api' into submenu+safe
aa7dd64b
reidbarber remove skip
c01f1a7f
reidbarber revert mock
49f518cc
rspbot
adobe adobe deleted a comment from rspbot on 2023-09-22
LFDanLu Merge branch 'submenu_alt_api' of github.com:adobe/react-spectrum int…
7751b125
rspbot
adobe adobe deleted a comment from rspbot on 2023-09-25
reidbarber attempt to fix contextualhelp
be4ba512
reidbarber fix ref
bdad2367
reidbarber make submenu ref optional
07a26f11
reidbarber fix logic and allow disabling
50497651
reidbarber attempt to fix refs for unavailable menu item
9ea8d382
reidbarber Merge remote-tracking branch 'origin/submenu_alt_api' into submenu+safe
d4eeab60
reidbarber fix from merge conflict
e15ed5e7
reidbarber conditionally render overlay to avoid dup refs
ec182386
reidbarber add missing textValue
38db634d
reidbarber merge
a15f5f6c
reidbarber Merge branch 'submenu_alt_api' into submenu+safe
aff9d869
reidbarber Merge remote-tracking branch 'origin/submenu_alt_api' into submenu+safe
8a205f34
reidbarber fix from merge
bf88880f
reidbarber fix safe pointer movement for submenus
bf2da47c
rspbot
rspbot
reidbarber reidbarber merged 677930c4 into submenu_alt_api 2 years ago
reidbarber reidbarber deleted the submenu+safe branch 2 years ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum