RAC: Submenu support #5648
reidbarber
merged
81 commits into
main
from
rac-submenu-2
initialize RAC submenu
4c54a2f3
use cached children
75edf1ff
cleanup
dbc2cf83
use one useRenderProps
8bdd9545
types
5d7c9a68
cleanup
da103f01
fix trigger ref
0100aa58
typescript
bd95e34f
add chevron style to submenu trigger
2e6b265b
types
c3cb4120
cleanup
a61d762a
pass submenu ref
acc91446
Merge remote-tracking branch 'origin/main' into rac-submenu-2
afb26c06
add submenu story to menu story file
f7bbc67d
fix nested case
9537ac5a
cleanup
5eeaefe3
add nested story
e41c5808
fix trigger attribute
0fab5de0
add tests
74c94e5b
update jsdoc
93eae69d
add docs
0ac5950d
update storybook styles
531f8809
Merge branch 'main' into rac-submenu-2
0353aada
fix docs types
78bb7096
Merge branch 'rac-submenu-2' of https://github.com/adobe/react-spectr…
46ee9caf
cleanup tests
444a0517
move imports in docs closer to example
268619e2
typescript
e7c12076
add example to homepage
a11f5882
close all submenus if underlay is clicked
a7405f95
revert autoformatting from headwind
10862ded
add to small example, fix imports and labels
5193143c
render via portal
2461c4c8
add render props and data attributes
9f215a23
add || undefined
774a5242
add many items example
4a6064d5
add keys for storybook
2f1c070e
imrove styles on docs page
ff34be56
improve homepage styles
7c456181
move chevron into item wrapper
de49d822
Merge remote-tracking branch 'origin/main' into rac-submenu-2
ffcbbd4b
ts lint
e00dd275
lint
d6509a2d
story style update
d8fdc048
style isSubmenuOpen states
087315bc
add dynamic example to dcs
26133356
don't allow submenu trigger to be a link
c52c8c52
clarify submenutrigger children order in types
e9777b68
use proper hover state from useHover
5aee52ba
update tests
6cd4870a
update docs to clarify children
db7f4383
remove top -5 offset
ed2fb5c4
add disabled submenu example
292fac0b
fix iOS VO submenu closing issue
05c89e34
add Select story with many items
14f5584f
move docs chevron styles from inline to CSS snippet
5db57188
export SubmenuTrigger directly without forwardRef
8e1f11c0
update render props
63ee5029
fix indentation
dcea3978
add has-submenu to tailwind plugin
544f5e15
remove offset
d136d0aa
Merge remote-tracking branch 'origin/main' into rac-submenu-2
b15ba521
Merge branch 'main' into rac-submenu-2
e2df1d22
fix homepage example styles
c4bc0637
fix docs example dark mode style
e9fd9873
focus trigger on escape
4b068604
add test for focus menu trigger after submenu closes via escape
85c38bf5
Merge remote-tracking branch 'origin/main' into rac-submenu-2
d4d30582
majornista
dismissed these changes
on 2024-01-30
add alpha tag to docs
161a84a8
add JSDoc
66e5b97b
fix restoring focus to menu trigger after nested submenu closed via E…
3dfab719
lint
51e34f08
Merge branch 'main' into rac-submenu-2
e208c997
Render popover outside menu item div
4389c5cd
support a custom delay prop in hook and RAC
f85a0b8e
remove from homepage and tailwind starter for now
77c5cab6
LFDanLu
commented
on 2024-02-02
Merge branch 'main' into rac-submenu-2
7c9ac79e
revert auto-formatting
7174f6da
Merge remote-tracking branch 'origin/main' into rac-submenu-2
b8ab5862
Merge branch 'rac-submenu-2' of https://github.com/adobe/react-spectr…
31df5724
LFDanLu
approved these changes
on 2024-02-02
devongovett
approved these changes
on 2024-02-05
Merge branch 'main' into rac-submenu-2
efc1c46b
reidbarber
dismissed their stale review
1 year ago
Discussion here: https://github.com/adobe/react-spectrum/pull/5648#discussion_r1475257003
Login to write a write a comment.
Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone