react-spectrum
Make submenu properly size itself to fill available room and improve overlay positioning when pinch zoomed
#5660

Merged

Make submenu properly size itself to fill available room and improve overlay positioning when pinch zoomed #5660

LFDanLu merged 26 commits into main from submenu_flip

progress on adding 2d flipping

a2fad9cb

calculate max height of overlays using the overlay bottom instead of …

4fffbffa

fix some tests

28e1303d

fix more tests

9b7edc91

todo: question about what the actual behavior should be

a7590dbe

bounding the max height by the height of the boundary

62b6a0d9

getting rid of flip and fixed edge flip code

cfaea382

update left bottom postion tests

c5350a3b

fixing remaining test

59733523

some cleanup of old logic

f47fb665

missed some last cleanup

0aab18c9

LFDanLu commented on 2024-01-05

Fix overlay positioning when the boundary has been scrolled

ec8bb2c4

LFDanLu commented on 2024-01-09

ktabors requested changes on 2024-01-10

fix max height calc and Safari overlay positioning when already pinch…

3722d307

accidentally deleted too much

8631ef47

Merge branch 'main' into submenu_flip

4d3fbaff

LFDanLu changed the title ~~Make submenu properly shift itself up/down if it would otherwise extend past the screen~~ Make submenu properly size itself to fill available room and improve overlay positioning when pinch zoomed 2 years ago

forgot a set of parens ugh

eb0ad135

Merge branch 'main' into submenu_flip

0458b7f6

fix examples where triggers are placed at the bottom of the page and …

f0822ffd

LFDanLu commented on 2024-01-13

this works, but why...

08139cbb

fix logic

122e8ba5

devongovett dismissed these changes on 2024-01-23

snowystinger dismissed these changes on 2024-01-23

ktabors dismissed these changes on 2024-01-23

update copy

f2a11125

LFDanLu dismissed their stale review via f2a11125 2 years ago

Merge branch 'main' into submenu_flip

2a4b15c5

snowystinger approved these changes on 2024-01-23

Merge branch 'main' into submenu_flip

5f6bf125

devongovett approved these changes on 2024-01-23

Merge branch 'main' into submenu_flip

916d3255

Merge branch 'main' into submenu_flip

2804a676

Merge branch 'main' into submenu_flip

63ea2726

LFDanLu merged 476595b7 into main 2 years ago

LFDanLu deleted the submenu_flip branch 2 years ago

LFDanLu restored the head branch 2 years ago

LFDanLu deleted the submenu_flip branch 2 years ago

Reviewers

devongovett

snowystinger

ktabors

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

react-spectrum Make submenu properly size itself to fill available room and improve overlay positioning when pinch zoomed #5660 Merged

Make submenu properly size itself to fill available room and improve overlay positioning when pinch zoomed #5660

react-spectrum
Make submenu properly size itself to fill available room and improve overlay positioning when pinch zoomed
#5660

Merged