react-spectrum
feat: Focus Management within ShadowDOM
#6046
Merged
Overview
Commits
146
Changes
View On GitHub

feat: Focus Management within ShadowDOM #6046

snowystinger merged 146 commits into adobe:main from ritz078:shadow-dom-enhancement-1-getRootNode
MahmoudElsayad
MahmoudElsayad Add `getRootNode` utility.
c026270f
MahmoudElsayad Update `getRootNode` util.
9299ceec
MahmoudElsayad Update `getOwnerWindow` util.
71836e38
MahmoudElsayad Add tests for Shadow DOM handling using `getRootNode`.
10893b98
MahmoudElsayad Update comment.
5f81d34a
MahmoudElsayad Fix FocusScope.tsx in Shadow DOM.
bfb94290
MahmoudElsayad Add more test for FocusScope.test.js.
3448ed77
MahmoudElsayad Fix another `useRestoreFocus` issue with restoring focus in `Keyboard…
0c07404b
MahmoudElsayad Add tests for `getDeepActiveElement`
90906bf4
MahmoudElsayad Add `useFocus` shadow DOM tests.
314fc44e
MahmoudElsayad Update `focusSafely`.
9cb6c5a7
MahmoudElsayad Update `useInteractionOutside` for Shadow DOM support.
67399bb1
MahmoudElsayad Update `useFocusVisible` for Shadow DOM support.
59c37056
MahmoudElsayad Add `useInteractOutside` tests.
3c854088
MahmoudElsayad Add test for use case mentioned in issue #1472.
61ba1b0a
MahmoudElsayad Add tests for `usePress` hook.
75d7fa50
MahmoudElsayad Update the fix for `useInteractOutside` to use simpler one.
db45ef48
MahmoudElsayad Update `useOverlay` to use composedPath.
f9b94a36
MahmoudElsayad Tests refactor.
758575c6
MahmoudElsayad Revert `useOverlay` changes as it works correctly without these changes.
25ef5c5a
MahmoudElsayad Fix types.
0d4f70ef
MahmoudElsayad Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
3cf20910
MahmoudElsayad MahmoudElsayad marked this pull request as ready for review 2 years ago
MahmoudElsayad Fix types.
1d8c4391
MahmoudElsayad lint.
e5dbda17
MahmoudElsayad lint.
ae7b76ef
ritz078
MahmoudElsayad Fix failing tests.
aea5d8dd
MahmoudElsayad Fix failing tests.
f2ca9b79
MahmoudElsayad Fix failing tests.
4d6ff95e
MahmoudElsayad Test CI
4c53797a
MahmoudElsayad Test CI
85b7146d
MahmoudElsayad Fix shadow DOM tests
a001f2a3
MahmoudElsayad Fix shadow DOM tests.
d00f0b2a
MahmoudElsayad Fix CI?
e875828b
MahmoudElsayad Fix CI?
b483e61d
MahmoudElsayad Fix CI?
b8ef0550
MahmoudElsayad Re-add commented test.
cc2a7c4d
yihuiliao
MahmoudElsayad MahmoudElsayad closed this 2 years ago
MahmoudElsayad MahmoudElsayad reopened this 2 years ago
ritz078 Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
7447a797
MahmoudElsayad Update `getRootNode` to handle iframes as well, and everything that …
492d83f7
MahmoudElsayad Merge remote-tracking branch 'upstream/main' into shadow-dom-enhancem…
139a2092
snowystinger Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
805561b3
davidferguson
MahmoudElsayad
davidferguson
MahmoudElsayad Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
a3199916
MahmoudElsayad
MahmoudElsayad Fix tests.
dc2231d6
MahmoudElsayad Fix tests?
bd536b6a
MahmoudElsayad Fix tests?
f1aa64ae
MahmoudElsayad
MahmoudElsayad Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
6426c081
MahmoudElsayad Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
7cafb6aa
ritz078
snowystinger
snowystinger
MahmoudElsayad Fix tests.
1a3e0689
MahmoudElsayad
MahmoudElsayad
MahmoudElsayad Fix tests.?
f1fe3644
MahmoudElsayad Fix tests.?
24550d63
MahmoudElsayad Fix tests.?
b9a11ee5
MahmoudElsayad Fix tests.?
97d73f29
MahmoudElsayad Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
720ee183
MahmoudElsayad
snowystinger Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
6f80dbc8
snowystinger
rspbot
rspbot
snowystinger Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
6ca6996d
snowystinger
snowystinger commented on 2024-05-28
MahmoudElsayad Apply suggestions from code review
1f6ecf39
MahmoudElsayad Update packages/@react-aria/interactions/test/usePress.test.js
13278d93
snowystinger
snowystinger commented on 2024-05-29
MahmoudElsayad - Update tests to use `createShadowRoot` util.
93a50714
MahmoudElsayad Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
4ca6f759
MahmoudElsayad - Update tests and remove reactCompat.
9fa339d0
MahmoudElsayad Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
0586b9e3
MahmoudElsayad - Leftover.
90e52b96
MahmoudElsayad Merge remote-tracking branch 'origin/shadow-dom-enhancement-1-getRoot…
f2b2d188
MahmoudElsayad - Revert changes to getFocusableTreeWalker.
717a8ab0
MahmoudElsayad - Remove casting.
979a542f
MahmoudElsayad - return null in case element is disconnected in `getRootNode`.
fbe8f89a
MahmoudElsayad - Casting.
bd222919
MahmoudElsayad - Update unit test.
6548170b
snowystinger
snowystinger commented on 2024-06-06
MahmoudElsayad - Handle focus movements between shadow DOMs.
db93e53d
MahmoudElsayad - TS fixes.
98e255e1
MahmoudElsayad Merge remote-tracking branch 'upstream/main' into shadow-dom-enhancem…
820cd72b
MahmoudElsayad Merge remote-tracking branch 'refs/remotes/upstream/main' into shadow…
580e1f03
MahmoudElsayad Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
e15086e8
MahmoudElsayad Update usePress.test.js
9453cac2
MahmoudElsayad Refactors and TS errors.
debb4ba7
MahmoudElsayad Update fix.
cd6a2d77
MahmoudElsayad Remove broken sandbox link.
7673da17
MahmoudElsayad Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
a8773c1f
MahmoudElsayad
MahmoudElsayad MahmoudElsayad requested a review from snowystinger snowystinger 2 years ago
snowystinger
ritz078
snowystinger
snowystinger Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
60cb5dac
snowystinger
snowystinger commented on 2024-07-16
snowystinger Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
8d2a6dd4
devongovett devongovett force-pushed the main branch from 52c048e2 to 8cb1a5d3 2 years ago
devongovett devongovett force-pushed the main branch from 8cb1a5d3 to 3013156e 2 years ago
snowystinger Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
52baba26
MahmoudElsayad Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
afd28e9f
MahmoudElsayad Refactor `getRootNode` to improve root node handling.
173cb03f
MahmoudElsayad Use `getDeepActiveElement` inside focusSafely.ts to get the active el…
9d40d58c
MahmoudElsayad Refactor event listener registration
40cd5dd2
MahmoudElsayad Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
72596b99
MahmoudElsayad Remove `ownerDocument` fallback in usePress.ts
ae30def5
MahmoudElsayad
MahmoudElsayad MahmoudElsayad requested a review from snowystinger snowystinger 2 years ago
snowystinger
MahmoudElsayad Refactor `createEventListener` for type-safe caching.
c5ddb242
MahmoudElsayad
MahmoudElsayad Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
4ce0c1c6
MahmoudElsayad Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
d75d68fc
MahmoudElsayad - Test out the updated getOwnerWindow to fix iframe focus issues.
2d847576
MahmoudElsayad - Test out the updated getOwnerWindow to fix iframe focus issues.
a690850b
MahmoudElsayad - Test?
638d7ebc
MahmoudElsayad - Revert Focus scope changes, for testing.
2c4a9bce
MahmoudElsayad - Fix tests?
9210f8e2
MahmoudElsayad - Fix tests?
3cb08744
MahmoudElsayad - Fix tests?
0181bc3a
MahmoudElsayad - Revert the changes to getRootNode.
930a2c3d
MahmoudElsayad - Revert `isElementInScope` as well.
1cecef01
MahmoudElsayad - Test out if instance check failure across context for iframes is wh…
2bd25ddd
MahmoudElsayad - Replace the use of `instanceof` with `nodeType` to correctly identi…
bc7d1886
MahmoudElsayad - Fix ESlint errors.
3b6a4cd9
MahmoudElsayad Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
66614160
MahmoudElsayad
MahmoudElsayad Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
18f05192
devongovett devongovett force-pushed the main branch from fc5c8bd8 to e60fb427 1 year ago
devongovett devongovett force-pushed the main branch from a79adcf0 to 3013156e 1 year ago
ritz078
snowystinger Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
27d8d858
snowystinger snowystinger changed the title Focus Management within Shadow DOM feat: Focus Management within Shadow DOM 1 year ago
snowystinger
snowystinger dismissed these changes on 2024-10-16
snowystinger
alexandersorokin
MahmoudElsayad
alexandersorokin
alexandersorokin
alexandersorokin commented on 2024-10-16
MahmoudElsayad Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
22e75e62
snowystinger snowystinger changed the title feat: Focus Management within Shadow DOM feat: Focus Management within ShadowDOM 1 year ago
MahmoudElsayad - Update the usages of `instanceof` to use `nodeType` instead.
51932a55
MahmoudElsayad MahmoudElsayad dismissed their stale review via 51932a55 1 year ago
MahmoudElsayad
snowystinger
snowystinger commented on 2024-10-24
MahmoudElsayad Update packages/@react-aria/interactions/src/useFocusVisible.ts
541dd5f5
MahmoudElsayad Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
4b352601
MahmoudElsayad - Update the usages of `instanceof` to use `nodeType` instead.
3fa8c44d
MahmoudElsayad - Lint.
ab9f8dbd
MahmoudElsayad - Lint.
47be3933
MahmoudElsayad
alexandersorokin
MahmoudElsayad
alexandersorokin
MahmoudElsayad - Update `getDeepActiveElement` to accept an optional document or sha…
54cfe242
MahmoudElsayad Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
e918e38d
MahmoudElsayad
snowystinger
snowystinger dismissed these changes on 2024-10-31
alexandersorokin
MahmoudElsayad - Add extra unit test for `getDeepActiveElement`.
95a6b64f
MahmoudElsayad MahmoudElsayad dismissed their stale review via 95a6b64f 1 year ago
MahmoudElsayad - Update `getDeepActiveElement` to always rely on `getRootNode`.
c830aabb
MahmoudElsayad - Update `getDeepActiveElement` to always rely on `getRootNode`.
319617f4
MahmoudElsayad Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
3e1730ea
MahmoudElsayad
MahmoudElsayad MahmoudElsayad requested a review from snowystinger snowystinger 1 year ago
snowystinger
snowystinger dismissed these changes on 2024-11-01
snowystinger Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
0d0af544
MahmoudElsayad
snowystinger
snowystinger Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
563501a7
snowystinger Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
5aeb0240
snowystinger refactor usePress to still have global listeners for cleanup across b…
03c23c4d
snowystinger snowystinger dismissed their stale review via 03c23c4d 1 year ago
LFDanLu
snowystinger fix lint and test
cf3f567b
snowystinger Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
64348e47
dielduarte
snowystinger restore remaining document level listeners
fc82be09
snowystinger fix tests
b62d83fd
snowystinger fix lint
366565cb
snowystinger simplify
edc9892b
snowystinger
snowystinger commented on 2024-12-16
snowystinger Update packages/@react-aria/focus/src/FocusScope.tsx
9b08f75e
snowystinger Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
39543de4
snowystinger
snowystinger fix autofocus
4c4e0066
snowystinger
LFDanLu
LFDanLu commented on 2024-12-17
devongovett
devongovett commented on 2024-12-18
snowystinger
snowystinger Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
bbdb3420
devongovett
LFDanLu
LFDanLu commented on 2024-12-18
LFDanLu minor test updates to preserve test intent
96b91665
snowystinger review comments
87b35422
snowystinger fix esm test
650bf4af
snowystinger fix lint
1660aad1
snowystinger Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
d90cc98e
snowystinger Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
c43a15e3
snowystinger Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
0d962dbc
snowystinger check in speed tests
9bf04b18
snowystinger fix lint
21b80bdd
snowystinger
snowystinger snowystinger force pushed from 80daa95d to 21b80bdd 1 year ago
snowystinger Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
5bf5bb7c
ritz078
snowystinger Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
a4f35b13
snowystinger
snowystinger dismissed these changes on 2025-01-22
snowystinger
snowystinger Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
4e425194
snowystinger Add feature flag and fix a couple probable bugs
393c6982
snowystinger snowystinger dismissed their stale review via 393c6982 1 year ago
snowystinger
snowystinger dismissed these changes on 2025-01-28
snowystinger Merge branch 'main' into shadow-dom-enhancement-1-getRootNode
71e3d328
devongovett
devongovett dismissed these changes on 2025-02-06
snowystinger
snowystinger commented on 2025-02-06
snowystinger Update NOTICE.txt
dc4ca82c
snowystinger snowystinger dismissed their stale review via dc4ca82c 1 year ago
snowystinger snowystinger dismissed their stale review via dc4ca82c 1 year ago
snowystinger
snowystinger approved these changes on 2025-02-06
snowystinger snowystinger enabled auto-merge 1 year ago
devongovett
devongovett approved these changes on 2025-02-06
snowystinger snowystinger merged c78b2483 into main 1 year ago
snowystinger

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum