react-spectrum
Refactor logic to prevent breaking changes in useToastState
#6270
Merged

Refactor logic to prevent breaking changes in useToastState #6270

LFDanLu merged 14 commits into main from toast_state_take_2
LFDanLu
LFDanLu Refactor logic to prevent breaking changes in useToastState
fbd91725
rspbot
snowystinger Merge branch 'main' into toast_state_take_2
b83af040
snowystinger
snowystinger dismissed these changes on 2024-04-26
rspbot
ktabors added more tests and fixing a bug they caught
6ffd4f50
ktabors Merge branch 'toast_state_take_2' of github.com:adobe/react-spectrum …
1e7184ab
ktabors ktabors dismissed their stale review via 1e7184ab 1 year ago
ktabors
ktabors Fixed the other bug found by new tests
fbde4819
rspbot
LFDanLu LFDanLu changed the title Refactor logic to prevent breaking changes in useToastState (WIP) Refactor logic to prevent breaking changes in useToastState 1 year ago
LFDanLu fix toast visual insertion so it inserts at the bottom
344b1245
rspbot
LFDanLu remove uneeded key and handle case where a user just calls remove
a69022eb
LFDanLu LFDanLu changed the title (WIP) Refactor logic to prevent breaking changes in useToastState Refactor logic to prevent breaking changes in useToastState 1 year ago
LFDanLu
LFDanLu commented on 2024-04-26
rspbot
LFDanLu LFDanLu added needs testing
LFDanLu LFDanLu added release
devongovett
devongovett commented on 2024-04-26
devongovett
devongovett commented on 2024-04-27
LFDanLu tentative change to readd exiting to toasts that are shifted out of t…
d8122215
LFDanLu
LFDanLu commented on 2024-04-29
rspbot
LFDanLu fix so that a toast that is removed but not closed doesnt get removed…
2edead2f
rspbot
LFDanLu Merge branch 'main' of github.com:adobe/react-spectrum into toast_sta…
02cf240a
LFDanLu
rspbot
ktabors
ktabors dismissed these changes on 2024-04-30
snowystinger
snowystinger dismissed these changes on 2024-04-30
LFDanLu Merge branch 'main' into toast_state_take_2
6ca5d849
rspbot
LFDanLu Merge branch 'main' into toast_state_take_2
ead99196
rspbot
devongovett
devongovett dismissed these changes on 2024-04-30
LFDanLu add test to make sure order of toast doesnt change on close
735fcab6
LFDanLu LFDanLu dismissed their stale review via 735fcab6 1 year ago
LFDanLu LFDanLu dismissed their stale review via 735fcab6 1 year ago
LFDanLu LFDanLu dismissed their stale review via 735fcab6 1 year ago
rspbot
snowystinger
snowystinger approved these changes on 2024-04-30
devongovett
devongovett approved these changes on 2024-04-30
devongovett Merge branch 'main' into toast_state_take_2
9026e593
rspbot
rspbot
LFDanLu LFDanLu merged 1bd538fa into main 1 year ago
LFDanLu LFDanLu deleted the toast_state_take_2 branch 1 year ago
dannify dannify removed release

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone