react-spectrum
Update calculatePosition to handle overlays that have margins on them
#6831
Merged

Update calculatePosition to handle overlays that have margins on them #6831

devongovett merged 11 commits into main from fix_s2_tooltip_positioning
LFDanLu
LFDanLu Update calculatePosition to handle overlays that have margins on them
06a950d4
LFDanLu
LFDanLu commented on 2024-08-06
rspbot
LFDanLu Use the proper margins depending on the cross axis
d76d2d17
LFDanLu
rspbot
reidbarber
reidbarber dismissed these changes on 2024-08-06
LFDanLu Update packages/@react-aria/overlays/src/calculatePosition.ts
856f60c8
LFDanLu LFDanLu dismissed their stale review via 856f60c8 1 year ago
snowystinger
snowystinger dismissed these changes on 2024-08-06
rspbot
LFDanLu Make s2 tooltip arrow properly clamp itself to the overlays edges
d119c232
LFDanLu make chromatic snapshot better?
6906bd21
LFDanLu actually make the chromatic snapshot work
1dd18885
LFDanLu LFDanLu dismissed their stale review via 1dd18885 1 year ago
rspbot
LFDanLu make sure to not block out manual testing with controlled open
4b079fc1
LFDanLu
rspbot
snowystinger
snowystinger commented on 2024-08-06
LFDanLu
snowystinger
LFDanLu
snowystinger
yihuiliao
LFDanLu
yihuiliao
LFDanLu
LFDanLu
LFDanLu remove default open state for tooltip stories
c8b03b7e
LFDanLu readd default open state for chromatic tooltip stories via storybook …
c92c3c33
rspbot
LFDanLu
LFDanLu commented on 2024-08-07
LFDanLu
LFDanLu commented on 2024-08-07
LFDanLu
rspbot
snowystinger
snowystinger approved these changes on 2024-08-08
snowystinger Merge branch 'main' into fix_s2_tooltip_positioning
d5e6a003
rspbot
reidbarber
reidbarber approved these changes on 2024-08-12
LFDanLu Merge branch 'main' into fix_s2_tooltip_positioning
35b0194a
rspbot
devongovett
devongovett approved these changes on 2024-08-16
devongovett devongovett merged 3a48d449 into main 1 year ago
devongovett devongovett deleted the fix_s2_tooltip_positioning branch 1 year ago

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone