react-spectrum
fix+tests: fix Disclosure bugs and add tests
#7096
Merged
Overview
Commits
4
Changes
View On GitHub

fix+tests: fix Disclosure bugs and add tests #7096

devongovett merged 4 commits into main from disclosure-tests
reidbarber
reidbarber326 days ago

โœ… Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

๐Ÿ“ Test Instructions:

๐Ÿงข Your Project:

reidbarber add disclosure tests
cdb89585
reidbarber reidbarber added release
reidbarber lint/cleanup
718ab1e2
rspbot
reidbarber reidbarber changed the title test: Add Disclosure tests fix+tests: fix Disclosure bugs and add tests 326 days ago
ktabors
ktabors commented on 2024-09-26
ktabors326 days ago

Unrelated to this PR, do we want a RAC DisclosureGroup story?

packages/react-aria-components/test/Disclosure.test.js
10 * governing permissions and limitations under the License.
11 */
12
13
import {
ktabors326 days ago

No RSP or S2 tests because they use RAC, right?

reidbarber326 days ago

Yeah, I think these tests + chromatic give us good coverage for those

Unrelated to this PR, do we want a RAC DisclosureGroup story?

Yeah, we can have that in a follow up.

ktabors
ktabors dismissed these changes on 2024-09-26
snowystinger Merge branch 'main' into disclosure-tests
b8f4aa0d
rspbot
devongovett Pass isExpanded to useDisclosure as well
0b490aff
devongovett devongovett dismissed their stale review via 0b490aff 326 days ago
snowystinger
snowystinger approved these changes on 2024-09-26
rspbot
devongovett
devongovett approved these changes on 2024-09-26
devongovett devongovett merged d57bd8d9 into main 326 days ago
devongovett devongovett deleted the disclosure-tests branch 326 days ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
release
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum