react-spectrum
feat: Add Autocomplete wrapper for Menu and ListBox
#7181
Merged

feat: Add Autocomplete wrapper for Menu and ListBox #7181

LFDanLu merged 54 commits into main from autocomplete
LFDanLu
LFDanLu scaffolding, copied Combobox and renamed to Autocomplete
c33ac962
LFDanLu get listbox rendering by default without open state
a185473c
LFDanLu update intl file and more clean up to get rid of combobox stuff
e6fa7c16
LFDanLu fix lint
61aab83b
LFDanLu rough working version of Menu instead of Listbox in autocomplete
66fecc8e
LFDanLu fix submenu
779309be
rspbot
LFDanLu
LFDanLu commented on 2024-10-11
LFDanLu
LFDanLu commented on 2024-10-15
LFDanLu LFDanLu added in sprint
LFDanLu Update autocomplete to have the wrapped menu filter itself
78de7f82
LFDanLu fix keyboard interactions, and clean up
e0f098af
LFDanLu fix menu, add more stories, fix strict
5914d117
LFDanLu add announcements to menu and various clean up
12480fd3
LFDanLu update yarn.lock
ad8942a7
LFDanLu Merge branch 'main' of github.com:adobe/react-spectrum into autocomplete
70c2d0f9
adobe adobe deleted a comment from rspbot on 2024-10-22
LFDanLu get rid of dom node in Autocomplete and fix readOnly bugs
9812c3c8
LFDanLu fix build failure
84789377
LFDanLu test against popover experience
3fbd35f9
rspbot
LFDanLu fix popover story
e15d9992
rspbot
LFDanLu properly clear aria-activedecendant
368a677f
LFDanLu
LFDanLu commented on 2024-10-24
LFDanLu
LFDanLu commented on 2024-10-24
rspbot
LFDanLu
LFDanLu commented on 2024-10-24
LFDanLu
LFDanLu commented on 2024-10-24
LFDanLu
LFDanLu commented on 2024-10-24
LFDanLu
LFDanLu commented on 2024-10-24
LFDanLu
LFDanLu commented on 2024-10-24
LFDanLu
LFDanLu commented on 2024-10-24
LFDanLu
LFDanLu commented on 2024-10-24
LFDanLu
LFDanLu commented on 2024-10-24
LFDanLu
LFDanLu commented on 2024-10-24
LFDanLu cleanup
82b31206
LFDanLu fix build
423b73c5
LFDanLu Merge branch 'main' into autocomplete
6c498f12
rspbot
LFDanLu properly focus trap the autocomplete popover
fe5bfbe4
romansndlr
LFDanLu
LFDanLu update interaction pattern as per discussion
477ca7f7
LFDanLu update yarn.lock
9a58613b
rspbot
LFDanLu dont autofocus if user hasnt typed in the field yet
574bd671
LFDanLu add delay for now to make NVDA announcement better
ae7a00fe
LFDanLu fix lint and scrap custom announcements
7b11c5d4
LFDanLu intial tests
04e8777c
rspbot
LFDanLu more tests and fixes to BaseCollection and keyboard interactions from…
79c90648
LFDanLu fix lint and add RAC test
b20b626a
rspbot
LFDanLu Merge branch 'main' of github.com:adobe/react-spectrum into autocomplete
28afe214
LFDanLu use MenuSection
2d0a15fd
adobe adobe deleted a comment from rspbot on 2024-11-07
rspbot
cheema-corellian
LFDanLu
LFDanLu (WIP) Refactor autocomplete logic to use custom events to update virt…
c87a5078
rspbot
LFDanLu Merge branch 'main' of github.com:adobe/react-spectrum into autocomplete
682357fb
LFDanLu fix lint and test with wrapping Listbox
3871e7b9
rspbot
cheema-corellian
LFDanLu refactor so that we defer to the child input as much as possible for …
e3c3c35d
rspbot
LFDanLu
LFDanLu commented on 2024-11-23
LFDanLu cleanup
04d9a8bc
rspbot
LFDanLu fix listbox test
07578321
LFDanLu Merge branch 'main' of github.com:adobe/react-spectrum into autocomplete
fd709a25
LFDanLu LFDanLu marked this pull request as ready for review 303 days ago
LFDanLu LFDanLu changed the title (WIP) Autocomplete with menu Add Autocomplete wrapper for Menu and ListBox 303 days ago
LFDanLu LFDanLu changed the title Add Autocomplete wrapper for Menu and ListBox feat: Add Autocomplete wrapper for Menu and ListBox 303 days ago
rspbot
LFDanLu fix build and react 19
9eede0c2
LFDanLu get rid of leftover react 19 testing changes
6bd52704
LFDanLu
LFDanLu commented on 2024-11-25
rspbot
LFDanLu clean up some todos
150bd7ed
LFDanLu
LFDanLu commented on 2024-11-25
LFDanLu fix listbox listeners not registering
c13544bc
LFDanLu updating tests and making enter trigger listbox link
0d68f688
LFDanLu
LFDanLu commented on 2024-11-26
rspbot
LFDanLu
LFDanLu commented on 2024-11-26
devongovett
devongovett approved these changes on 2024-11-26
devongovett
devongovett requested changes on 2024-11-26
snowystinger
snowystinger commented on 2024-11-26
LFDanLu initial review comments
d8c52595
LFDanLu update tests and remove menu id coercing in favor of user defined ids
00f67add
LFDanLu fix lock
1a26d794
rspbot
snowystinger
snowystinger commented on 2024-11-27
LFDanLu Merge branch 'main' of github.com:adobe/react-spectrum into autocomplete
435c6dc9
LFDanLu update forward ref for react fast refresh
df033397
rspbot
LFDanLu Merge branch 'main' of github.com:adobe/react-spectrum into autocomplete
ce45f412
LFDanLu updates from testing
c184ca05
LFDanLu make virtual focus collections non tabbable
93cef2f9
rspbot
LFDanLu use event target on listener for id instead of in useSelectableItem
8d7c5b36
rspbot
LFDanLu update story to match shell use case more closely
1a781909
rspbot
LFDanLu properly stop propagation of original input keyup event so triggering…
ec124eb7
rspbot
rspbot
LFDanLu LFDanLu added release
devongovett
devongovett commented on 2024-12-04
LFDanLu
LFDanLu commented on 2024-12-04
devongovett
devongovett commented on 2024-12-05
devongovett
devongovett commented on 2024-12-05
devongovett
devongovett commented on 2024-12-05
devongovett
devongovett approved these changes on 2024-12-05
reidbarber
reidbarber approved these changes on 2024-12-05
LFDanLu LFDanLu merged f90799b3 into main 290 days ago
LFDanLu LFDanLu deleted the autocomplete branch 290 days ago

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone