PR #7423 fix: correctly format date/time in RTL

fix: correctly format date/time in RTL #7423

yihuiliao merged 53 commits into main from bidi-override

bdo on timefield, reverse segments on timefield in datefield

bbe61919

fix lint

0716ad52

adobe deleted a comment from rspbot on 2024-11-21

make things inline

76b8d0e0

use unicode character to wrap segments

47e2af50

fix test

ef0b6379

append unicode to text in hooks, update rac

b3e2f70e

Merge branch 'main' into bidi-override

7b77f1e3

add comment

fd5a9024

Merge branch 'main' into bidi-override

d9b69a8a

skip failing test for now

a9f732eb

update keyboard nav

8df5ad6e

update logic of how unicode is applied

679e355e

fix spacing

bedf7139

adobe deleted a comment from rspbot on 2025-01-07

add comments

c2df4423

update tests

90801881

undo some previous changes

2b5fb138

wrap time segments in lri, wrap fields in unicode isolate

91173c35

fix ssr test

79a8da32

adobe deleted a comment from rspbot on 2025-01-09

fix spacing

b9239048

fix css logic

ae03f3bf

fix lint

2bbde198

adobe deleted a comment from rspbot on 2025-01-10

fix keyboard nav in rac datepicker popover

81560bd3

fix lint

dad9cebf

prevent overflow in date range picker

ec8fe1d7

Merge branch 'main' into bidi-override

a863e18c

adobe deleted a comment from rspbot on 2025-01-14

move overflow hidden to separate new div to fix weird focus ring arou…

891dce95

this time actually fix the overflow and focus ring issue

4b56394c

update var names to be nicer

1a9eaa99

fix japanese placeholder for extra space

f50b4b13

fix css positioning

e39f1ead

Merge branch 'main' into bidi-override

05ed94da

fix custom width

ccf7b859

yihuiliao changed the title ~~wip: fix incorrect date/time order in rtl (pt 2)~~ wip: fix incorrect date/time order in rtl 1 year ago

yihuiliao commented on 2025-01-15

small css changes so that rtl will format properly

b1915c20

memo ordering of segments for keyboard navigation

af3ab18b

adobe deleted a comment from rspbot on 2025-01-15

add chromatic tests

50bb4df7

fix lint

1bd410ef

add tests to rsp date components

623219d8

adobe deleted a comment from rspbot on 2025-01-17

add tests to rac

ccf7defd

fix tests

ccce891d

Merge branch 'main' into bidi-override

2e682e2b

yihuiliao commented on 2025-01-17

remove comment

6efe67f3

fix chromatic stories

0fdb98d2

add chromatic story

ab2a67a7

yihuiliao changed the title ~~wip: fix incorrect date/time order in rtl~~ fix incorrect date/time order in rtl 1 year ago

yihuiliao changed the title ~~fix incorrect date/time order in rtl~~ fix: ensure date/time segments are ordered correctly in RTL 1 year ago

yihuiliao marked this pull request as ready for review 1 year ago

snowystinger commented on 2025-01-18

snowystinger commented on 2025-01-19

remove style tests

83d27271

fix lint

9e74c076

update to uselayouteffect and update keyboard nav test

e48425b9

make date input more consistent with using display inline

8e10996a

update timefield docs css to use display inline

13d47a99

snowystinger commented on 2025-01-23

fix showFormatHelpText

4d1adff7

small change

9acdf226

fix lint

c02ec95e

add divs to keyboard navigation so it works with older versions

e564b9c7

fix lint + fix tests

77a6bb90

yihuiliao commented on 2025-01-24

yihuiliao changed the title ~~fix: ensure date/time segments are ordered correctly in RTL~~ fix: correctly format date/time in RTL 1 year ago

adobe deleted a comment from rspbot on 2025-01-24

snowystinger approved these changes on 2025-01-24

devongovett approved these changes on 2025-01-25

yihuiliao merged e228ed81 into main 1 year ago

yihuiliao deleted the bidi-override branch 1 year ago

Reviewers

snowystinger

devongovett

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

react-spectrum fix: correctly format date/time in RTL #7423 Merged

fix: correctly format date/time in RTL #7423

react-spectrum
fix: correctly format date/time in RTL
#7423

Merged